From: Guenter Roeck <linux@roeck-us.net>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Andrew Jeffery <andrew@aj.id.au>,
openbmc@lists.ozlabs.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: Enabling pmbus power control
Date: Mon, 19 Apr 2021 23:00:25 -0700 [thread overview]
Message-ID: <9639fa33-01ca-9802-e745-5e3edb81e305@roeck-us.net> (raw)
In-Reply-To: <YH5rky8nA4nKAVdg@hatter.bewilderbeest.net>
On 4/19/21 10:50 PM, Zev Weiss wrote:
[ ... ]
> I had a glance at the enclosure driver; it looks pretty geared toward SES-like things (drivers/scsi/ses.c being its only usage I can see in the kernel at the moment) and while it could perhaps be pressed into working for this it seems like it would probably drag in a fair amount of boilerplate and result in a somewhat gratuitously confusing driver arrangement (calling the things involved in the cases we're looking at "enclosures" seems like a bit of a stretch).
>
> As an alternative, would something like the patch below be more along the lines of what you're suggesting? And if so, would it make sense to generalize it into something like 'pmbus-switch.c' and add a PMBUS_HAVE_POWERSWITCH functionality bit or similar in the pmbus code instead of hardcoding it for only LM25066 support?
>
>
No. Don't access pmbus functions from outside drivers/hwmon/pmbus.
I used to be opposed to function export restrictions (aka export namespaces),
but you are making a good case that we need to introduce them for pmbus
functions.
Guenter
next prev parent reply other threads:[~2021-04-20 6:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 8:17 Enabling pmbus power control Zev Weiss
2021-03-30 10:34 ` Guenter Roeck
2021-03-30 11:22 ` Mark Brown
2021-03-30 17:19 ` Zev Weiss
2021-03-30 17:42 ` Mark Brown
2021-03-30 17:56 ` Zev Weiss
2021-03-30 18:02 ` Mark Brown
2021-03-30 19:38 ` Guenter Roeck
2021-04-20 1:29 ` Zev Weiss
2021-04-20 3:36 ` Guenter Roeck
2021-04-20 5:50 ` Zev Weiss
2021-04-20 6:00 ` Guenter Roeck [this message]
2021-04-20 7:06 ` Zev Weiss
2021-04-20 10:52 ` Guenter Roeck
2021-04-20 15:19 ` Zev Weiss
2021-04-20 16:13 ` Mark Brown
2021-04-20 16:40 ` Zev Weiss
2021-04-20 17:15 ` Mark Brown
2021-04-20 18:54 ` Zev Weiss
2021-04-21 11:05 ` Mark Brown
2021-04-21 18:29 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9639fa33-01ca-9802-e745-5e3edb81e305@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@aj.id.au \
--cc=broonie@kernel.org \
--cc=jdelvare@suse.com \
--cc=lgirdwood@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).