Hi Ed,

=C2=A0 =C2=A0 Please find my res= ponse below.

=C2=A0 =C2=A0 Please search this mail thread "E= EPROM Validation issue in Fru Device " for more information.

Th= anks,

Kumar.

<= div dir=3D"ltr" class=3D"gmail_attr">On Thu, Nov 25, 2021 at 2:10 AM Ed Tan= ous <edtanous@google.com> = wrote:

On Wed, N= ov 24, 2021 at 1:17 AM Kumar Thangavel
<kumar= thangavel.hcl@gmail.com> wrote:
>
> Hi All,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 We would like to validate our NIC FRU devic= e type as 8 bit (one byte) or 16 bit(two byte).
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 This device type validation for our FRU is = platform specific logic.

Please include more details about what this logic is.=C2=A0 In the
entity-manager design, anything that's truly platform specific needs to go into the entity-manager configuration, as all other components
are common.

The existing logic to get the device type is 8bit or = 16bit is not working exactly for our platform.

Also, writing some= bytes and getting device type in eeprom is not safe and not suggested.
= So, we implemented the platform specific logic=C2=A0to get the eeprom devic= e type in the machine layer.

https://github.com/openbmc/entity-manager/blo= b/master/src/FruDevice.cpp#L430

>=C2=A0 This was implemented in the machine layer.

Can you point to it?=C2=A0

The logic is, get the NIC card vendor info from ncsi-= netlink command and based on NIC vendor,

set the eeprom device ty= pe as 8bit or 16 bit.=C2=A0

We wanted to interlink= this logic in entity-manager.

>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 We wanted to interlink this logic with enti= ty-manager code to get the device type.
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 Could you please provide the suggestions on= get the device type in entity-manager.

Entity-manager provides the exposes records on dbus, for which
reactors can pick them up and use them.

Is there a= ny way to get the dynamic values (device type - 8bit/16bit ) from the machi= ne layer=C2=A0

to the entity-manager ?

>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 Please refer below link for existing device= bit validation in entity-manager.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 https://github.com/openbmc/entity-manager/blob/master/src/FruDevice= .cpp#L430

I'm not quite following what this has to do with your above, given
that this isn't intended to be platform specific.

This existing logic to get the device = type 8/16 bit may not work for all the devices.

We need to find c= ommon logic for all the devices without any breakage. But it is very tricky= .

Alternatively, platform specific logic can be an= option and interlink with EM at run time.=C2=A0

We are trying th= is and requesting suggestions from MAINTAINERS.

>
> Thanks,
> Kumar.