From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 309D2C433EF for ; Thu, 21 Oct 2021 06:49:37 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3C646135A for ; Thu, 21 Oct 2021 06:49:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A3C646135A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HZdPq1pFcz3cCS for ; Thu, 21 Oct 2021 17:49:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=NkQbrePi; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::835; helo=mail-qt1-x835.google.com; envelope-from=joel.stan@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=NkQbrePi; dkim-atps=neutral Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HZdP43ZWpz3c95; Thu, 21 Oct 2021 17:48:55 +1100 (AEDT) Received: by mail-qt1-x835.google.com with SMTP id v17so5275045qtp.1; Wed, 20 Oct 2021 23:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mNvxWtckYIaJV931ioym14Q5jqNR1mKAgWlKsIbIzrY=; b=NkQbrePiO+dBHQ9EvaNmEDupYsux/mvqQMa1GaCYmiycTjQJXAT1gAMc7VxaUVMeIl xFKQN3r3sN/FQycbzp2XPHz1vjhUy5BBfP1pZvOrpvgMRtVPz8RTH9cFoG+CHJVB5RyG XhxYmTcdIG7/Rt8AEgJrTlJTpgBAfwaL4kFII= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mNvxWtckYIaJV931ioym14Q5jqNR1mKAgWlKsIbIzrY=; b=7IV5pREIAsnGhdEsnGMoLe1mqVwhDWDgfMvyQnXZnjUkFOlg2RAbSxe1o1a0GF9xCw mtno4/Qc0idCU2BOXJLTqbw+IzpMMzJnFMkO4NmyLYZ85SGMxTQODOweVv9sAf+QKfx6 uf+g7KVy4YoCMYV0gW9T9uCvr14GpRlTiIbXVJNuCesiZld36OUP8kjFN7DBSFT8qWbJ cSqqkTijDJ+At8M8eHEjrZucFrYuweDBBG2Z6HaP1PNRzRfu6txNhK7W1qklIDlr+Iv+ eovHHCX7M0UECJrdqQd7dn//5yXfwSdKqKQVU6q2ExSt7aGZuZPlf1uGs7ST9BJc2o+z FsCw== X-Gm-Message-State: AOAM532J0rCRBrtRIW7iMt+5agDtdA+QPnxdVmC9zKGRIeLjdUwVVfp8 hya073nCTe11NvXCO5XpC8osk2xBS9ZHVBf5fpI= X-Google-Smtp-Source: ABdhPJzBXdMJj7nI0BKVHrtJsFRFYsv4NGS3cg0KW3U1+iTkclWXcGjaJNsdvv35wBUBca9PfSTZTpnV25AliumF8xI= X-Received: by 2002:a05:622a:1006:: with SMTP id d6mr3975310qte.259.1634798932006; Wed, 20 Oct 2021 23:48:52 -0700 (PDT) MIME-Version: 1.0 References: <20210927023053.6728-1-chiawei_wang@aspeedtech.com> <20210927023053.6728-2-chiawei_wang@aspeedtech.com> In-Reply-To: From: Joel Stanley Date: Thu, 21 Oct 2021 06:48:40 +0000 Message-ID: Subject: Re: [PATCH v7 1/5] ARM: dts: aspeed: Drop reg-io-width from LPC nodes To: ChiaWei Wang Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-aspeed , Andrew Jeffery , OpenBMC Maillist , Linux Kernel Mailing List , Rob Herring , Oskar Senft , Linux ARM Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, 21 Oct 2021 at 06:37, ChiaWei Wang wrote: > > > From: Joel Stanley > > Sent: Thursday, October 21, 2021 2:29 PM > > > > On Fri, 8 Oct 2021 at 04:35, Joel Stanley wrote: > > > > > > On Mon, 27 Sept 2021 at 02:31, Chia-Wei Wang > > > wrote: > > > > > > > > The 'reg-io-width' properties are not used by LPC drivers nor > > > > documented as part of bindings. Therefore drop them. > > > > > > I assume they are there due to the lpc having a 'syscon' compatible. > > > THey are documented in the syscon bindings: > > > > > > Documentation/devicetree/bindings/mfd/syscon.yaml > > > > > > Andrew, do you have any comments? > > > > Andrew indicated to me that he agreed with my observation: the properties > > should be present as they are used by the regmap/syscon. > > Thanks. Shall we just drop this one and move on with the rest patches? > However, like Rob mentioned, when doing 'make dtbs_check', there is a warning: > > /builds/robherring/linux-dt-review/arch/arm/boot/dts/aspeed-ast2500-evb.dt.yaml: > lpc@1e789000: 'ibt@140', 'kcs@114', 'kcs@24', 'kcs@28', 'kcs@2c', 'lhc@a0', 'reg-io-width' do not match any of the regexes: > '^lpc-ctrl@[0-9a-f]+$', '^lpc-snoop@[0-9a-f]+$', '^reset-controller@[0-9a-f]+$', 'pinctrl-[0-9]+' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/aspeed-lpc.yaml > > As part of this series has been applied, maybe we can fix this later? Yes, that's a good idea. I will send a pull request with your driver to the soc maintainers. Cheers, Joel > > Regards, > Chiawei > > > > > > > > > > > > > > This is in preparation to move aspeed-lpc.txt to YAML schema. > > > > > > > > Signed-off-by: Chia-Wei Wang > > > > --- > > > > arch/arm/boot/dts/aspeed-g4.dtsi | 1 - > > > > arch/arm/boot/dts/aspeed-g5.dtsi | 1 - > > > > arch/arm/boot/dts/aspeed-g6.dtsi | 1 - > > > > 3 files changed, 3 deletions(-) > > > > > > > > diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi > > > > b/arch/arm/boot/dts/aspeed-g4.dtsi > > > > index c5aeb3cf3a09..45a25eb4baa4 100644 > > > > --- a/arch/arm/boot/dts/aspeed-g4.dtsi > > > > +++ b/arch/arm/boot/dts/aspeed-g4.dtsi > > > > @@ -345,7 +345,6 @@ > > > > lpc: lpc@1e789000 { > > > > compatible = > > "aspeed,ast2400-lpc-v2", "simple-mfd", "syscon"; > > > > reg = <0x1e789000 0x1000>; > > > > - reg-io-width = <4>; > > > > > > > > #address-cells = <1>; > > > > #size-cells = <1>; diff --git > > > > a/arch/arm/boot/dts/aspeed-g5.dtsi > > > > b/arch/arm/boot/dts/aspeed-g5.dtsi > > > > index 73ca1ec6fc24..8e1d00d8445e 100644 > > > > --- a/arch/arm/boot/dts/aspeed-g5.dtsi > > > > +++ b/arch/arm/boot/dts/aspeed-g5.dtsi > > > > @@ -436,7 +436,6 @@ > > > > lpc: lpc@1e789000 { > > > > compatible = > > "aspeed,ast2500-lpc-v2", "simple-mfd", "syscon"; > > > > reg = <0x1e789000 0x1000>; > > > > - reg-io-width = <4>; > > > > > > > > #address-cells = <1>; > > > > #size-cells = <1>; diff --git > > > > a/arch/arm/boot/dts/aspeed-g6.dtsi > > > > b/arch/arm/boot/dts/aspeed-g6.dtsi > > > > index 1b47be1704f8..0d1aae6887cd 100644 > > > > --- a/arch/arm/boot/dts/aspeed-g6.dtsi > > > > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi > > > > @@ -490,7 +490,6 @@ > > > > lpc: lpc@1e789000 { > > > > compatible = > > "aspeed,ast2600-lpc-v2", "simple-mfd", "syscon"; > > > > reg = <0x1e789000 0x1000>; > > > > - reg-io-width = <4>; > > > > > > > > #address-cells = <1>; > > > > #size-cells = <1>; > > > > -- > > > > 2.17.1 > > > >