From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.lore.kernel.org (Postfix) with ESMTPS id 8F106C43334
	for <openbmc@archiver.kernel.org>; Wed,  6 Jul 2022 01:03:21 +0000 (UTC)
Received: from boromir.ozlabs.org (localhost [IPv6:::1])
	by lists.ozlabs.org (Postfix) with ESMTP id 4Ld1WC5qsyz3c0g
	for <openbmc@archiver.kernel.org>; Wed,  6 Jul 2022 11:03:19 +1000 (AEST)
Authentication-Results: lists.ozlabs.org;
	dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=aKjQP74w;
	dkim-atps=neutral
Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2a00:1450:4864:20::32c; helo=mail-wm1-x32c.google.com; envelope-from=joel.stan@gmail.com; receiver=<UNKNOWN>)
Authentication-Results: lists.ozlabs.org;
	dkim=pass (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=aKjQP74w;
	dkim-atps=neutral
Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by lists.ozlabs.org (Postfix) with ESMTPS id 4Ld1VR5ZmBz2yMk
	for <openbmc@lists.ozlabs.org>; Wed,  6 Jul 2022 11:02:39 +1000 (AEST)
Received: by mail-wm1-x32c.google.com with SMTP id j7so7976650wmp.2
        for <openbmc@lists.ozlabs.org>; Tue, 05 Jul 2022 18:02:39 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=jms.id.au; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=3ymvhyiJVhxnULa/V3RfIbd3Sj/K0ZxVUOOb+hjWBfA=;
        b=aKjQP74w606nhmA/QN0lJDzveUdwCvdoNsFK4+I1+IMpPdaE1udf3JMg620lYiPTc2
         h5LFJ6cAD6VS0VY0NWETdsQBbxQOghHzUjt1uMK8UoRpJ+B7Q8bdeGFDCPEvH6qOcUd2
         hHzPLUYWozMPCgGRrirva+mwwg3yEKQQEqETw=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=3ymvhyiJVhxnULa/V3RfIbd3Sj/K0ZxVUOOb+hjWBfA=;
        b=etHUyrPKwZ+rjuRASvcRS/hfpA6vv6rh5Ebu7JA/AnilW4R8re7tsY3bYMZs9QaF+9
         aMB8yVulC+6qb1oTtqozLl9WilOKHbb8hC//dsPoTaHa4NNcxRdA5zMleZuHq5JeFKMh
         Vh1dpO4fBNmSGWlAvjOVok+Rg3UH61vDhL6jIoRN7oyeKJGpJRjkSzvAlcx0ZIRuWALl
         a2I2ijx5j38iQYutoq6TVasbYeT19VzBP9gugwI5xrHUmyWItpiHmibh1b8RVxs57VVy
         hWcBJv5NLz6Qvt3H2PAf1NCGfAXkXKWdRZevZ7S8UQO/MV8iax4s7ShF98fJHvMyNyur
         xiig==
X-Gm-Message-State: AJIora8klzykjlvSxHb4DZ6Pz8LQ0ZraqhM3WAM9EkvkYb1I5oe5Le46
	w5jwLz9lbrCpGqmrnrV31quO6rx1cXCMHA6wN274wEsY
X-Google-Smtp-Source: AGRyM1ueqyfhoa942JO9QeouXB70fK5eDzTEn1ocDcOHKODreVRTGAtVIlL5HW4G3Suj6lPtYePGAdem4f8krYSAD6E=
X-Received: by 2002:a05:600c:2315:b0:3a1:772e:b9a6 with SMTP id
 21-20020a05600c231500b003a1772eb9a6mr36070154wmo.34.1657069355465; Tue, 05
 Jul 2022 18:02:35 -0700 (PDT)
MIME-Version: 1.0
References: <20220630200227.2292079-1-quic_jaehyoo@quicinc.com>
 <20220630200227.2292079-2-quic_jaehyoo@quicinc.com> <CACPK8XcJPs5vcs_+r=hmRX475CzfLo+LdofdAtrpoE5bnEbchg@mail.gmail.com>
 <8bbe2c65-e928-c40d-3ab1-9cbf41b5c3d8@quicinc.com>
In-Reply-To: <8bbe2c65-e928-c40d-3ab1-9cbf41b5c3d8@quicinc.com>
From: Joel Stanley <joel@jms.id.au>
Date: Wed, 6 Jul 2022 01:02:23 +0000
Message-ID: <CACPK8XcM578K41_3FHaFKTnq07pUowORjiW7_8gR=JW1NuzUcA@mail.gmail.com>
Subject: Re: [PATCH u-boot v2019.04-aspeed-openbmc 1/3] configs: ast2600: add
 Qualcomm DC-SCM V1 defconfig
To: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: openbmc@lists.ozlabs.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Development list for OpenBMC <openbmc.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/openbmc>,
 <mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/openbmc/>
List-Post: <mailto:openbmc@lists.ozlabs.org>
List-Help: <mailto:openbmc-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/openbmc>,
 <mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>, Graeme Gregory <quic_ggregory@quicinc.com>, =?UTF-8?Q?C=C3=A9dric_Le_Goater?= <clg@kaod.org>, Jamie Iles <quic_jiles@quicinc.com>
Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org
Sender: "openbmc" <openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org>

On Tue, 5 Jul 2022 at 14:18, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote:
>
> Hello Joel,
>
> On 7/4/2022 11:47 PM, Joel Stanley wrote:
> > On Thu, 30 Jun 2022 at 20:02, Jae Hyun Yoo <quic_jaehyoo@quicinc.com> wrote:
> >>
> >> Add Qualcomm DC-SCM V1 defconfig which is equipped with AST2600.
> >
> > In your commit message you need to justify why your board needs its
> > own defconfig.
> >
> > Preferably we would use a generic openbmc defconfig and you select the
> > device tree for your board at build time.
>
> I expected 'ast2600_openbmc_defconfig' could be used for my non-spl
> u-boot but currently the file has been modified for SPL boot too so both
> 'ast2600_openbmc_defconfig' and 'ast2600_openbmc_spl_defconfig' have SPL
> boot configs. Since the 'ast2600_openbmc_defconfig' is being used for
> other machines, I can't change the file directly for non-spl defconfig
> so it's the reason why I'm trying to upstream this machine specific
> defconfig.

Okay. That's suspicious, if there's a requirement to have non-SPL then
we should revert the change that added SPL to the non-SPL config.

Alternatively, could you use the SPL configuration for your board?
This would simplify testing, as we would only need to verify that the
SPL build works for the 2600 when making u-boot changes.

>
> Should I use a patch file in 'openbmc/meta-qualcomm/recipe-bsp' to
> modify the 'ast2600_openbmc_defconfig' at build time instead?

That's an option, but this would limit testing coverage, as we would
only build that configuration when doing an OpenBMC image build.

>
> Thanks,
> Jae
>
> >>
> >> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com>
> >> ---
> >>   configs/ast2600_qcom_dc_scm_v1_defconfig | 117 +++++++++++++++++++++++
> >>   1 file changed, 117 insertions(+)
> >>   create mode 100644 configs/ast2600_qcom_dc_scm_v1_defconfig
> >>
> >> diff --git a/configs/ast2600_qcom_dc_scm_v1_defconfig b/configs/ast2600_qcom_dc_scm_v1_defconfig
> >> new file mode 100644
> >> index 000000000000..353882deed26
> >> --- /dev/null
> >> +++ b/configs/ast2600_qcom_dc_scm_v1_defconfig
> >> @@ -0,0 +1,117 @@
> >> +CONFIG_ARM=y
> >> +CONFIG_SYS_DCACHE_OFF=y
> >> +CONFIG_ARCH_ASPEED=y
> >> +CONFIG_SYS_TEXT_BASE=0x0
> >> +CONFIG_ASPEED_AST2600=y
> >> +CONFIG_TARGET_AST2600_QUALCOMM_DC_SCM_V1=y
> >> +CONFIG_SYS_MALLOC_F_LEN=0x800
> >> +CONFIG_ENV_SIZE=0x10000
> >> +CONFIG_ENV_OFFSET=0xE0000
> >> +CONFIG_ARMV7_BOOT_SEC_DEFAULT=y
> >> +CONFIG_NR_DRAM_BANKS=1
> >> +CONFIG_FIT=y
> >> +CONFIG_USE_BOOTARGS=y
> >> +CONFIG_BOOTARGS="console=ttyS4,115200n8 root=/dev/ram rw"
> >> +CONFIG_USE_BOOTCOMMAND=y
> >> +CONFIG_BOOTCOMMAND="bootm 20100000"
> >> +CONFIG_SYS_CONSOLE_ENV_OVERWRITE=y
> >> +CONFIG_BOARD_LATE_INIT=y
> >> +CONFIG_DISPLAY_BOARDINFO_LATE=y
> >> +CONFIG_ARCH_EARLY_INIT_R=y
> >> +CONFIG_BOARD_EARLY_INIT_F=y
> >> +CONFIG_HUSH_PARSER=y
> >> +# CONFIG_AUTO_COMPLETE is not set
> >> +CONFIG_SYS_PROMPT="ast# "
> >> +CONFIG_CMD_BOOTZ=y
> >> +# CONFIG_CMD_BOOTEFI is not set
> >> +# CONFIG_CMD_ELF is not set
> >> +# CONFIG_CMD_IMI is not set
> >> +# CONFIG_CMD_XIMG is not set
> >> +# CONFIG_CMD_NVEDIT_EFI is not set
> >> +CONFIG_CMD_CRC32=y
> >> +CONFIG_CRC32_VERIFY=y
> >> +# CONFIG_LOOPW is not set
> >> +CONFIG_CMD_MD5SUM=y
> >> +CONFIG_MD5SUM_VERIFY=y
> >> +CONFIG_CMD_MEMINFO=y
> >> +CONFIG_CMD_MEMORY=y
> >> +CONFIG_CMD_MEMTEST=y
> >> +CONFIG_SYS_ALT_MEMTEST=y
> >> +CONFIG_CMD_MX_CYCLIC=y
> >> +CONFIG_CMD_SHA1SUM=y
> >> +CONFIG_SHA1SUM_VERIFY=y
> >> +CONFIG_CMD_STRINGS=y
> >> +CONFIG_CMD_CLK=y
> >> +CONFIG_CMD_GPIO=y
> >> +CONFIG_CMD_I2C=y
> >> +CONFIG_CMD_MMC=y
> >> +CONFIG_CMD_PART=y
> >> +CONFIG_CMD_PCI=y
> >> +CONFIG_CMD_SF=y
> >> +CONFIG_CMD_USB=y
> >> +CONFIG_CMD_DHCP=y
> >> +CONFIG_CMD_MII=y
> >> +CONFIG_CMD_PING=y
> >> +CONFIG_CMD_NCSI=y
> >> +CONFIG_CMD_EXT2=y
> >> +CONFIG_CMD_EXT4=y
> >> +CONFIG_CMD_EXT4_WRITE=y
> >> +CONFIG_CMD_FAT=y
> >> +CONFIG_CMD_FS_GENERIC=y
> >> +CONFIG_CMD_MTDPARTS=y
> >> +CONFIG_EFI_PARTITION=y
> >> +CONFIG_ENV_IS_IN_SPI_FLASH=y
> >> +CONFIG_USE_ENV_SPI_BUS=y
> >> +CONFIG_ENV_SPI_BUS=0
> >> +CONFIG_USE_ENV_SPI_CS=y
> >> +CONFIG_ENV_SPI_CS=0
> >> +CONFIG_USE_ENV_SPI_MAX_HZ=y
> >> +CONFIG_ENV_SPI_MAX_HZ=100000000
> >> +CONFIG_NET_RANDOM_ETHADDR=y
> >> +CONFIG_REGMAP=y
> >> +CONFIG_SYSCON=y
> >> +CONFIG_CLK=y
> >> +CONFIG_DM_GPIO=y
> >> +CONFIG_ASPEED_GPIO=y
> >> +CONFIG_DM_I2C=y
> >> +CONFIG_SYS_I2C_ASPEED=y
> >> +CONFIG_MISC=y
> >> +CONFIG_ASPEED_AHBC=y
> >> +CONFIG_ASPEED_H2X=y
> >> +CONFIG_DM_MMC=y
> >> +CONFIG_MMC_SDHCI=y
> >> +CONFIG_MMC_SDHCI_ASPEED=y
> >> +CONFIG_DM_SPI_FLASH=y
> >> +CONFIG_SPI_FLASH=y
> >> +CONFIG_SPI_FLASH_GIGADEVICE=y
> >> +CONFIG_SPI_FLASH_MACRONIX=y
> >> +CONFIG_SPI_FLASH_SPANSION=y
> >> +CONFIG_SPI_FLASH_STMICRO=y
> >> +CONFIG_SPI_FLASH_WINBOND=y
> >> +CONFIG_PHY_BROADCOM=y
> >> +CONFIG_PHY_MICREL=y
> >> +CONFIG_PHY_MICREL_KSZ90X1=y
> >> +CONFIG_PHY_REALTEK=y
> >> +CONFIG_PHY_NCSI=y
> >> +CONFIG_DM_ETH=y
> >> +CONFIG_PHY_GIGE=y
> >> +CONFIG_FTGMAC100=y
> >> +CONFIG_MDIO=y
> >> +CONFIG_PCI=y
> >> +CONFIG_DM_PCI=y
> >> +CONFIG_PCIE_ASPEED=y
> >> +CONFIG_PHY=y
> >> +CONFIG_PINCTRL=y
> >> +CONFIG_RAM=y
> >> +CONFIG_DM_SERIAL=y
> >> +CONFIG_SYS_NS16550=y
> >> +CONFIG_SPI=y
> >> +CONFIG_DM_SPI=y
> >> +CONFIG_SYSRESET=y
> >> +CONFIG_USB=y
> >> +CONFIG_DM_USB=y
> >> +CONFIG_USB_EHCI_HCD=y
> >> +CONFIG_USB_STORAGE=y
> >> +CONFIG_WDT=y
> >> +CONFIG_HEXDUMP=y
> >> +# CONFIG_GENERATE_SMBIOS_TABLE is not set
> >> --
> >> 2.25.1
> >>