From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2390C388F7 for ; Wed, 28 Oct 2020 04:31:28 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 502BD2087E for ; Wed, 28 Oct 2020 04:31:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=jms.id.au header.i=@jms.id.au header.b="AWk2tSUb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 502BD2087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CLbHf1nzbzDqH4 for ; Wed, 28 Oct 2020 15:31:26 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::841; helo=mail-qt1-x841.google.com; envelope-from=joel.stan@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=AWk2tSUb; dkim-atps=neutral Received: from mail-qt1-x841.google.com (mail-qt1-x841.google.com [IPv6:2607:f8b0:4864:20::841]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CLbFH5ZZkzDqNs for ; Wed, 28 Oct 2020 15:29:23 +1100 (AEDT) Received: by mail-qt1-x841.google.com with SMTP id m9so2734535qth.7 for ; Tue, 27 Oct 2020 21:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZfPWE7faUqLcGTG6SU4g9kITznfqE6uphsD64EkHlO8=; b=AWk2tSUbrhz9AcWONIeuX85lqJ9DHLGLA/ooe9nIRXk5SErAfHjNPV2bm8WozryNif Z3L72GIqG/lO4GbofNUbnYL2Yb0xrFre/WbkbIZ3fTgWP/dPHAyInQwPQeG7BvoHFSPY QHS81HPc08WAKbmG/gC/AEiDNXs/pGf4V0HAs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZfPWE7faUqLcGTG6SU4g9kITznfqE6uphsD64EkHlO8=; b=KHR+/CgUV+XB0LSr2D86qeqKt5VB5acjR6ZtC7o+vNZx3WzVaULG4HBNxLykOrZaoe xxS/f3E4DP5SECbGYRolMLsYsL3w1TMrdGRYJSasUOTI8vTZsYaIjGHdcTABJnViHIC5 gYkk4PUfLSABMeU6ul2KPqABgqI+lBfoqBo2iQQw698KLrQK4gJqTj9/WFXZR0VoOP3e AX2LRqEjJNxTuUoi05DH43KBHUQEwCVuwjNdFUg3ZhpwHOtrMqdiLPFwlyoYmL+kk9Yh s6KV3pNjyNbG9v2V0DqvGIlXGeZfjCJ8q1uUUPkUWp532tnwdEBYvZggcdCjuhvgBrOX +5Gg== X-Gm-Message-State: AOAM532DzJ4ZbdHYBxXxr/oPhu9z/W1hXHp3i/VN502cCaZuXhxMmsYr U366PpE/4J37zNs22e4EfBb/4U3Gd/MyCNjZ67g= X-Google-Smtp-Source: ABdhPJx0YVubZ5CsM1jvKpaphyr1vpKKSgd8mTjidgQOA6+FDEFMZGkIz2RCij+9koUmjCVfxTD0SUoz+ytxo8visDg= X-Received: by 2002:aed:3325:: with SMTP id u34mr5626312qtd.263.1603859361455; Tue, 27 Oct 2020 21:29:21 -0700 (PDT) MIME-Version: 1.0 References: <20200928202753.58351-1-eajames@linux.ibm.com> <20200928202753.58351-4-eajames@linux.ibm.com> <348a64cf-91a2-8852-d2c4-3f4a37d5569b@linux.ibm.com> In-Reply-To: <348a64cf-91a2-8852-d2c4-3f4a37d5569b@linux.ibm.com> From: Joel Stanley Date: Wed, 28 Oct 2020 04:29:09 +0000 Message-ID: Subject: Re: [PATCH U-Boot v2019.04-aspeed-openbmc 3/3] configs: Add AST2600 SPL eMMC configuration To: Eddie James Content-Type: text/plain; charset="UTF-8" X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: OpenBMC Maillist Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Mon, 12 Oct 2020 at 13:36, Eddie James wrote: > > > On 10/8/20 10:44 PM, Joel Stanley wrote: > > On Mon, 28 Sep 2020 at 20:28, Eddie James wrote: > > > >> diff --git a/include/configs/aspeed-common.h b/include/configs/aspeed-common.h > >> index 4c83035d3c..876958735b 100755 > >> --- a/include/configs/aspeed-common.h > >> +++ b/include/configs/aspeed-common.h > >> @@ -41,6 +41,12 @@ > >> #define CONFIG_SYS_BOOTMAPSZ (256 * 1024 * 1024) > >> #define CONFIG_SYS_MALLOC_LEN (32 << 20) > >> > >> +#ifdef CONFIG_ENV_IS_IN_MMC > >> +#define CONFIG_SYS_MMC_ENV_DEV 0 > >> +#define CONFIG_SYS_MMC_ENV_PART 0 > >> +#define CONFIG_ENV_OFFSET_REDUND 0x15000 > > 84KB? How was this chosen? > > > The env is at 0x5000 in the user partition, and is sized at 0x10000. The > redundant follows it immediately... Can you put that and the information from your other email in the commit message.