From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=SevI=IK=lists.ozlabs.org=openbmc-bounces+openbmc=archiver.kernel.org@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,
	INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id AECD6C4332D
	for <openbmc@archiver.kernel.org>; Fri, 12 Mar 2021 00:24:27 +0000 (UTC)
Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mail.kernel.org (Postfix) with ESMTPS id 32DC964F94
	for <openbmc@archiver.kernel.org>; Fri, 12 Mar 2021 00:24:27 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32DC964F94
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org
Received: from boromir.ozlabs.org (localhost [IPv6:::1])
	by lists.ozlabs.org (Postfix) with ESMTP id 4DxRQK5Xbpz3cVq
	for <openbmc@archiver.kernel.org>; Fri, 12 Mar 2021 11:24:25 +1100 (AEDT)
Authentication-Results: lists.ozlabs.org;
	dkim=pass (1024-bit key; secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256 header.s=google header.b=JLb7Cces;
	dkim-atps=neutral
Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized)
 smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::72c;
 helo=mail-qk1-x72c.google.com; envelope-from=joel.stan@gmail.com;
 receiver=<UNKNOWN>)
Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key;
 secure) header.d=jms.id.au header.i=@jms.id.au header.a=rsa-sha256
 header.s=google header.b=JLb7Cces; dkim-atps=neutral
Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com
 [IPv6:2607:f8b0:4864:20::72c])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.ozlabs.org (Postfix) with ESMTPS id 4DxRPw5DsKz2xZr
 for <openbmc@lists.ozlabs.org>; Fri, 12 Mar 2021 11:24:03 +1100 (AEDT)
Received: by mail-qk1-x72c.google.com with SMTP id n79so22680686qke.3
 for <openbmc@lists.ozlabs.org>; Thu, 11 Mar 2021 16:24:03 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jms.id.au; s=google;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=lm/j+GbCDf4OOHQeboiyUtvHmwjj+FzkBBODE/422vo=;
 b=JLb7CcesTBz4krQTOASeansCLNGPZ4pqU+ulzOAMicphmez2mVZOKKg2Js9x77jMif
 DqPThG/6JjSTRSkQJcfFSiFr17N04qpAz8xQJi3i/2dUJLP2Sx/UKsRTbzKT/tFZUm0I
 TvM6t7qW0CkdIA8dStQohoifwKQJuIlVT5o+s=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=lm/j+GbCDf4OOHQeboiyUtvHmwjj+FzkBBODE/422vo=;
 b=A+PP8EIj0st7cLWEjPih8xTuSsic5CJYucl1OQ6aU7c5ZIGMtbBndF7ws+X5UUuKlV
 velRjMyHqAee8/KthyOea1q1y0UXpOekwjbIHA9lGySpOE7ZapFq3ndc4FzpZtlH0+8e
 ITF/DyFPW1SaZiAmbx4ptIvqB8290ejdMnejIg8VZuFHkqNOBklcfHxDHeR97tdTJH/N
 CB3xc1XT89yFJM7F+Uo7MbDOyGCoudHOmWTY1LliPUtq1LV+t+GUGATvQfoe5AjBSY2H
 o3cSrVOMhtTFJI4CcrG7XIzyr3ZGYFQaeFWpgPHUW54+LhC2q1TUU1N5syXvz6WwgJhV
 c55A==
X-Gm-Message-State: AOAM533uwSIaxuvqekzXw4PC1rfXm3uPCzaSK0mrSC7ZfAhZgk5yGFuh
 Nw8QEU2hTAMrcFhApM+gPxWOFKmKK2WyoMvyqxw=
X-Google-Smtp-Source: ABdhPJzud0cqvpzeJqkccZEFzzniG//8CjGsaTsk88LI/7iWwHQwTZHzAdgD4K4xX27tAabzdbh7NItQdA+Bkl+rvXU=
X-Received: by 2002:a05:620a:c11:: with SMTP id
 l17mr10470866qki.487.1615508641277; 
 Thu, 11 Mar 2021 16:24:01 -0800 (PST)
MIME-Version: 1.0
References: <20210308225419.46530-1-eajames@linux.ibm.com>
 <20210308225419.46530-31-eajames@linux.ibm.com>
In-Reply-To: <20210308225419.46530-31-eajames@linux.ibm.com>
From: Joel Stanley <joel@jms.id.au>
Date: Fri, 12 Mar 2021 00:23:49 +0000
Message-ID: <CACPK8XeDofks4xzismhcA5oJVnxkc2yWwG65fG1X8HH2ajt79A@mail.gmail.com>
Subject: Re: [PATCH linux dev-5.10 30/35] hwmon: (pmbus/ibm-cffps) Set the
 PMBUS_NO_CAPABILITY flag
To: Eddie James <eajames@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: openbmc@lists.ozlabs.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Development list for OpenBMC <openbmc.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/openbmc>,
 <mailto:openbmc-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/openbmc/>
List-Post: <mailto:openbmc@lists.ozlabs.org>
List-Help: <mailto:openbmc-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/openbmc>,
 <mailto:openbmc-request@lists.ozlabs.org?subject=subscribe>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>
Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org
Sender: "openbmc"
 <openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org>

On Mon, 8 Mar 2021 at 22:56, Eddie James <eajames@linux.ibm.com> wrote:
>
> Several power supplies supported by the IBM CFFPS driver don't
> report valid data in the CAPABILITY register. This results in PEC
> being enabled when it's not supported by the device, and since
> the automatic version detection might fail, disable use of the
> CAPABILITY register across the board for this driver.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
> Link: https://lore.kernel.org/r/20201222152640.27749-3-eajames@linux.ibm.com
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

I have applied the commits to this driver that have been made upstream:


f7a652182cc7 hwmon: (pmbus/ibm-cffps) Set the PMBUS_NO_CAPABILITY flag
3bce071a301f hwmon: (pmbus) shrink code and remove pmbus_do_remove()

> ---
>  drivers/hwmon/pmbus/ibm-cffps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/pmbus/ibm-cffps.c b/drivers/hwmon/pmbus/ibm-cffps.c
> index 2fb7540ee952..f7bb7bebe045 100644
> --- a/drivers/hwmon/pmbus/ibm-cffps.c
> +++ b/drivers/hwmon/pmbus/ibm-cffps.c
> @@ -472,7 +472,7 @@ static struct pmbus_driver_info ibm_cffps_info[] = {
>  };
>
>  static struct pmbus_platform_data ibm_cffps_pdata = {
> -       .flags = PMBUS_SKIP_STATUS_CHECK,
> +       .flags = PMBUS_SKIP_STATUS_CHECK | PMBUS_NO_CAPABILITY,
>  };
>
>  static int ibm_cffps_probe(struct i2c_client *client)
> --
> 2.27.0
>