From: Joel Stanley <joel@jms.id.au>
To: Dylan Hung <dylan_hung@aspeedtech.com>
Cc: BMC-SW <BMC-SW@aspeedtech.com>,
Po-Yu Chuang <ratbert@faraday-tech.com>,
linux-aspeed <linux-aspeed@lists.ozlabs.org>,
netdev@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/1] net: ftgmac100: Fix Aspeed ast2600 TX hang issue
Date: Wed, 14 Oct 2020 06:41:21 +0000 [thread overview]
Message-ID: <CACPK8Xe_O44BUaPCEm2j3ZN+d4q6JbjEttLsiCLbWF6GnaqSPg@mail.gmail.com> (raw)
In-Reply-To: <20201014060632.16085-2-dylan_hung@aspeedtech.com>
On Wed, 14 Oct 2020 at 06:07, Dylan Hung <dylan_hung@aspeedtech.com> wrote:
>
> The new HW arbitration feature on Aspeed ast2600 will cause MAC TX to
> hang when handling scatter-gather DMA. Disable the problematic feature
> by setting MAC register 0x58 bit28 and bit27.
Hi Dylan,
What are the symptoms of this issue? We are seeing this on our systems:
[29376.090637] WARNING: CPU: 0 PID: 9 at net/sched/sch_generic.c:442
dev_watchdog+0x2f0/0x2f4
[29376.099898] NETDEV WATCHDOG: eth0 (ftgmac100): transmit queue 0 timed out
> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
This fixes support for the ast2600, so we can put:
Fixes: 39bfab8844a0 ("net: ftgmac100: Add support for DT phy-handle property")
Reviewed-by: Joel Stanley <joel@jms.id.au>
> ---
> drivers/net/ethernet/faraday/ftgmac100.c | 5 +++++
> drivers/net/ethernet/faraday/ftgmac100.h | 8 ++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
> index 87236206366f..00024dd41147 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.c
> +++ b/drivers/net/ethernet/faraday/ftgmac100.c
> @@ -1817,6 +1817,11 @@ static int ftgmac100_probe(struct platform_device *pdev)
> priv->rxdes0_edorr_mask = BIT(30);
> priv->txdes0_edotr_mask = BIT(30);
> priv->is_aspeed = true;
> + /* Disable ast2600 problematic HW arbitration */
> + if (of_device_is_compatible(np, "aspeed,ast2600-mac")) {
> + iowrite32(FTGMAC100_TM_DEFAULT,
> + priv->base + FTGMAC100_OFFSET_TM);
> + }
> } else {
> priv->rxdes0_edorr_mask = BIT(15);
> priv->txdes0_edotr_mask = BIT(15);
> diff --git a/drivers/net/ethernet/faraday/ftgmac100.h b/drivers/net/ethernet/faraday/ftgmac100.h
> index e5876a3fda91..63b3e02fab16 100644
> --- a/drivers/net/ethernet/faraday/ftgmac100.h
> +++ b/drivers/net/ethernet/faraday/ftgmac100.h
> @@ -169,6 +169,14 @@
> #define FTGMAC100_MACCR_FAST_MODE (1 << 19)
> #define FTGMAC100_MACCR_SW_RST (1 << 31)
>
> +/*
> + * test mode control register
> + */
> +#define FTGMAC100_TM_RQ_TX_VALID_DIS (1 << 28)
> +#define FTGMAC100_TM_RQ_RR_IDLE_PREV (1 << 27)
> +#define FTGMAC100_TM_DEFAULT \
> + (FTGMAC100_TM_RQ_TX_VALID_DIS | FTGMAC100_TM_RQ_RR_IDLE_PREV)
Will aspeed issue an updated datasheet with this register documented?
> +
> /*
> * PHY control register
> */
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-10-14 6:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 6:06 [PATCH 0/1] Fix Aspeed ast2600 MAC TX hang Dylan Hung
2020-10-14 6:06 ` [PATCH 1/1] net: ftgmac100: Fix Aspeed ast2600 TX hang issue Dylan Hung
2020-10-14 6:41 ` Joel Stanley [this message]
2020-10-14 7:58 ` Dylan Hung
2020-10-14 22:31 ` Joel Stanley
2020-10-15 1:49 ` Dylan Hung
2020-10-15 2:32 ` Joel Stanley
2020-10-16 22:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8Xe_O44BUaPCEm2j3ZN+d4q6JbjEttLsiCLbWF6GnaqSPg@mail.gmail.com \
--to=joel@jms.id.au \
--cc=BMC-SW@aspeedtech.com \
--cc=davem@davemloft.net \
--cc=dylan_hung@aspeedtech.com \
--cc=kuba@kernel.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=ratbert@faraday-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).