From: Joel Stanley <joel@jms.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH linux dev-4.17 v2 1/2] ARM: dts: aspeed: Add "spi-max-frequency" property
Date: Mon, 25 Jun 2018 13:10:01 +0930 [thread overview]
Message-ID: <CACPK8XenvZXcciV_sY-f4ZEjV+H1UtA1Ef5JYnvr2CKwM3NXtw@mail.gmail.com> (raw)
In-Reply-To: <20180622070937.21498-2-clg@kaod.org>
Hi Cedric,
On 22 June 2018 at 16:39, Cédric Le Goater <clg@kaod.org> wrote:
> Keep the FMC controller chips at a safe 50 MHz rate and use 100 MHz
> for the PNOR on the machines using a AST2500 SoC.
>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
> arch/arm/boot/dts/aspeed-ast2500-evb.dts | 2 ++
> arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 2 ++
> arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 2 ++
> arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 3 +++
> arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts | 2 ++
The changes look good. I notice you've only modified the openpower
platforms and the evb. Is there a reason we don't do this for all of
the ast2500 boards?
$ grep -l ast2500 arch/arm/boot/dts/aspeed-*.dts
arch/arm/boot/dts/aspeed-ast2500-evb.dts
arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts
arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts
arch/arm/boot/dts/aspeed-bmc-opp-lanyang.dts
arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts
Cheers,
Joel
> arch/arm/boot/dts/aspeed-g4.dtsi | 2 ++
> arch/arm/boot/dts/aspeed-g5.dtsi | 7 +++++++
> 7 files changed, 20 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-ast2500-evb.dts b/arch/arm/boot/dts/aspeed-ast2500-evb.dts
> index c0a7f51e7eb6..6b78e40d3259 100644
> --- a/arch/arm/boot/dts/aspeed-ast2500-evb.dts
> +++ b/arch/arm/boot/dts/aspeed-ast2500-evb.dts
> @@ -41,6 +41,7 @@
> status = "okay";
> m25p,fast-read;
> label = "bmc";
> + spi-max-frequency = <50000000>;
> #include "openbmc-flash-layout.dtsi"
> };
> };
> @@ -51,6 +52,7 @@
> status = "okay";
> m25p,fast-read;
> label = "pnor";
> + spi-max-frequency = <100000000>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> index e6095f51ecf5..af41973a3882 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts
> @@ -66,6 +66,7 @@
> status = "okay";
> m25p,fast-read;
> label = "bmc";
> + spi-max-frequency = <50000000>;
> #include "openbmc-flash-layout.dtsi"
> };
> };
> @@ -78,6 +79,7 @@
> flash@0 {
> status = "okay";
> m25p,fast-read;
> + spi-max-frequency = <50000000>;
> label = "pnor";
> };
> };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> index 347938673c83..ffe0c991d985 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> @@ -93,6 +93,7 @@
> status = "okay";
> m25p,fast-read;
> label = "bmc";
> + spi-max-frequency = <50000000>;
> #include "openbmc-flash-layout.dtsi"
> };
> };
> @@ -106,6 +107,7 @@
> status = "okay";
> m25p,fast-read;
> label = "pnor";
> + spi-max-frequency = <100000000>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> index d05ace220a09..c51e3e8ece62 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts
> @@ -190,6 +190,7 @@
> status = "okay";
> label = "bmc";
> m25p,fast-read;
> + spi-max-frequency = <50000000>;
> #include "openbmc-flash-layout.dtsi"
> };
>
> @@ -197,6 +198,7 @@
> status = "okay";
> label = "alt";
> m25p,fast-read;
> + spi-max-frequency = <50000000>;
> };
> };
>
> @@ -209,6 +211,7 @@
> status = "okay";
> label = "pnor";
> m25p,fast-read;
> + spi-max-frequency = <100000000>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> index 80cc7cba163c..757d6b3eb041 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts
> @@ -124,6 +124,7 @@
> status = "okay";
> label = "bmc";
> m25p,fast-read;
> + spi-max-frequency = <50000000>;
> #include "openbmc-flash-layout.dtsi"
> };
> };
> @@ -137,6 +138,7 @@
> status = "okay";
> label = "pnor";
> m25p,fast-read;
> + spi-max-frequency = <100000000>;
> };
> };
>
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index 79257bf415a8..e526f54f400e 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -65,6 +65,7 @@
> flash@0 {
> reg = < 0 >;
> compatible = "jedec,spi-nor";
> + spi-max-frequency = <50000000>;
> status = "disabled";
> };
> };
> @@ -80,6 +81,7 @@
> flash@0 {
> reg = < 0 >;
> compatible = "jedec,spi-nor";
> + spi-max-frequency = <50000000>;
> status = "disabled";
> };
> };
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 9cc50551c42e..afd33112c329 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -65,16 +65,19 @@
> flash@0 {
> reg = < 0 >;
> compatible = "jedec,spi-nor";
> + spi-max-frequency = <50000000>;
> status = "disabled";
> };
> flash@1 {
> reg = < 1 >;
> compatible = "jedec,spi-nor";
> + spi-max-frequency = <50000000>;
> status = "disabled";
> };
> flash@2 {
> reg = < 2 >;
> compatible = "jedec,spi-nor";
> + spi-max-frequency = <50000000>;
> status = "disabled";
> };
> };
> @@ -90,11 +93,13 @@
> flash@0 {
> reg = < 0 >;
> compatible = "jedec,spi-nor";
> + spi-max-frequency = <50000000>;
> status = "disabled";
> };
> flash@1 {
> reg = < 1 >;
> compatible = "jedec,spi-nor";
> + spi-max-frequency = <50000000>;
> status = "disabled";
> };
> };
> @@ -110,11 +115,13 @@
> flash@0 {
> reg = < 0 >;
> compatible = "jedec,spi-nor";
> + spi-max-frequency = <50000000>;
> status = "disabled";
> };
> flash@1 {
> reg = < 1 >;
> compatible = "jedec,spi-nor";
> + spi-max-frequency = <50000000>;
> status = "disabled";
> };
> };
> --
> 2.13.6
>
next prev parent reply other threads:[~2018-06-25 3:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-22 7:09 [PATCH linux dev-4.17 v2 0/2] mtd: spi-nor: aspeed: introduce a "spi-max-frequency" property Cédric Le Goater
2018-06-22 7:09 ` [PATCH linux dev-4.17 v2 1/2] ARM: dts: aspeed: Add " Cédric Le Goater
2018-06-24 23:32 ` Andrew Jeffery
2018-06-25 3:40 ` Joel Stanley [this message]
2018-06-25 4:53 ` Cédric Le Goater
2018-06-25 5:01 ` Joel Stanley
2018-06-25 5:16 ` Cédric Le Goater
2018-06-22 7:09 ` [PATCH linux dev-4.17 v2 2/2] mtd: spi-nor: aspeed: limit the maximum SPI frequency Cédric Le Goater
2018-06-24 23:34 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8XenvZXcciV_sY-f4ZEjV+H1UtA1Ef5JYnvr2CKwM3NXtw@mail.gmail.com \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).