From: Joel Stanley <joel@jms.id.au>
To: Zev Weiss <zev@bewilderbeest.net>
Cc: Andrew Jeffery <andrew@aj.id.au>,
Jammy Huang <jammy_huang@aspeedtech.com>,
openbmc@lists.ozlabs.org, Eddie James <eajames@linux.ibm.com>,
linux-aspeed@lists.ozlabs.org
Subject: Re: Log spam from aspeed-video driver
Date: Wed, 9 Nov 2022 23:54:07 +0000 [thread overview]
Message-ID: <CACPK8XfQhaG2pb6=0YL6J3ME2XLxuQdV37tTuoOX5-05c7pDnQ@mail.gmail.com> (raw)
In-Reply-To: <Y1dX9r9ybGjBrW0k@hatter.bewilderbeest.net>
On Tue, 25 Oct 2022 at 03:29, Zev Weiss <zev@bewilderbeest.net> wrote:
>
> Hi all,
>
> Since the recent update of the OpenBMC kernel to 6.0, I've been seeing a
> lot of new log noise from aspeed-video driver when the host is powered
> off after having been on:
>
> [ 335.526279] aspeed-video 1e700000.video: Timed out; first mode detect
> [ 335.544172] aspeed-video 1e700000.video: No signal; don't start frame
> [ 337.165555] aspeed-video 1e700000.video: Timed out; first mode detect
> [ 337.186214] aspeed-video 1e700000.video: No signal; don't start frame
> [ 338.815501] aspeed-video 1e700000.video: Timed out; first mode detect
> [ 338.834008] aspeed-video 1e700000.video: No signal; don't start frame
>
> It just emits that pair of messages continuously, about every 1.6
> seconds.
Our current generation machines don't use the bmc kvm setup, so this
hasn't seen much testing by IBM.
I'd like to hear from aspeed. If this is a problem with the driver
then it's something to look into. If it's log spam then we should put
it back to a dbg call.
>
> Looking through the commit history of the driver, it looks like that
> stems from commit a3de90afe392 ("media: aspeed: use
> v4l2_info/v4l2_warn/v4l2_dbg for log"), which converted a bunch of print
> calls from dev_dbg() to various v4l2_*() calls. Reverting to the old
> 5.15 kernel (which didn't include that change), I found by enabling the
> dev_dbg() prints via sysfs (and cranking up the console loglevel) that
> the conditions triggering those messages have been happening all along,
> I just hadn't been seeing them because the debug prints were disabled by
> default.
>
> I should note that aside from the dmesg spam I don't see any functional
> problems with the driver; obmc-ikvm works as expected.
>
> Was switching those dev_dbg() calls to v4l2_warn() instead of v4l2_dbg()
> intentional? Does this indicate some latent bug that should be fixed,
> or should they just be converted to v4l2_dbg()?
>
>
> Thanks,
> Zev
>
next prev parent reply other threads:[~2022-11-09 23:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 3:28 Log spam from aspeed-video driver Zev Weiss
2022-11-09 22:48 ` Zev Weiss
2022-11-09 23:54 ` Joel Stanley [this message]
2022-11-10 2:24 ` Jammy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8XfQhaG2pb6=0YL6J3ME2XLxuQdV37tTuoOX5-05c7pDnQ@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=jammy_huang@aspeedtech.com \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=openbmc@lists.ozlabs.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).