From: Linus Walleij <linus.walleij@linaro.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Tomer Maimon <tmaimon77@gmail.com>,
kernel-janitors@vger.kernel.org,
Tali Perry <tali.perry1@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Benjamin Fair <benjaminfair@google.com>,
openbmc@lists.ozlabs.org, Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Sekhar Nori <nsekhar@ti.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Krzysztof Halasa <khalasa@piap.pl>,
linux-arm-kernel@lists.infradead.org,
Avi Fishman <avifishman70@gmail.com>,
Patrick Venture <venture@google.com>,
Linus Walleij <linusw@kernel.org>,
linux-kernel@vger.kernel.org, Dinh Nguyen <dinguyen@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Imre Kaloz <kaloz@openwrt.org>, Shawn Guo <shawnguo@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>
Subject: Re: [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment
Date: Tue, 9 Nov 2021 05:52:13 +0100 [thread overview]
Message-ID: <CACRpkdYm2Da3W63T4KTnFzESNBrgvZGZsVZYqFN_16NGfpWm2w@mail.gmail.com> (raw)
In-Reply-To: <20211028141938.3530-14-lukas.bulwahn@gmail.com>
On Thu, Oct 28, 2021 at 4:20 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
> Commit 5615f69bc209 ("ARM: 9016/2: Initialize the mapping of KASan shadow
> memory") adds some nested ifdef's in ./arch/arm/mm/pgd.c, and follows the
> good practice to annotate the endif's with a comment to indicate the
> corresponding ifdef condition.
>
> One comment annotation refers to CONFIG_LPAE, whereas the config is
> actually called CONFIG_ARM_LPAE. That imprecision in a comment is probably
> tolerable for all human readers.
>
> However, the script ./scripts/checkkconfigsymbols.py, which checks the
> kernel tree for references to non-existing Kconfig symbols, identifies and
> reports that the reference to CONFIG_LPAE is invalid.
>
> The script ./scripts/checkkconfigsymbols.py has been quite useful to
> identify a number of bugs with Kconfig symbols and deserves to be executed
> and checked regularly.
>
> So, repair the comment to reduce the reports from this script and simplify
> to use this script, as new issues are easier to spot when the list of
> reports is shorter.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Please put this patch into Russell's patch tracker!
Yours,
Linus Walleij
prev parent reply other threads:[~2021-11-09 4:53 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 14:19 [PATCH 00/13] Kconfig symbol clean-up on ./arch/arm{64} Lukas Bulwahn
2021-10-28 14:19 ` [PATCH 01/13] arm: debug: remove obsolete debug code for DEBUG_ZTE_ZX Lukas Bulwahn
2021-10-28 14:38 ` Arnd Bergmann
2021-10-29 5:34 ` Lukas Bulwahn
2021-10-29 6:10 ` Arnd Bergmann
2021-10-28 14:19 ` [PATCH 02/13] arm: debug: reuse the config DEBUG_OMAP2UART{1, 2} for OMAP{3, 4, 5} Lukas Bulwahn
2021-10-28 14:39 ` [PATCH 02/13] arm: debug: reuse the config DEBUG_OMAP2UART{1,2} for OMAP{3,4,5} Arnd Bergmann
2021-10-28 14:19 ` [PATCH 03/13] arm: Kconfig.debug: drop reference to removed ARCH_MSM Lukas Bulwahn
2021-10-28 14:42 ` Arnd Bergmann
2021-11-02 7:55 ` Lukas Bulwahn
2021-10-28 14:19 ` [PATCH 04/13] arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 Lukas Bulwahn
2021-10-28 14:46 ` Arnd Bergmann
2021-10-28 15:35 ` Russell King (Oracle)
2021-10-29 5:53 ` Lukas Bulwahn
2021-10-28 14:19 ` [PATCH 05/13] arm: davinci: remove reference to obsolete BLK_DEV_PALMCHIP_BK3710 Lukas Bulwahn
2021-10-28 14:47 ` Arnd Bergmann
2021-10-28 14:19 ` [PATCH 06/13] arm: ixp4xx: remove dead configs CPU_IXP43X and CPU_IXP46X Lukas Bulwahn
2021-10-28 14:47 ` Arnd Bergmann
2021-11-10 8:27 ` Linus Walleij
2021-10-28 14:19 ` [PATCH 07/13] arm: imx: remove dead left-over from i.MX{27, 31, 35} removal Lukas Bulwahn
2021-10-28 14:48 ` Arnd Bergmann
2021-11-21 8:43 ` [PATCH 07/13] arm: imx: remove dead left-over from i.MX{27,31,35} removal Shawn Guo
2021-10-28 14:19 ` [PATCH 08/13] arm: imx: rename DEBUG_IMX21_IMX27_UART to DEBUG_IMX27_UART Lukas Bulwahn
2021-10-28 14:49 ` Arnd Bergmann
2021-11-21 8:47 ` Shawn Guo
2021-10-28 14:19 ` [PATCH 09/13] arm: milbeaut: remove select of non-existing PINCTRL_MILBEAUT Lukas Bulwahn
2021-10-28 14:55 ` Arnd Bergmann
2021-10-28 14:19 ` [PATCH 10/13] arm: nomadik: drop selecting obsolete CLKSRC_NOMADIK_MTU_SCHED_CLOCK Lukas Bulwahn
2021-10-28 14:55 ` Arnd Bergmann
2021-11-10 8:28 ` Linus Walleij
2021-10-28 14:19 ` [PATCH 11/13] arm: npcm: drop selecting non-existing ARM_ERRATA_794072 Lukas Bulwahn
2021-10-28 14:56 ` Arnd Bergmann
2021-10-29 6:36 ` Joel Stanley
2021-11-02 7:31 ` Lukas Bulwahn
2021-11-02 8:10 ` Arnd Bergmann
2021-11-02 12:14 ` Lukas Bulwahn
2021-11-02 8:22 ` Avi Fishman
2021-11-02 8:33 ` Avi Fishman
2021-10-28 14:19 ` [PATCH 12/13] arm: socfpga: always select PL310_ERRATA_753970 Lukas Bulwahn
2021-10-28 14:58 ` Arnd Bergmann
2021-10-28 14:19 ` [PATCH 13/13] arm: pgtable: refer to intended CONFIG_ARM_LPAE in comment Lukas Bulwahn
2021-10-28 14:58 ` Arnd Bergmann
2021-11-09 4:52 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYm2Da3W63T4KTnFzESNBrgvZGZsVZYqFN_16NGfpWm2w@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=arnd@arndb.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=brgl@bgdev.pl \
--cc=dinguyen@kernel.org \
--cc=festevam@gmail.com \
--cc=kaloz@openwrt.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=khalasa@piap.pl \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas.bulwahn@gmail.com \
--cc=nsekhar@ti.com \
--cc=openbmc@lists.ozlabs.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).