openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Jim Liu <jim.t90615@gmail.com>
Cc: KWLIU@nuvoton.com, devicetree@vger.kernel.org, brgl@bgdev.pl,
	JJLIU0@nuvoton.com, linux-kernel@vger.kernel.org,
	linux-gpio@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v5 1/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver
Date: Tue, 14 Mar 2023 19:38:45 +0100	[thread overview]
Message-ID: <CACRpkda5OHxVajMWaw8cxso_Wjnbex+Lx09Xrbr68-b7C3JVZg@mail.gmail.com> (raw)
In-Reply-To: <20230314092311.8924-2-jim.t90615@gmail.com>

Hi Jim,

thanks for your patch!

On Tue, Mar 14, 2023 at 10:23 AM Jim Liu <jim.t90615@gmail.com> wrote:

> Add Nuvoton BMC NPCM7xx/NPCM8xx sgpio driver support.
>
> Signed-off-by: Jim Liu <jim.t90615@gmail.com>

(...)
> +config GPIO_NPCM_SGPIO
> +       bool "Nuvoton SGPIO support"
> +       depends on (ARCH_NPCM || COMPILE_TEST) && OF_GPIO
> +       select GPIO_GENERIC

You don't seem to use GPIO_GENERIC?

> +       gpio->intc.name = dev_name(&pdev->dev);
> +       gpio->intc.irq_ack = npcm_sgpio_irq_ack;
> +       gpio->intc.irq_mask = npcm_sgpio_irq_mask;
> +       gpio->intc.irq_unmask = npcm_sgpio_irq_unmask;
> +       gpio->intc.irq_set_type = npcm_sgpio_set_type;
> +
> +       irq = &gpio->chip.irq;
> +       irq->chip = &gpio->intc;

Please rewrite this dynamic irq_chip to an immutable irq_chip,
several examples of how this is done is in the kernel, for example:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/gpio/gpio-ftgpio010.c?id=ab637d48363d7b8ee67ae089808a8bc6051d53c4

Yours,
Linus Walleij

  parent reply	other threads:[~2023-03-14 18:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14  9:23 [PATCH v5 0/3]Add Nuvoton NPCM SGPIO feature Jim Liu
2023-03-14  9:23 ` [PATCH v5 1/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver Jim Liu
2023-03-14 11:46   ` Paul Menzel
2023-07-24  3:04     ` Jim Liu
2023-07-24 14:44       ` Paul Menzel
2023-07-25  9:12         ` Jim Liu
2023-03-14 18:38   ` Linus Walleij [this message]
2023-03-14  9:23 ` [PATCH v5 2/3] arm: dts: nuvoton: npcm: Add sgpio feature Jim Liu
2023-03-14  9:23 ` [PATCH v5 3/3] dt-bindings: gpio: add NPCM sgpio driver bindings Jim Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkda5OHxVajMWaw8cxso_Wjnbex+Lx09Xrbr68-b7C3JVZg@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=JJLIU0@nuvoton.com \
    --cc=KWLIU@nuvoton.com \
    --cc=brgl@bgdev.pl \
    --cc=devicetree@vger.kernel.org \
    --cc=jim.t90615@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).