openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Ed Tanous <ed@tanous.net>
To: Kumar Thangavel <thangavel.k@hcl.com>
Cc: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
	Vernon Mauery <vernon.mauery@linux.intel.com>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	Patrick Williams <patrickw3@fb.com>,
	James Feist <james.feist@linux.intel.com>,
	"Velumani T-ERS, HCLTech" <velumanit@hcl.com>,
	Vijay Khemka <vijaykhemka@fb.com>
Subject: Re: Read FRU of host through ipmi in Entity manager.
Date: Tue, 22 Sep 2020 13:04:19 -0700	[thread overview]
Message-ID: <CACWQX821UAEHGadwcOoYMDFM-G_JDsipx9cVo96W0L+U21ysEA@mail.gmail.com> (raw)
In-Reply-To: <HK0PR04MB29649824A0F904C61F35152AFD3A0@HK0PR04MB2964.apcprd04.prod.outlook.com>

On Mon, Sep 21, 2020 at 9:44 AM Kumar Thangavel <thangavel.k@hcl.com> wrote:
>
> Classification: HCL Internal
>
> Hi All,
>
>             Thanks for your comments and suggestions.
>
>             As suggested, we are planning to implement a new process/service like  xyz.openbmc_project.IPMB.FruDevice in entity manager module to support Host FRU through ipmb rather than using dbus-sensors/ipmbsensors file.
>
>             Following are the advantages, if host FRU handling in entity manager repo.
>
>             1. All the FRU information is handling in the same repo.

But IPMB information is bifurcated in your plan.  Ideally, Fru-Device
wouldn't even be in the entity-manager repo, it's there now just as an
artifact of the history of how it was built.

>             2. Entity manager Probe can work.

I'm not understanding this;  Entity manager probes can work regardless
of where the code is checked in.

>             3. All the FRU Functions are in the same repo. We can try to reuse most of the functions.

This is a valid point.  Maybe some of the functions need abstracted
out into their own libraries?


>             4. Adding Fru object to dbus handling are done.

I'm not following this point.  Are you saying that code wouldn't need
duplicated?

>             5. All FRU validations are done here like Format fru, update fru property, validate header, Fru AreaLen and checksum. We can try to reuse those validations.

See previous point about "maybe we need a library".

>
>             For scanning the /dev/ipmi-* nodes, we are thinking to use ipmb-channels.json cofig entries in entity manager repo since this config file has valid slave path and bus address.


It should be noted, there's going to need to be significantly more
code added to be able to scan and parse the SDR.  I'm assuming that
code alone will be larger than FruDevice is today.

  parent reply	other threads:[~2020-09-22 20:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 16:55 Read FRU of host through ipmi in Entity manager Kumar Thangavel
2020-09-14 17:25 ` Thomaiyar, Richard Marian
2020-09-14 17:28 ` James Feist
2020-09-14 17:28 ` Ed Tanous
2020-09-15 19:20   ` Vijay Khemka
2020-09-21 16:44     ` Kumar Thangavel
2020-09-21 16:44       ` Kumar Thangavel
2020-09-22 19:57       ` Vijay Khemka
2020-09-22 20:20         ` Ed Tanous
2020-09-22 20:26           ` Vijay Khemka
2020-09-22 20:56             ` Ed Tanous
2020-09-23  5:42               ` Vijay Khemka
2020-09-24 15:12             ` Kumar Thangavel
2020-09-22 20:04       ` Ed Tanous [this message]
2020-09-24 15:12         ` Kumar Thangavel
2020-09-22  7:51     ` Andrei Kartashev
2020-09-22 20:13       ` Ed Tanous

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACWQX821UAEHGadwcOoYMDFM-G_JDsipx9cVo96W0L+U21ysEA@mail.gmail.com \
    --to=ed@tanous.net \
    --cc=jae.hyun.yoo@linux.intel.com \
    --cc=james.feist@linux.intel.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=patrickw3@fb.com \
    --cc=thangavel.k@hcl.com \
    --cc=velumanit@hcl.com \
    --cc=vernon.mauery@linux.intel.com \
    --cc=vijaykhemka@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).