From: Ed Tanous <ed@tanous.net>
To: Naveen Moses S <naveenmoses@fb.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"gmills@linux.vnet.ibm.com" <gmills@linux.vnet.ibm.com>,
"jason.m.bills@linux.intel.com" <jason.m.bills@linux.intel.com>
Subject: Re: Bmcweb redfish multiple host support
Date: Thu, 1 Jul 2021 09:28:30 -0700 [thread overview]
Message-ID: <CACWQX82x5OPNu8SSbP1dK5=3rNRo0tqJYN2eW61qDurTOFFkgA@mail.gmail.com> (raw)
In-Reply-To: <B6A810CD-9610-4AFE-8921-EF490734C17D@fb.com>
On Thu, Jul 1, 2021 at 9:10 AM Naveen Moses S <naveenmoses@fb.com> wrote:
>
> Hello All,
>
> I need your suggestion on implementing support for multiple computer systems or hosts under redfish implementation of BMCWEB.
>
> Redfish schema supports multiple computer systems under redfish path "/redfish/v1/Systems/"
>
> Currently in bmcweb redfish core Computer systems path are is configured for as singlehost
>
> The redfish path computer system is given below
> "/redfish/v1/Systems/system”
>
> In case of multiple hosts can we use the following format.
>
> "/redfish/v1/Systems/system1”
> "/redfish/v1/Systems/system2”
> "/redfish/v1/Systems/system3”
> "/redfish/v1/Systems/system4”
>
> these paths should be populated based on the number of available hosts/computer systems
>
> Possible options to identify the host count are as given below:
> 1.pass the OBMC_HOST_INSTANCES as a macro definition to bmcweb
Please don't do this. In general we only use configure options for
things that cannot be dynamically discovered on dbus or via the
mapper, or where different implementations of things exist that meet
the same API (like log service). I don't think multi-host falls into
either of those categories, as it can be seen on dbus.
> 2.Query dbus objects which has individual instance available for each host using object mapper.
This would far and above be my preference, as it's similar to how the
rest of the bmcweb URIs function.
>
> Is there any other alternate way available for identifying host instances at runtime under bmcweb?
>
>
> if we use the above format then can we change the computer system for single host
>
> as given below
>
> "/redfish/v1/Systems/system0”
I would much prefer these are just based on the dbus path names
instead of trying to explicitly pick a name. That keeps bmcweb
consistent with other resources, and systems that only implement a
single host can choose to keep the same odata.id (system) if they
want.
>
> Code reference : https://github.com/openbmc/bmcweb/blob/master/redfish-core/lib/systems.hpp
>
> method : requestRoutesSystemsCollection
>
>
>
> Thanks
Looking forward to seeing the patches. Thanks for looking into this.
-Ed
next prev parent reply other threads:[~2021-07-01 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 16:09 Bmcweb redfish multiple host support Naveen Moses S
2021-07-01 16:28 ` Ed Tanous [this message]
2021-07-07 4:59 ` Naveen Moses S
2021-07-07 15:41 ` Ed Tanous
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACWQX82x5OPNu8SSbP1dK5=3rNRo0tqJYN2eW61qDurTOFFkgA@mail.gmail.com' \
--to=ed@tanous.net \
--cc=gmills@linux.vnet.ibm.com \
--cc=jason.m.bills@linux.intel.com \
--cc=naveenmoses@fb.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).