openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Lei Yu <yulei.sh@bytedance.com>
To: Paul Fertser <fercerpav@gmail.com>
Cc: openbmc <openbmc@lists.ozlabs.org>
Subject: Re: [External] Re: About KVM screenshot
Date: Tue, 14 Sep 2021 09:38:25 +0800	[thread overview]
Message-ID: <CAGm54UG-ufz_3tE_uVj-o8FjrD0c57tbCfBA2_dzY4t5MAOAZw@mail.gmail.com> (raw)
In-Reply-To: <20210913135712.GW23326@home.paul.comp>

On Mon, Sep 13, 2021 at 9:57 PM Paul Fertser <fercerpav@gmail.com> wrote:
>
> Hello,
>
> On Mon, Sep 13, 2021 at 09:47:03PM +0800, Lei Yu wrote:
> > The whole KVM screenshot is implemented by the below pieces:
> > 1. The vncsnapshot[1] is slightly modified for cross-compile, and a
> > bitbake recipe is created for it;
> > 2. A service is created to host the DBus interface to provide the
> > "Trigger" and "Clear" methods for KVM screenshot;
> > 3. OEM redfish actions are implemented to trigger and clear the KVM
> > screenshot, including the download of the picture;
>
> Currently obmc-ikvm gets a steady stream of JPG images, frame by
> frame, from V4L2. Have you considered extending it a bit so that it
> would be capable of simply saving the current frame to disk, without
> any conversion/transformation, just dump an array of bytes to a file?
>
> What would be the advantage of establishing a local VNC session with
> this additional software compared to the straightforward JPG to file
> writing?

Extending obmc-ikvm was my first thought, and when it's discussed in
Discord, @zevweiss mentioned that we could use the existing
vncsnapshot tool instead of writing new code.
And we tried and it worked fine with the limitation mentioned above.

With the obmc-ikvm extension to capture the JPG image, it has to deal
with two cases:
* When there is already a VNC session, it could just save the current
image when a snapshot is requested;
* When there is no VNC session, it has to open the video device and
capture the image.

We think vncsnapshot is much simpler to use in such case.

But I agree that it will be more efficient if we could implement the
feature in obmc-ikvm.

-- 
BRs,
Lei YU

      reply	other threads:[~2021-09-14  1:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 13:47 Lei Yu
2021-09-13 13:57 ` Paul Fertser
2021-09-14  1:38   ` Lei Yu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGm54UG-ufz_3tE_uVj-o8FjrD0c57tbCfBA2_dzY4t5MAOAZw@mail.gmail.com \
    --to=yulei.sh@bytedance.com \
    --cc=fercerpav@gmail.com \
    --cc=openbmc@lists.ozlabs.org \
    --subject='Re: [External] Re: About KVM screenshot' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).