From: Lei Yu <yulei.sh@bytedance.com>
To: Patrick Williams <patrick@stwcx.xyz>
Cc: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
Vernon Mauery <vernon.mauery@linux.intel.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
Ed Tanous <ed@tanous.net>, Amithash Prasad <amithash@fb.com>,
Kumar Thangavel <thangavel.k@hcl.com>,
"Velumani T-ERS, HCLTech" <velumanit@hcl.com>
Subject: Re: [External] Re: EEPROM Validation issue in Fru Device.
Date: Thu, 30 Sep 2021 09:50:18 +0800 [thread overview]
Message-ID: <CAGm54UHTiiTYu6NYO-R-8iNMRUtvr1L2zWkvOt91iNhCBFtoBg@mail.gmail.com> (raw)
In-Reply-To: <YVRSmInJszjpBTsY@heinlein>
On Wed, Sep 29, 2021 at 7:59 PM Patrick Williams <patrick@stwcx.xyz> wrote:
>
> On Wed, Sep 29, 2021 at 05:53:33AM +0000, Kumar Thangavel wrote:
> >
> > 1. How the function isDevice16Bit Validated for 16 bit device ?
>
> My understanding is that Vijay wrote this originally when he wrote the Tiogapass
> port. You should be able to confirm if it works there.
>
> >
> > 2. Is my validation and analysis is correct ?
>
> Other people have complained (on Discord) that this current code doesn't work
> for all eeproms. If you have something that works better and doesn't break
> Tiogapass support, I would expect it to be accepted as a change in fru-device.
We do hit the issue on this. The FRU in our system is 16-bit and
stored with an offset.
We have internal patches to handle the 16-bit and offset issue, but
the change is tricky and not generic for upstream.
It would be very appreciated to get a generic solution to handle such issues.
--
BRs,
Lei YU
prev parent reply other threads:[~2021-09-30 1:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 5:49 EEPROM Validation issue in Fru Device Kumar Thangavel
2021-09-29 5:53 ` Kumar Thangavel
2021-09-29 11:48 ` Patrick Williams
2021-09-29 13:29 ` Kumar Thangavel
2021-09-30 1:50 ` Lei Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGm54UHTiiTYu6NYO-R-8iNMRUtvr1L2zWkvOt91iNhCBFtoBg@mail.gmail.com \
--to=yulei.sh@bytedance.com \
--cc=amithash@fb.com \
--cc=ed@tanous.net \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=openbmc@lists.ozlabs.org \
--cc=patrick@stwcx.xyz \
--cc=thangavel.k@hcl.com \
--cc=velumanit@hcl.com \
--cc=vernon.mauery@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).