On Fri, Mar 17, 20= 23 at 10:54=E2=80=AFPM C=C3=A9dric Le Goater <clg@kaod.org> wrote:

On 3/17/23 17:06, Alex Benn=C3=A9e wrote:
>
> Abhishek Singh Dagur <abhishek@drut.io> writes:
>
> (cc aspeed maintainers)
>
>> Hi all,
>>
>> We are using obmc-phosphor-image on an ast2500 board which is tryi= ng to communicate with other devices
>> over serial port /dev/ttyS2.
>> As we are trying to emulate the machine on qemu we need to redirec= t the request to the host machine so
>> that it can handle this request and return appropriately.
>> We tried using QEMU options like -serial ,-chardev but still not t= he
>> concrete way we get to do it.
>
> Yeah I'm afraid its non-obvious, certainly for built in serial por= ts.
> Try something like:
>
>=C2=A0 =C2=A0 ./qemu-system-aarch64 -M ast2500-evb \
>=C2=A0 =C2=A0 =C2=A0 -serial null -serial null -serial chardev:myserial= \
>=C2=A0 =C2=A0 =C2=A0 -chardev file,id=3Dmyserial,path=3Doutput.txt \ >=C2=A0 =C2=A0 =C2=A0 $MORE_OPTIONS
>
> You have to add a -serial for each serial port up to the one you care<= br> > about and then set the chardev for it.
>
> If you where adding a device to the system then you can explicitly set=
> the target chardev for it with something like:
>
>=C2=A0 =C2=A0 -device isa-serial,iobase=3Dnnn,irq=3Dnnn,chardev=3DID >
>> It will be very helpful if you can provide us some guidance on thi= s.
>
> Another quirk for the aspeed boards seems to be the default uart can b= e
> an arbitrary one depending on the board model:
>
> 334:=C2=A0 =C2=A0 aspeed_soc_uart_set_chr(s, amc->uart_default, ser= ial_hd(0));
> 336:=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (uart =3D=3D amc->uart_default) = {
> 1112:=C2=A0 =C2=A0 amc->uart_default =3D ASPEED_DEV_UART5;
> 1407:=C2=A0 =C2=A0 amc->uart_default =3D ASPEED_DEV_UART1;
>
> as a result ASPEED_DEV_UART5 will always be the first serial port
> (serial_hd(0)). I don't know how Linux numbers them but worth bein= g
> aware of.

Yes. UART5 is the general default but it depends on the board definition and the fuji was the first to require an exception. See commit 5d63d0c76c ("hw/arm/aspeed: Allow machine to set UART default")

Then, it became more complex with commit d2b3eaefb4 ("aspeed: Refactor=
UART init for multi-SoC machines"). That's another topic.

Abhishek,

I am afraid, you will need to add a new board to fit what's in the DT.<= br>
Or, here is a little patch adding a machine option to set the default uart.=
It was never merged because it is a bit of hack, give it a try and we
will discuss. Use :

=C2=A0 =C2=A0-M ast2500-evb,uart-default=3Duart2

Thanks,

C.

=C2=A0From 0d0700ae772fa5236914e96af1be5afcf0d4a994 Mon Sep 17 00:00:00 200= 1
From: =3D?UTF-8?q?C=3DC3=3DA9dric=3D20Le=3D20Goater?=3D <clg@kaod.org>
Date: Fri, 17 Mar 2023 18:21:54 +0100
Subject: [PATCH] aspeed: Add a "uart-default" machine option
MIME-Version: 1.0
Content-Type: text/plain; charset=3DUTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: C=C3=A9dric Le Goater <clg@kaod.org>
---
=C2=A0 hw/arm/aspeed.c | 31 +++++++++++++++++++++++++++++--
=C2=A0 1 file changed, 29 insertions(+), 2 deletions(-)

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index 806bb10707..e0335cf167 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -45,6 +45,7 @@ struct AspeedMachineState {
=C2=A0 =C2=A0 =C2=A0 bool mmio_exec;
=C2=A0 =C2=A0 =C2=A0 char *fmc_model;
=C2=A0 =C2=A0 =C2=A0 char *spi_model;
+=C2=A0 =C2=A0 uint32_t uart_default;
=C2=A0 =C2=A0 =C2=A0 uint32_t hw_strap1;
=C2=A0 };

@@ -337,10 +338,11 @@ static void connect_serial_hds_to_uarts(AspeedMachine= State *bmc)
=C2=A0 =C2=A0 =C2=A0 AspeedMachineClass *amc =3D ASPEED_MACHINE_GET_CLASS(b= mc);
=C2=A0 =C2=A0 =C2=A0 AspeedSoCState *s =3D &bmc->soc;
=C2=A0 =C2=A0 =C2=A0 AspeedSoCClass *sc =3D ASPEED_SOC_GET_CLASS(s);
+=C2=A0 =C2=A0 int uart_default =3D bmc->uart_default ? bmc->uart_def= ault : amc->uart_default;

-=C2=A0 =C2=A0 aspeed_soc_uart_set_chr(s, amc->uart_default, serial_hd(0= ));
+=C2=A0 =C2=A0 aspeed_soc_uart_set_chr(s, uart_default, serial_hd(0));
=C2=A0 =C2=A0 =C2=A0 for (int i =3D 1, uart =3D ASPEED_DEV_UART1; i < sc= ->uarts_num; i++, uart++) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (uart =3D=3D amc->uart_default) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 if (uart =3D=3D uart_default) {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 continue;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 aspeed_soc_uart_set_chr(s, uart, serial_= hd(i));
@@ -1145,6 +1147,25 @@ static void aspeed_set_spi_model(Object *obj, const = char *value, Error **errp)
=C2=A0 =C2=A0 =C2=A0 bmc->spi_model =3D g_strdup(value);
=C2=A0 }

+const QEnumLookup UartDefault_lookup =3D {
+=C2=A0 =C2=A0 .array =3D
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 (const char *const[]) {
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [0] =3D "none",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [1] =3D "uart1",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [2] =3D "uart2",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [3] =3D "uart3",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [4] =3D "uart4",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 [5] =3D "uart5",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 },
+=C2=A0 =C2=A0 .size =3D 6
+};
+
+static void aspeed_set_uart_default(Object *obj, int val, Error **err)
+{
+=C2=A0 =C2=A0 AspeedMachineState *bmc =3D ASPEED_MACHINE(obj);
+=C2=A0 =C2=A0 bmc->uart_default =3D val + 1;
+}
+
=C2=A0 static void aspeed_machine_class_props_init(ObjectClass *oc)
=C2=A0 {
=C2=A0 =C2=A0 =C2=A0 object_class_property_add_bool(oc, "execute-in-pl= ace",
@@ -1153,6 +1174,12 @@ static void aspeed_machine_class_props_init(ObjectCl= ass *oc)
=C2=A0 =C2=A0 =C2=A0 object_class_property_set_description(oc, "execut= e-in-place",
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"boot directly from CE0 flash device&qu= ot;);

+=C2=A0 =C2=A0 object_class_property_add_enum(oc, "uart-default",= "UartDefault",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&UartDefault_lookup= , NULL,
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0aspeed_set_uart_default= );
+=C2=A0 =C2=A0 object_class_property_set_description(oc, "uart-default= ",
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0"Change the default UART of the board");<= br> +
=C2=A0 =C2=A0 =C2=A0 object_class_property_add_str(oc, "fmc-model"= ;, aspeed_get_fmc_model,
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0aspeed_set_fmc_m= odel);
=C2=A0 =C2=A0 =C2=A0 object_class_property_set_description(oc, "fmc-mo= del",
--
2.39.2