Re: Add firmware implementation in pldm

From: Deepak Kodihalli <deepak.kodihalli.83@gmail.com>
To: Kumar Thangavel <thangavel.k@hcl.com>,
	richard.marian.thomaiyar@linux.intel.com, sumanth.bhat@intel.com
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"Velumani T-ERS, HCLTech" <velumanit@hcl.com>,
	Patrick Williams <patrickw3@fb.com>
Subject: Re: Add firmware implementation in pldm
Date: Wed, 9 Dec 2020 21:47:10 +0530	[thread overview]
Message-ID: <CAM=TmwX79oj-KZ2mj1ENGcGnq37TCo-KijWENU3_3mWC2AtdAw@mail.gmail.com> (raw)
In-Reply-To: <HK0PR04MB2964D0B4027D7B3AE80A3E9EFDCC0@HK0PR04MB2964.apcprd04.prod.outlook.com>

Hi Kumar,

On Wed, Dec 9, 2020 at 9:20 PM Kumar Thangavel <thangavel.k@hcl.com> wrote:
>
> Classification: Internal
>
> Hi All,
>
>
>
>          We planning to do NIC firmware update for our system pldm base.

Great!

>
>          So, We would like to add implementation support for pldm base firmware update. This should be generic for all to use firmware update for any devices.
>          Do we need to create files “firmwareupdate.cpp/.hpp files” under pldm deamon as generic to handle firmware base pldm commands?

Since there is a PLDM firmware update specification, a generic design
and implementation is a definite possibility.

>          Also, please suggest to repo add the BMC applications to send and recv the command handling.
>
>          Could Please provide your comments/suggestions on this implementation.

Will you be able to update
https://github.com/openbmc/docs/blob/master/designs/pldm-stack.md with
a design section on firmware update? Some of the things I would like
to review via this doc update:
- How does this integrate with the current OpenBMC firmware update
architecture, and also with Redfish update service?
- What will PLDM run on? RBT or MCTP? MCTP over what binding?
- Do you anticipate changes to libmctp?
- How does this fit into the existing https://github.com/openbmc/pldm
design? What new components will you be adding? Will libpldm and pldmd
be impacted, and how?
- The 5.9 Linux Kernel has some APIs for PLDM based firmware update.
Can we use those?
- How do we plan to test this? Is hardware a must? Or are you planning
on mocking a PLDM responder?

I think a quick review of such a design doc will be beneficial before
delving into code. Also, please note - Richard and Sumanth (copied
them) are working on similar stuff as well. So there could be scope
for collaboration and to avoid likely duplicate effort. We do talk
about ongoing PLDM activities in OpenBMC in this meet -
https://github.com/openbmc/openbmc/wiki/OpenBMC-PMCI-WG.

Thanks,
Deepak

>
> Thanks,
>
> Kumar.
>
> ::DISCLAIMER::
> ________________________________
> The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
> ________________________________