Re: [oe] [RESEND][meta-python][PATCH 1/3] meta-python: Add python-pyflame recipe

[Khem Raj <raj.khem@gmail.com>]

On Fri, May 4, 2018 at 12:55 AM Andrew Jeffery <andrew@aj.id.au> wrote:
>
> Hi Anuj,
>
> Thanks for the quick review!
>
> On Fri, 4 May 2018, at 17:20, Anuj Mittal wrote:
> > On 05/04/2018 03:09 PM, Andrew Jeffery wrote:
> > > Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> > > ---
> > >  meta-python/recipes-devtools/python/python-pyflame.inc      | 9 +++++++++
> > >  meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb | 5 +++++
> > >  2 files changed, 14 insertions(+)
> > >  create mode 100644 meta-python/recipes-devtools/python/python-pyflame.inc
> > >  create mode 100644 meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> > >
> > > diff --git a/meta-python/recipes-devtools/python/python-pyflame.inc b/meta-python/recipes-devtools/python/python-pyflame.inc
> > > new file mode 100644
> > > index 000000000000..37ceab888533
> > > --- /dev/null
> > > +++ b/meta-python/recipes-devtools/python/python-pyflame.inc
> > > @@ -0,0 +1,9 @@
> > > +S = "${WORKDIR}/pyflame-${PV}"
> > > +
> > > +LICENSE = "Apache-2.0"
> > > +LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"
> > > +
> > > +DEPENDS = "python"
> > > +
> > > +inherit pkgconfig autotools
> > > +
> > > diff --git a/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> > > new file mode 100644
> > > index 000000000000..c902e121231b
> > > --- /dev/null
> > > +++ b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
> > > @@ -0,0 +1,5 @@
> > > +require python-pyflame.inc
> > > +
> > > +SRC_URI = "https://github.com/uber/pyflame/archive/v${PV}.tar.gz"
> >
> > Archive tarball checksums are known to change. Perhaps you can consider
> > using the release tarball instead?
> >
> > https://github.com/uber/pyflame/releases
>
> What exact URL should I use? I got the URL used in the recipe through the releases page by copying the tar.gz link.

here I think you need to use git fetcher instead of wget fetcher and
point SRCREV = "sha of tag" something like below

SRC_URI = "git://github.com/uber/pyflame"
# v1.6.6
SRCREV = "8a9d8c2acc3b3bb027475b738134f1e6fff14e6c"
S = "${WORKDIR}/git"
UPSTREAM_CHECK_URI = "https://github.com/uber/pyflame/releases"