Request new repo for Audit function

Request new repo for Audit function

[George Liu]

Hi Brad:

We have a requirement to implement an Audit function, I found that
there is a design doc[1], but there is no code to implement it.

Could you create a new repo for Audit function?
eg: phosphor-audit

[1]: https://github.com/openbmc/docs/blob/master/designs/phosphor-audit.md

thx - George Liu

Re: Request new repo for Audit function

[Patrick Williams]

[-- Attachment #1: Type: text/plain, Size: 957 bytes --]

On Fri, Aug 13, 2021 at 08:51:32AM +0800, George Liu wrote:
> Hi Brad:
> 
> We have a requirement to implement an Audit function, I found that
> there is a design doc[1], but there is no code to implement it.
> 
> Could you create a new repo for Audit function?
> eg: phosphor-audit
> 
> [1]: https://github.com/openbmc/docs/blob/master/designs/phosphor-audit.md
> 
> thx - George Liu

George,

Are you planning to implement the design as-is?  It has been quite a while since
this design was proposed and it feels to me like there may be some overlap with
the Redfish logging proposal[1].

With how old this design doc is, I think we should have an update / re-review
of it.  If you are willing to take on this development effort, could you replace
yourself as the "Primary Assignee" and make any necessary updates?

1. https://github.com/openbmc/docs/blob/master/architecture/redfish-logging-in-bmcweb.md


-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Request new repo for Audit function

[George Liu]

On Mon, Aug 16, 2021 at 10:25 PM Patrick Williams <patrick@stwcx.xyz> wrote:
>
> On Fri, Aug 13, 2021 at 08:51:32AM +0800, George Liu wrote:
> > Hi Brad:
> >
> > We have a requirement to implement an Audit function, I found that
> > there is a design doc[1], but there is no code to implement it.
> >
> > Could you create a new repo for Audit function?
> > eg: phosphor-audit
> >
> > [1]: https://github.com/openbmc/docs/blob/master/designs/phosphor-audit.md
> >
> > thx - George Liu
>
> George,
>
> Are you planning to implement the design as-is?  It has been quite a while since
> this design was proposed and it feels to me like there may be some overlap with
> the Redfish logging proposal[1].
>
> With how old this design doc is, I think we should have an update / re-review
> of it.  If you are willing to take on this development effort, could you replace
> yourself as the "Primary Assignee" and make any necessary updates?
>
> 1. https://github.com/openbmc/docs/blob/master/architecture/redfish-logging-in-bmcweb.md
>

Thanks Patrick.
Yeah, I will update this design and re-review it.

>
> --
> Patrick Williams

Re: Request new repo for Audit function

[George Liu]

On Fri, Aug 13, 2021 at 4:31 PM Ivan Mikhaylov <i.mikhaylov@yadro.com> wrote:
>
> On Fri, 2021-08-13 at 14:09 +0800, George Liu wrote:
> > On Fri, Aug 13, 2021 at 11:22 AM Milton Miller II <miltonm@us.ibm.com> wrote:
> > >
> > >
> > > Reply below
> > >
> > > -------- Original Message --------
> > > From: George Liu
> > > Date: Thu, August 12, 2021 7:52 PM -0500
> > >
> > >
> > > Hi Brad:
> > >
> > > We have a requirement to implement an Audit function, I found that
> > > there is a design doc[1], but there is no code to implement it.
> > >
> > > Could you create a new repo for Audit function?
> > > eg: phosphor-audit
> > >
> > > [1]: https://github.com/openbmc/docs/blob/master/designs/phosphor-audit.md
> > >
> > > thx - George Liu
> > >
> > > -------- End of Original Message --------
> > >
> > > Hi George.
> > >
> > >
> > > Please update the design with consideration for inclusive naming[2] before
> > > submitting code for it, as it uses depreciated terminology in it's external
> > > control interface.
> > >
> > > I see this design was merged almost 2 years ago before this policy was in
> > > place but as you said it hasn't been exposed by the community yet so we won't
> > > need to maintain compatibility with prior implementations.
> >
> > Thanks for your advice.
> > I will read and update this design doc ASAP :)
> >
> > >
> > >
> > > [2]
> > > https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#inclusive-naming
> > >
> > > Thanks,
> > > Milton
> > >
> > >
>
> George, there is answer about same question in this thread
> https://lists.ozlabs.org/pipermail/openbmc/2020-March/020839.html .
> Should be part of phosphor-logging.

Okay, Let me check, thanks so much

>
> Thanks.
>

Re: Request new repo for Audit function

[Ivan Mikhaylov]

On Fri, 2021-08-13 at 14:09 +0800, George Liu wrote:
> On Fri, Aug 13, 2021 at 11:22 AM Milton Miller II <miltonm@us.ibm.com> wrote:
> > 
> > 
> > Reply below
> > 
> > -------- Original Message --------
> > From: George Liu
> > Date: Thu, August 12, 2021 7:52 PM -0500
> > 
> > 
> > Hi Brad:
> > 
> > We have a requirement to implement an Audit function, I found that
> > there is a design doc[1], but there is no code to implement it.
> > 
> > Could you create a new repo for Audit function?
> > eg: phosphor-audit
> > 
> > [1]: https://github.com/openbmc/docs/blob/master/designs/phosphor-audit.md
> > 
> > thx - George Liu
> > 
> > -------- End of Original Message --------
> > 
> > Hi George.
> > 
> > 
> > Please update the design with consideration for inclusive naming[2] before
> > submitting code for it, as it uses depreciated terminology in it's external
> > control interface.
> > 
> > I see this design was merged almost 2 years ago before this policy was in
> > place but as you said it hasn't been exposed by the community yet so we won't
> > need to maintain compatibility with prior implementations.
> 
> Thanks for your advice.
> I will read and update this design doc ASAP :)
> 
> > 
> > 
> > [2] 
> > https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#inclusive-naming
> > 
> > Thanks,
> > Milton
> > 
> > 

George, there is answer about same question in this thread
https://lists.ozlabs.org/pipermail/openbmc/2020-March/020839.html .
Should be part of phosphor-logging.

Thanks.

Re: Request new repo for Audit function

[George Liu]

On Fri, Aug 13, 2021 at 11:22 AM Milton Miller II <miltonm@us.ibm.com> wrote:
>
>
> Reply below
>
> -------- Original Message --------
> From: George Liu
> Date: Thu, August 12, 2021 7:52 PM -0500
>
>
> Hi Brad:
>
> We have a requirement to implement an Audit function, I found that
> there is a design doc[1], but there is no code to implement it.
>
> Could you create a new repo for Audit function?
> eg: phosphor-audit
>
> [1]: https://github.com/openbmc/docs/blob/master/designs/phosphor-audit.md
>
> thx - George Liu
>
> -------- End of Original Message --------
>
> Hi George.
>
>
> Please update the design with consideration for inclusive naming[2] before submitting code for it, as it uses depreciated terminology in it's external control interface.
>
> I see this design was merged almost 2 years ago before this policy was in place but as you said it hasn't been exposed by the community yet so we won't need to maintain compatibility with prior implementations.

Thanks for your advice.
I will read and update this design doc ASAP :)

>
>
> [2] https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#inclusive-naming
>
> Thanks,
> Milton
>
>

Re: Request new repo for Audit function

[Milton Miller II]

[-- Attachment #1.1: Type: text/plain, Size: 987 bytes --]


Reply below

-------- Original Message --------
From: George Liu 
Date: Thu, August 12, 2021 7:52 PM -0500


Hi Brad:

We have a requirement to implement an Audit function, I found that
there is a design doc[1], but there is no code to implement it.

Could you create a new repo for Audit function?
eg: phosphor-audit

[1]: https://github.com/openbmc/docs/blob/master/designs/phosphor-audit.md

thx - George Liu

-------- End of Original Message --------

Hi George.


Please update the design with consideration for inclusive naming[2] before submitting code for it, as it uses depreciated terminology in it's external control interface.

I see this design was merged almost 2 years ago before this policy was in place but as you said it hasn't been exposed by the community yet so we won't need to maintain compatibility with prior implementations.


[2] https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#inclusive-naming

Thanks,
Milton


[-- Attachment #1.2: Type: text/html, Size: 1297 bytes --]