[+Benjamin Fair] 

Hi Greg,

This hardware is working in the same manner that Aspeed lpc snooping driver (/drivers/misc/aspeed-lpc-snoop.c)

On 16 July 2018 at 14:33, Greg KH <gregkh@linuxfoundation.org> wrote:
On Wed, Jul 04, 2018 at 12:14:27PM +0300, Tomer Maimon wrote:
> Add Nuvoton BMC NPCM7xx BIOS post code (BPC) driver.
>
> The NPCM7xx BPC monitoring two I/O address written by
> the host on the Low Pin Count (LPC) bus, the capure
> data stored in 128-word FIFO.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>

It would be great to get someone else who knows that this hardware is
supposed to be doing to ack or sign-off on this patch, as I don't know
if this really is providing the correct api for it or not. 
 
Joel could you sign-off this patch please.

Right now it's just reading data from the hardware, what good is that?
Who uses this?  What userspace tools connect up to it?

BMC is logging a configurable I/O port (for example 0x80 port which is BIOS post code) and remote management can get. 

about tools, the OpenBMC is using it.
https://github.com/openbmc/phosphor-host-postd
 
thanks,

greg k-h

thanks,

Tomer