On Tue, 30 Mar 2021 at 01:37, Joel Stanley <<= a href=3D"mailto:joel@jms.id.au">joel@jms.id.au> wrote:

On Sat, 27 Mar 2021 at 00:49= , William A. Kennington III <wak@google.com> wrote:
>
> Most of our machines don't have PHYs between the NIC and the BMC o= ver
> their NC-SI port. We don't want to use the kernel NC-SI machinery,= but
> we do want phyless support.
>
> Signed-off-by: William A. Kennington III <wak@google.com>

This looks fine to me. Tomer, Avi, can I please get a review from
someone at Nuvoton?

Reviewed-by: Joel Stanley <joel@jms.id.au>

It would be great to see this driver submitted upstream too!=C2=A0
> ---
>=C2=A0 drivers/net/ethernet/nuvoton/npcm7xx_emc.c | 31 ++++++++++++++++= +++++-
>=C2=A0 1 file changed, 30 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/nuvoton/npcm7xx_emc.c b/drivers/net/= ethernet/nuvoton/npcm7xx_emc.c
> index f07449e2f68d..1dc871a72180 100644
> --- a/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
> +++ b/drivers/net/ethernet/nuvoton/npcm7xx_emc.c
> @@ -26,6 +26,7 @@
>=C2=A0 #include <linux/of.h>
>=C2=A0 #include <linux/of_net.h>
>=C2=A0 #include <linux/of_device.h>
> +#include <linux/of_mdio.h>
>=C2=A0 #include <linux/dma-mapping.h>
>
>=C2=A0 #include <linux/regmap.h>
> @@ -242,6 +243,7 @@ struct=C2=A0 npcm7xx_ether {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct net_device *ndev;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct resource *res;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0unsigned int msg_enable;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0struct device_node *phy_dn;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct mii_bus *mii_bus;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct phy_device *phy_dev;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct napi_struct napi;
> @@ -1774,6 +1776,17 @@ static int npcm7xx_mii_setup(struct net_device = *dev)
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0pdev =3D ether->pdev;
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ether->phy_dn) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ether->phy_= dev =3D of_phy_connect(dev, ether->phy_dn,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&= adjust_link, 0, 0);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!ether->= ;phy_dn) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0dev_err(&dev->dev, "could not connect to phy %pOF= \n",
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ether->phy_dn);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0return -ENODEV;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return 0;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0}
> +
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ether->mii_bus =3D mdiobus_alloc()= ;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!ether->mii_bus) {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0err =3D -= ENOMEM;
> @@ -2011,6 +2024,15 @@ static int npcm7xx_ether_probe(struct platform_= device *pdev)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} else {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ether->= ;use_ncsi =3D false;
> +
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ether->phy_= dn =3D of_parse_phandle(np, "phy-handle", 0);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!ether->= ;phy_dn && of_phy_is_fixed_link(np)) {
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0error =3D of_phy_register_fixed_link(np);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0if (error < 0)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0goto failed_free_napi;
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0ether->phy_dn =3D of_node_get(np);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}
> +
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0error =3D npcm7xx_mii_setup(dev);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (error < 0) {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0dev_err(&= amp;pdev->dev, "npcm7xx_mii_setup err\n");
> @@ -2032,6 +2054,9 @@ static int npcm7xx_ether_probe(struct platform_d= evice *pdev)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return 0;
>
>=C2=A0 failed_free_napi:
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0of_node_put(ether->phy_dn);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0if (of_phy_is_fixed_link(np))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0of_phy_deregis= ter_fixed_link(np);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0netif_napi_del(&ether->napi);<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0platform_set_drvdata(pdev, NULL);
>=C2=A0 failed_free_io:
> @@ -2048,13 +2073,17 @@ static int npcm7xx_ether_remove(struct platfor= m_device *pdev)
>=C2=A0 {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct net_device *dev =3D platform_g= et_drvdata(pdev);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0struct npcm7xx_ether *ether =3D netde= v_priv(dev);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0struct device_node *np =3D pdev->dev.of= _node;
>
>=C2=A0 #ifdef CONFIG_DEBUG_FS
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0debugfs_remove_recursive(ether->db= gfs_dir);
>=C2=A0 #endif
> -
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0unregister_netdev(dev);
>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0of_node_put(ether->phy_dn);
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0if (of_phy_is_fixed_link(np))
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0of_phy_deregis= ter_fixed_link(np);
> +
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0free_irq(ether->txirq, dev);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0free_irq(ether->rxirq, dev);
>
> --
> 2.31.0.291.g576ba9dcdaf-goog
>