RE: [PATCH linux dev-5.10 v3 09/18] ipmi: kcs_bmc: Allow clients to control KCS IRQ state

[CS20 KWLiu <KWLIU@nuvoton.com>]

>-----Original Message-----
>diff --git a/drivers/char/ipmi/kcs_bmc_npcm7xx.c
>b/drivers/char/ipmi/kcs_bmc_npcm7xx.c
>index 9f0b168e487c..f8b7162fb830 100644
>--- a/drivers/char/ipmi/kcs_bmc_npcm7xx.c
>+++ b/drivers/char/ipmi/kcs_bmc_npcm7xx.c
>@@ -38,6 +38,7 @@
> #define KCS2CTL               0x2A
> #define KCS3CTL               0x3C
> #define    KCS_CTL_IBFIE      BIT(0)
>+#define    KCS_CTL_OBEIE      BIT(0)

Hi Andrew:

Appreciate all of your hard work and effort.

There is a wrong definition of kcs_bmc_npcm7xx.c.
The OBEIE bit offset in nuvoton BMC is 1.
#define    KCS_CTL_OBEIE        BIT(1)

Thanks,
Joseph

________________________________
________________________________
 The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.