From: ChiaWei Wang <chiawei_wang@aspeedtech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"andrew@aj.id.au" <andrew@aj.id.au>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: RE: [PATCH 4/4] ARM: dts: aspeed-g6: Add UDMA node
Date: Mon, 13 Feb 2023 01:46:17 +0000 [thread overview]
Message-ID: <KL1PR0601MB37811723965A68AB07016AF191DD9@KL1PR0601MB3781.apcprd06.prod.outlook.com> (raw)
In-Reply-To: <db065c0a-6c0e-ebf1-1867-6271b0cb5e8a@linaro.org>
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Friday, February 10, 2023 5:14 PM
>
> On 10/02/2023 08:26, Chia-Wei Wang wrote:
> > Add the device tree node for UART DMA controller.
> >
> > Signed-off-by: Chia-Wei Wang <chiawei_wang@aspeedtech.com>
> > ---
> > arch/arm/boot/dts/aspeed-g6.dtsi | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed-g6.dtsi
> b/arch/arm/boot/dts/aspeed-g6.dtsi
> > index cc2f8b785917..3f4e9da8f6c7 100644
> > --- a/arch/arm/boot/dts/aspeed-g6.dtsi
> > +++ b/arch/arm/boot/dts/aspeed-g6.dtsi
> > @@ -850,6 +850,13 @@ fsim1: fsi@1e79b100 {
> > clocks = <&syscon ASPEED_CLK_GATE_FSICLK>;
> > status = "disabled";
> > };
> > +
> > + udma: uart-dma@1e79e000 {
>
> Node names should be generic.
> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-
> basics.html#generic-names-recommendation
>
> > + compatible = "aspeed,ast2600-udma";
>
> Please run scripts/checkpatch.pl and fix reported warnings.
Thanks for reminding. Will add the dt-bindings for UDMA as well.
Regards,
Chiawei
prev parent reply other threads:[~2023-02-13 1:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 7:26 [PATCH 0/4] arm: aspeed: Add UART with DMA support Chia-Wei Wang
2023-02-10 7:26 ` [PATCH 1/4] dt-bindings: aspeed: Add UART controller Chia-Wei Wang
[not found] ` <2d0d1866-95f9-942d-57e0-06a5ed17d35d@linaro.org>
2023-02-13 1:57 ` ChiaWei Wang
2023-02-10 7:26 ` [PATCH 2/4] soc: aspeed: Add UART DMA support Chia-Wei Wang
2023-02-10 10:00 ` kernel test robot
[not found] ` <c1e096fa-5941-cdd8-2cdc-ecf04661a389@linaro.org>
2023-02-13 1:50 ` ChiaWei Wang
2023-02-10 7:26 ` [PATCH 3/4] serial: 8250: Add Aspeed UART driver Chia-Wei Wang
2023-02-10 10:35 ` Paul Menzel
2023-02-10 13:40 ` Ilpo Järvinen
2023-02-13 4:18 ` ChiaWei Wang
2023-02-10 13:52 ` Ilpo Järvinen
2023-02-13 1:45 ` ChiaWei Wang
2023-02-13 8:54 ` Ilpo Järvinen
2023-02-10 7:26 ` [PATCH 4/4] ARM: dts: aspeed-g6: Add UDMA node Chia-Wei Wang
[not found] ` <db065c0a-6c0e-ebf1-1867-6271b0cb5e8a@linaro.org>
2023-02-13 1:46 ` ChiaWei Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=KL1PR0601MB37811723965A68AB07016AF191DD9@KL1PR0601MB3781.apcprd06.prod.outlook.com \
--to=chiawei_wang@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).