openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Milton Miller II" <miltonm@us.ibm.com>
To: "Alexandre Belloni" <alexandre.belloni@bootlin.com>
Cc: Paul Fertser <fercerpav@gmail.com>,
	Ivan Mikhaylov <i.mikhaylov@yadro.com>,
	openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Alessandro Zummo <a.zummo@towertech.it>
Subject: RE: [PATCH 0/2] rtc: pch-rtc: add Intel Series PCH built-in read-only RTC
Date: Tue, 17 Aug 2021 18:04:09 +0000	[thread overview]
Message-ID: <OFBF96A764.75CCED3A-ON00258734.0062B30C-00258734.00634222@ibm.com> (raw)
In-Reply-To: <YRhQJ4kdyu1Xs1Rb@piout.net>


On Aug 16, 2021, Alexandre Belloni wrote:
>On 15/08/2021 01:42:15+0300, Paul Fertser wrote:
>> On Tue, Aug 10, 2021 at 06:44:34PM +0300, Ivan Mikhaylov wrote:
>> > Add RTC driver with dt binding tree document. Also this driver
>adds one sysfs
>> > attribute for host power control which I think is odd for RTC
>driver.
>> > Need I cut it off and use I2C_SLAVE_FORCE? I2C_SLAVE_FORCE is not
>good
>> > way too from my point of view. Is there any better approach?
>> 
>> Reading the C620 datasheet I see this interface also allows other
>> commands (wake up, watchdog feeding, reboot etc.) and reading
>statuses
>> (e.g Intruder Detect, POWER_OK_BAD).
>> 
>> I think if there's any plan to use anything other but RTC via this
>> interface then the driver should be registered as an MFD.
>> 
>
>This is not the current thinking, if everything is integrated, then
>there is no issue registering a watchdog from the RTC driver. I'll
>let
>you check with Lee...

I think the current statement is "if they are truly disjoint 
hardware controls" then an MFD might suffice, but if they require 
software cordination the new auxillary bus seems to be desired.

>>However, I'm not sure what is the correct interface for
>poweroff/reboot
>control.

While there is a gpio interface to a simple regulator switch,
the project to date has been asserting direct or indirect 
gpios etc to control the host.   If these are events to 
trigger a change in state and not a direct state change
that some controller trys to follow, maybe a message delivery 
model?   (this is not to reboot or cycle the bmc).

milton

  parent reply	other threads:[~2021-08-17 18:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-10 15:44 Ivan Mikhaylov
2021-08-10 15:44 ` [PATCH 1/2] rtc: pch-rtc: add RTC driver for Intel Series PCH Ivan Mikhaylov
2021-08-14 22:52   ` Paul Fertser
2021-08-20 12:34     ` Ivan Mikhaylov
2021-09-25 22:24       ` Alexandre Belloni
2021-08-10 15:44 ` [PATCH 2/2] dt-bindings: rtc: provide RTC PCH device tree binding doc Ivan Mikhaylov
2021-08-14 22:42 ` [PATCH 0/2] rtc: pch-rtc: add Intel Series PCH built-in read-only RTC Paul Fertser
2021-08-14 23:22   ` Alexandre Belloni
2021-08-17 18:04   ` Milton Miller II [this message]
2021-08-17 20:05     ` Alexandre Belloni
2021-08-30 11:56       ` Ivan Mikhaylov
2021-09-14 23:52         ` Ivan Mikhaylov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OFBF96A764.75CCED3A-ON00258734.0062B30C-00258734.00634222@ibm.com \
    --to=miltonm@us.ibm.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=fercerpav@gmail.com \
    --cc=i.mikhaylov@yadro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --subject='RE: [PATCH 0/2] rtc: pch-rtc: add Intel Series PCH built-in read-only RTC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).