openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: "Scron Chang (張仲延)" <Scron.Chang@quantatw.com>
To: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: [entity-manager] Issue about entity-manager getting stuck
Date: Wed, 27 Jan 2021 06:33:49 +0000	[thread overview]
Message-ID: <TYZPR04MB441643EFC954C795DD1290A886BB0@TYZPR04MB4416.apcprd04.prod.outlook.com> (raw)

Hi all,

I am using openbmc/entity-manager in this version: "f094125cd3bdbc8737dc8035a6e9ac252f6e8840" and I found calling Dbus makes entity-manager get stuck.

Reproduce this by following steps:
1. systemctl stop xyz.openbmc_project.EntityManager
2. open another terminal and do this while-loop: "while true; do busctl ; sleep 1; done"
3. systemctl start xyz.openbmc_project.EntityManager
I think the root cause is this function: "nameOwnerChangedMatch." (Please refer to this line: https://github.com/openbmc/entity-manager/blob/f094125cd3bdbc8737dc8035a6e9ac252f6e8840/src/EntityManager.cpp#L1859.)

Manually calling Dbus or calling Dbus in a script makes NameOwnerChanged signal and thus triggers the function: "propertiesChangedCallback" repeatedly. Meanwhile, the async_wait in propertiesChangedCallback gets returned because of the operation_aborted.
So here is the conclusion:
Manually calling Dbus in a period that is less than 5 seconds leads entity-manager keeping to trigger new async_wait and abort the old one. However, the async_wait never gets done.

Is this a bug of entity-manager, or I get something wrong. Please help me with this.

Scron Chang
E-Mail  Scron.Chang@quantatw.com


             reply	other threads:[~2021-01-27  6:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27  6:33 Scron Chang (張仲延) [this message]
2021-01-27 17:06 ` [entity-manager] Issue about entity-manager getting stuck Ed Tanous
2021-01-28  9:56   ` Konstantin Klubnichkin
2021-01-28 18:39     ` Ed Tanous
2021-02-03  7:22   ` Scron Chang (張仲延)
2021-02-03 16:11     ` Ed Tanous
2021-02-08  6:53       ` Scron Chang (張仲延)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TYZPR04MB441643EFC954C795DD1290A886BB0@TYZPR04MB4416.apcprd04.prod.outlook.com \
    --to=scron.chang@quantatw.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).