From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Quan Nguyen <quan@os.amperecomputing.com>
Cc: Paul Menzel <pmenzel@molgen.mpg.de>,
Arnd Bergmann <arnd@arndb.de>, Andrew Jeffery <andrew@aj.id.au>,
openbmc@lists.ozlabs.org,
Thang Nguyen <thang@os.amperecomputing.com>,
linux-kernel@vger.kernel.org,
Phong Vo <phong@os.amperecomputing.com>,
Joel Stanley <joel@jms.id.au>,
Open Source Submission <patches@amperecomputing.com>
Subject: Re: [PATCH 2/2] misc: smpro-errmon: Add dimm training failure syndrome
Date: Thu, 16 Feb 2023 13:30:09 +0100 [thread overview]
Message-ID: <Y+4h0V+LtaX8745A@kroah.com> (raw)
In-Reply-To: <98b2a8d6-c5bf-a782-7fc1-8874f94edc25@os.amperecomputing.com>
On Thu, Feb 16, 2023 at 10:22:14AM +0700, Quan Nguyen wrote:
>
>
> On 15/02/2023 14:33, Paul Menzel wrote:
> > Dear Quan,
> >
> >
> > Thank you for your patch.
> >
>
> Thanks Paul for the review.
>
> > Am 14.02.23 um 07:45 schrieb Quan Nguyen:
> > > Adds event_dimm[0-15]_syndrome sysfs to report the failure syndrome
> > > to BMC when DIMM training failed.
> >
> > Where you able to verify that it works? Out of curiosity, how?
> >
>
> Yes, we verified it by injecting DIMM errors and confirm that errors was
> reported correctly via sysfs.
> For about how to do error injection, we may need to refer to section 3.2
> Memory Error Group in Altra Family RAS Error Injection User Manual. It is
> shared in our Ampere Customer Connect [1]. The latest version is
> v1.00_20220329.
>
> [1] https://connect.amperecomputing.com
>
> > > Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> > > ---
> > > .../sysfs-bus-platform-devices-ampere-smpro | 10 +++
> > > drivers/misc/smpro-errmon.c | 77 +++++++++++++++++++
> > > 2 files changed, 87 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro
> > > b/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro
> > > index d4e3f308c451..c35f1d45e656 100644
> > > --- a/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro
> > > +++ b/Documentation/ABI/testing/sysfs-bus-platform-devices-ampere-smpro
> > > @@ -265,6 +265,16 @@ Description:
> > > For more details, see section `5.7 GPI Status Registers
> > > and 5.9 Memory Error Register Definitions,
> > > Altra Family Soc BMC Interface Specification`.
> > > +What:
> > > /sys/bus/platform/devices/smpro-errmon.*/event_dimm[0-15]_syndrome
> > > +KernelVersion: 6.1
> >
> > Should it be 6.2, as it probably won’t make it into 6.1?
> >
>
> Thanks for the catch. Will fix in next version.
Should be 6.3, it's missed the 6.2 merge window cycle, sorry.
thanks,
greg k-h
next prev parent reply other threads:[~2023-02-16 12:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 6:45 [PATCH 0/2] Add DIMM 2x refresh event and failure syndrome Quan Nguyen
2023-02-14 6:45 ` [PATCH 1/2] misc: smpro-errmon: Add DIMM 2x Refresh rate event Quan Nguyen
2023-02-14 6:45 ` [PATCH 2/2] misc: smpro-errmon: Add dimm training failure syndrome Quan Nguyen
2023-02-15 7:33 ` Paul Menzel
2023-02-16 3:22 ` Quan Nguyen
2023-02-16 12:30 ` Greg Kroah-Hartman [this message]
2023-02-17 2:36 ` Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+4h0V+LtaX8745A@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=pmenzel@molgen.mpg.de \
--cc=quan@os.amperecomputing.com \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).