From: Zev Weiss <zev@bewilderbeest.net>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Laxman Dewangan <ldewangan@nvidia.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Naresh Solanki <naresh.solanki@9elements.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>
Subject: Re: [PATCH 2/3] dt-bindings: regulator: Add regulator-output bindingg
Date: Mon, 31 Oct 2022 11:50:38 -0700 [thread overview]
Message-ID: <Y2AY/tQLQ6m+SXI7@hatter.bewilderbeest.net> (raw)
In-Reply-To: <Y1/tnic0qc/Ll/5u@sirena.org.uk>
On Mon, Oct 31, 2022 at 08:45:34AM PDT, Mark Brown wrote:
>On Fri, Oct 28, 2022 at 12:44:50PM -0700, Zev Weiss wrote:
>> On Fri, Oct 28, 2022 at 08:51:54AM PDT, Mark Brown wrote:
>
>> > We don't turn things off on reboot? We don't do anything in particular
>> > on reboot...
>
>> Okay, perhaps not on reboot specifically, but the userspace-consumer driver
>> has a regulator_bulk_disable() in its .remove function, so it would be
>> triggered at least by a module unload (which is sort of why I ended up with
>> the "when software relinquishes control" wording in the patch). If we're
>> going to continue with the plan of using that driver for this functionality
>> (which seems overall quite reasonable to me), we need a way to express that
>> that must not happen on this hardware.
>
>Ah, that would be the test driver not intended to be used in production
>then... That shouldn't be a blocker for the DT binding, and if there's
>a different compatible string for this application then we can either
>make the userspace consumer do something different based on that
>compatible string or have a new driver which does something more
>sensible and perhaps has a better userspace ABI. Either way so long as
>we can tell the thing being described is a BMC output from the DT
>binding I think we can leave it up to the OS to do something constructive
>with that rather than trying to control the specific behaviour in the
>binding.
Ah, alright -- that seems like a nice (obvious in retrospect, of course)
solution that should work well I think. I'll post a v2 with that
approach soon.
Thanks,
Zev
next prev parent reply other threads:[~2022-10-31 18:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-25 22:03 [PATCH 0/3] regulator: Add DT support for regulator-output connectors Zev Weiss
2022-09-25 22:03 ` [PATCH 1/3] regulator: devres: Add devm_regulator_bulk_get_exclusive() Zev Weiss
2022-09-25 22:03 ` [PATCH 2/3] dt-bindings: regulator: Add regulator-output binding Zev Weiss
2022-09-29 21:07 ` Rob Herring
2022-09-29 21:27 ` Zev Weiss
2022-10-27 18:42 ` Zev Weiss
[not found] ` <ee37b5a1-5afc-71b3-f777-add295d9ce17@linaro.org>
2022-10-28 4:12 ` [PATCH 2/3] dt-bindings: regulator: Add regulator-output bindingg Zev Weiss
2022-10-28 15:51 ` Mark Brown
2022-10-28 19:44 ` Zev Weiss
2022-10-31 15:45 ` Mark Brown
2022-10-31 18:50 ` Zev Weiss [this message]
2022-10-27 18:54 ` [PATCH 2/3] dt-bindings: regulator: Add regulator-output binding Mark Brown
2022-09-25 22:03 ` [PATCH 3/3] regulator: userspace-consumer: Handle regulator-output DT nodes Zev Weiss
2022-09-29 6:29 ` [PATCH 0/3] regulator: Add DT support for regulator-output connectors Patrick Rudolph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y2AY/tQLQ6m+SXI7@hatter.bewilderbeest.net \
--to=zev@bewilderbeest.net \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.solanki@9elements.com \
--cc=openbmc@lists.ozlabs.org \
--cc=patrick.rudolph@9elements.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).