openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Williams <patrick@stwcx.xyz>
To: "Mohammed.Habeeb ISV" <mohammed.habeeb@inventec.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: push code to gatesgarth branch
Date: Thu, 20 May 2021 15:26:59 -0500	[thread overview]
Message-ID: <YKbGE2s7ta47YuAH@patrickw3-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <PS2PR02MB3541E7D11C2149187922E3F3902A9@PS2PR02MB3541.apcprd02.prod.outlook.com>

[-- Attachment #1: Type: text/plain, Size: 803 bytes --]

On Thu, May 20, 2021 at 07:46:22PM +0000, Mohammed.Habeeb ISV wrote:
> We have added a new platform in openbmc 2.9 version. I tried to push the code for review however below error
> Occur. Can we still push the code to non-master old branches?
> Please let me know.

Hello Mohammed.

Two comments:

1. You tried to push directly into the gatesgarth branch rather than
`refs/for/gatesgarth`.  We don't allow anyone to push directly into
branches without review.

2. We have not been allowing development on old branches.  Is there any
reason why this code cannot go into the master branch, even if you are
using an older branch internally?  (Most open source projects have a
similar policy; development should happen on master and bug fixes can be
backported).

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-05-20 20:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 19:46 push code to gatesgarth branch Mohammed.Habeeb ISV
2021-05-20 20:26 ` Patrick Williams [this message]
2021-05-24 17:01 ` Mohammed.Habeeb ISV
2021-05-24 19:20   ` Patrick Williams
2021-05-25 14:36   ` krtaylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YKbGE2s7ta47YuAH@patrickw3-mbp.dhcp.thefacebook.com \
    --to=patrick@stwcx.xyz \
    --cc=mohammed.habeeb@inventec.com \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).