From: Patrick Williams <patrick@stwcx.xyz>
To: "Ren, Zhikui" <zhikui.ren@intel.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
Brad Bishop <bradleyb@fuzziesquirrel.com>
Subject: Re: beep code manager for openbmc
Date: Thu, 2 Sep 2021 16:58:53 -0500 [thread overview]
Message-ID: <YTFJHVW+bYoa1vIT@heinlein> (raw)
In-Reply-To: <DM6PR11MB4410B40F9D7DC46B72B0C87594CE9@DM6PR11MB4410.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1950 bytes --]
Hi Zhikui,
A few questions...
On Thu, Sep 02, 2021 at 08:15:21PM +0000, Ren, Zhikui wrote:
> Hi All,
>
> Beepcode manager is a stand-alone beep code service should be created to manage the beeper hardware, and provide D-Bus methods to expose the beeper function globally, all other services can use the beeper hardware by calling the beep methods.
>
> This package has been included in our distribution. Now we would like to upstream it and make it available to the community.
> https://github.com/Intel-BMC/openbmc/tree/intel/meta-openbmc-mods/meta-common/recipes-phosphor/beepcode-mgr
>
> Since it is now a very light service that only have one source file and a service file. I am wondering whether this service can go to an existing repository.
> If not, we would like to request a new repository for it.
>
> Thanks,
> Zhikui
>
I see it creates dbus interfaces but I don't see them defined anywhere. Can we
get that added to phosphor-dbus-interfaces?
It isn't obvious to me from looking at what interfaces are there who would call
it. I see various "beep code" patterns:
{beepVRWatchdogTimeout, "1-5-1-2"}, {beepPSUFailure, "1-5-1-4"},
{beepCPUMIssing, "1-5-2-1"}, {beepCPUCatError, "1-5-2-2"},
{beepCPUErr2, "1-5-2-3"}, {beepVoltageMismatch, "1-5-2-4"},
{beepCPUConfigError, "1-5-2-5"}, {beepPowerFail, "1-5-4-2"},
{beepPowerGoodTimeOut, "1-5-4-4"},
How do these get triggered? Do arbitrary programs call into the "BeepCode"
service when they hit their own event? This doesn't seem very maintainable;
shouldn't the beepcode service react to events through some other method,
similar to what is going on for Redfish events?
How easily configurable would this be for someone who has a different beepcode
policy than Intel's? Are you planning to update it with some JSON config or
leave that as an exercise for the next user?
--
Patrick Williams
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-09-02 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 20:15 beep code manager for openbmc Ren, Zhikui
2021-09-02 21:58 ` Patrick Williams [this message]
2021-09-08 15:29 ` Ren, Zhikui
2021-09-14 21:18 ` Patrick Williams
2021-09-20 20:14 ` Ren, Zhikui
2021-09-08 18:08 ` Milton Miller II
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTFJHVW+bYoa1vIT@heinlein \
--to=patrick@stwcx.xyz \
--cc=bradleyb@fuzziesquirrel.com \
--cc=openbmc@lists.ozlabs.org \
--cc=zhikui.ren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).