From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BBFAC433EF for ; Fri, 8 Oct 2021 05:46:10 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4CDA1610CE for ; Fri, 8 Oct 2021 05:46:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4CDA1610CE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HQccb2t0pz304n for ; Fri, 8 Oct 2021 16:46:07 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=lrh9ADDM; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.a=rsa-sha256 header.s=korg header.b=lrh9ADDM; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HQcbs1v9Mz2xtc; Fri, 8 Oct 2021 16:45:29 +1100 (AEDT) Received: by mail.kernel.org (Postfix) with ESMTPSA id E6609610E5; Fri, 8 Oct 2021 05:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1633671926; bh=hM+LEo6jq0sP4p14rwXKnhJUAnXreXijp/k9Sn8qwVQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lrh9ADDMfDgO+XapsVQdMVRnXrY8BIE5LKdZ6yUKCkAYaoI3jsMK8yGMPKTKmlUWK uIaGV774meo9+ScIbEyyEZlq9Y1h5SR0xThd/YS9MaUAigJOpmn4cSFyS0tuGwaar3 w0azjLgyNDYW4wJUiJmnTiLjYn93wgDLlpmDltP4= Date: Fri, 8 Oct 2021 07:45:22 +0200 From: Greg KH To: Joel Stanley Subject: Re: [PATCH v3] media: aspeed-video: ignore interrupts that aren't enabled Message-ID: References: <20210617220229.7352-1-zev@bewilderbeest.net> <46edf81d60a38747f7d2511f840253a1c6867652.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryan Chen , Zev Weiss , "linux-aspeed@lists.ozlabs.org" , "openbmc@lists.ozlabs.org" , Eddie James , "linux-kernel@vger.kernel.org" , Mauro Carvalho Chehab , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Fri, Oct 08, 2021 at 04:43:24AM +0000, Joel Stanley wrote: > Hi Greg, > > On Tue, 28 Sept 2021 at 18:57, Zev Weiss wrote: > > > > On Mon, Sep 06, 2021 at 04:47:14AM PDT, Joel Stanley wrote: > > >Hi Mauro, > > > > > >On Mon, 6 Sept 2021 at 10:10, Ryan Chen wrote: > > >> > Subject: Re: [PATCH v3] media: aspeed-video: ignore interrupts that aren't > > >> > enabled > > >> > > > >> > On Thu, 2021-06-17 at 17:02 -0500, Zev Weiss wrote: > > >> > > As partially addressed in commit 65d270acb2d6 ("media: aspeed: clear > > >> > > garbage interrupts"), the ASpeed video engine sometimes asserts > > >> > > interrupts that the driver hasn't enabled. In addition to the > > >> > > CAPTURE_COMPLETE and FRAME_COMPLETE interrupts dealt with in that > > >> > > patch, COMP_READY has also been observed. Instead of playing > > >> > > whack-a-mole with each one individually, we can instead just blanket > > >> > > ignore everything we haven't explicitly enabled. > > >> > > > >> > Suspect this will fix an intermittent problem on AST2500 with screensaver. > > >> > Change looks good, thanks! > > >> > > > >> > Reviewed-by: Eddie James > > >> > > > >> Reviewed-by: Ryan Chen > > >> > > > > >> > > Signed-off-by: Zev Weiss > > > > > >I notice this wasn't merged in the pull request you sent for v5.15. > > >Would you be able to ensure it makes it in the next pull request you > > >send? > > > > > >It can have some fixes tags too: > > > > > >Fixes: 65d270acb2d6 ("media: aspeed: clear garbage interrupts") > > >Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver") > > >Acked-by: Joel Stanley > > > > > >Cheers, > > > > > >Joel > > > > > > > Also not in the recent merge of the media/v5.15-2 tag it looks like -- ping? > > We're struggling to get a hold of the media maintainers to merge this > fix. Have you heard from them recently? I have seen them on the mailing list, yes. good luck! greg k-h