From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D15FEC433FE for ; Wed, 6 Oct 2021 14:41:45 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C7B8610C8 for ; Wed, 6 Oct 2021 14:41:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1C7B8610C8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stwcx.xyz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HPcbW46HCz2ygF for ; Thu, 7 Oct 2021 01:41:43 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=stwcx.xyz header.i=@stwcx.xyz header.a=rsa-sha256 header.s=fm3 header.b=mFKxuLyX; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=moPqGsVk; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=stwcx.xyz (client-ip=66.111.4.25; helo=out1-smtp.messagingengine.com; envelope-from=patrick@stwcx.xyz; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=stwcx.xyz header.i=@stwcx.xyz header.a=rsa-sha256 header.s=fm3 header.b=mFKxuLyX; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=moPqGsVk; dkim-atps=neutral Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HPcZZ3rCPz2xZH for ; Thu, 7 Oct 2021 01:40:54 +1100 (AEDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 922E45C007B; Wed, 6 Oct 2021 10:40:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 06 Oct 2021 10:40:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=+o7lQETVX/iWQyZ15RIR9HDw4ja HWM7ArR7OXQlPOEw=; b=mFKxuLyXimVJCqnLJcadR0nVEfzYuHcND8U4YPoIpJQ iHmjGqNtPvUKbCqH6HwjqAK92OnKwy6OnJ8D8Qzzx7x9B+/L+woujk+Jsbdudi+a VmN9CckxYdOBIRNiThGSEJ6BEpIWAWfnwqLqmqVPeB1a+p8yYMxLjn0/CNuoEXcy sp9qyOQlq5KE/YltysH0DqZgbe9AYdhj0DEl7LN7x0EOo311FOauBlFDN8/oobD7 Px1rskxkEX8fZH09Tjq6TBKERaYj+YKf6gNv78Bhroa+d4ZAcZRfLooHTSiPjEAr whlx90NvIExX9IlhYoggyiP1+gLOKpsGhcEyMB6lxvA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=+o7lQE TVX/iWQyZ15RIR9HDw4jaHWM7ArR7OXQlPOEw=; b=moPqGsVkqL655GgRkK8WbU mFXr7qLRX9gOWj2mpe1Hji1ysT2vB+ZMTY5cUgj5TLs+ke0yoFADOAdMTUJOn2fq OrjLWlOl1CYjwPxNcQIkg9Zq/ElKOQ7SYewCKhIE58x4pypwrgmC9HnMwwZQvVD8 YVyQzg19rzMYjUw4TCQst0KbHk3KRRBetAE+FS6T7MQEzBQEzX2YX7P4egpnkOpa 5j587QUKTIc6+KEzDbkV1OxYige3RmiYKrsEqdegHHCTR2c1fegSwboKjnQLsWwh 6DGeM7AukLrrSHBBpFWMs6QDuGvTq87Aw/nRshUsolpemEplk3oufddbst8aGzxQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeliedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomheprfgrthhrihgtkhcuhghilhhlihgrmhhsuceophgrthhrihgtkhessh htfigtgidrgiihiieqnecuggftrfgrthhtvghrnhepgeehheefffegkeevhedthffgudfh geefgfdthefhkedtleffveekgfeuffehtdeinecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepphgrthhrihgtkhesshhtfigtgidrgiihii X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Oct 2021 10:40:49 -0400 (EDT) Date: Wed, 6 Oct 2021 09:40:48 -0500 From: Patrick Williams To: Andrew Jeffery Subject: Re: support for gpio as ipmb sensor Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KbnuAfPTwmKEZNJ+" Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhikui Ren , Jae Hyun Yoo , Vernon Mauery , "openbmc@lists.ozlabs.org" , Ed Tanous , naveen moses , naveen moses Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" --KbnuAfPTwmKEZNJ+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 06, 2021 at 10:46:40AM +1030, Andrew Jeffery wrote: > On Tue, 5 Oct 2021, at 23:46, naveen moses wrote: > > So is this acceptable to create a new interface for gpio state under=20 > > xyz/openbmc_project/sensors : > > interface name : gpioState > > which has a property named value whose possible values are boolean=20 > > (true or false). >=20 > What about modelling the behaviour the GPIO state represents rather=20 > than just providing a DBus interface to the GPIO values? Agreed. In general we've tried to refrain from exposing raw GPIOs on the d= bus and instead tried to model some behavior out of those GPIOs. Your use case (wanting to use gpio-monitor) doesn't really seem strong enough to me to wa= rrant a change of this direction. You'd have to add support in `gpio-monitor` to watch dbus signals, in addition to gpio-lines, and create a new program that exposes those gpio objects. And, at the same time you're introducing a poo= rly documented API between two dbus providers because you're expecting very spe= cific name matching. Why not just have the original program do whatever you inte= nded gpio-monitor to do? --=20 Patrick Williams --KbnuAfPTwmKEZNJ+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmFdtW4ACgkQqwNHzC0A wRkd1g/+IMNxWaIGLrXXbWTOIejghFwwOHtitKjWvl1M4xNtHJyCFgUFkzPEE4NB g2V7yZewaZC87Seqhd7A8Mkx7AAaTJu6nyjpQ3dvzDys3iwAf4iXxf1O+7JB8gXo mxMqIioyI3Cem3NyAy9mwHjFub9ATsbYlqFgkk6IAeuSa6pC3/BO3HpSC6Ljc2QL QGkL4/uriBxbq2xTsrJGU7dj92+OqGXshC2FJ5jWJMdYc6vf4+Hp2dRuYKRZFN9f Gnettag9NIt+Zr+y/eVKd7qS08nihhxxsV76blVNoezqpiTGkFh3AKb4GB5n4FYx ZXKPaWn188XN/WS3yPBVCu8XNu3kKVqyp99OzW/JSDN3KhdamgEdStzPjPqLuvZb Mxrc+FQ+ArrbutjFIbmIWTeqILQiMN1uwjzqx3v2B4Vo9jFsPO3vELS+3X5Jsg30 cmljifB8ZOCZCGzT8ZXR0v1BOnYGIaAYmZq1EYk9091H+uIMpwh9nJbFtDIK6WL0 g53nKo7jXItJHF7SqANzELeRHzOH/hIYJpZfeLX6a5PKLmm63OMIlE63SbshySkl eOXuIW65U24u70Ngh9U+JRcqzWZp+V3HlQREj1gBtlW5cT9ZOeO04eTmtUevx2ao CZbFtEXVT0H+a+/Y5sQJSbbowFOtJGKxA58VgSbbF+Wzeh71WrI= =oHHw -----END PGP SIGNATURE----- --KbnuAfPTwmKEZNJ+--