From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E24B3C433EF for ; Wed, 29 Sep 2021 12:00:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 111A96140D for ; Wed, 29 Sep 2021 12:00:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 111A96140D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stwcx.xyz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HKFLC5L5xz2xXN for ; Wed, 29 Sep 2021 22:00:03 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=stwcx.xyz header.i=@stwcx.xyz header.a=rsa-sha256 header.s=fm3 header.b=PVbY/dJx; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=IXaperT3; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=stwcx.xyz (client-ip=66.111.4.27; helo=out3-smtp.messagingengine.com; envelope-from=patrick@stwcx.xyz; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=stwcx.xyz header.i=@stwcx.xyz header.a=rsa-sha256 header.s=fm3 header.b=PVbY/dJx; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=IXaperT3; dkim-atps=neutral X-Greylist: delayed 419 seconds by postgrey-1.36 at boromir; Wed, 29 Sep 2021 21:55:51 AEST Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HKFFM6pz6z2yxx for ; Wed, 29 Sep 2021 21:55:51 +1000 (AEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 48D5A5C0102; Wed, 29 Sep 2021 07:48:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 29 Sep 2021 07:48:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stwcx.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=RNSme47IMvyXqv7BNvAT7L+G+z0 8D9PXNQOsE+gyTi0=; b=PVbY/dJxBAwpPm6Hxzey+utSth8flE4cwcqsbUV9ZdZ hGHK1LgZPhp46/sGbE4Llojgf9riaQkNO/i3chD2d1UM4EmQzyd5agtDN6/4UVqg +prvsb+cl+3homxsCxNGCUgZRXWbWwzA0LF3fL/S35csvwiZpRGFsBfe8eUAatIF 9qJiuCduvvt7FOzSEG54x2V5ph8ZBOFIlxHL1x5irAt3w0tyXRnc4XAsU6VQpS4m lkcWAPIJKnNGicMAaRGDOf2kESnGUH1rB848EAJrDSqPDAmPhjUP7o4N2F8OzMJR MC75OqQ7BtOMyDnC+NYM2+yN1b/w9Jt7aeFwOPmU4Rw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=RNSme4 7IMvyXqv7BNvAT7L+G+z08D9PXNQOsE+gyTi0=; b=IXaperT3/sTFHaXaBznq2w VCGxg1o4N8GE5PFQYM1Vg54xBFfUEyEjO+MnKN+QJfkztw9HXOmiLW8l5dlkDZ4B mRrgrCA5k/Au6L0ai0p9vDqCK3UStiJjXNFgpbyokW/2smmKLw6NgUBWJ4iiu42b M8YvdNOYAKRu5YNQeqsyNnyHSUvfgp3J3fWf3RDDmmRj9XOwfEmoXdxJvg2RF5Xr UOnWQof6porSaUSDHu45lhZcpfMldwO7Sbb1d2CXq48mD7iUTedThWMwNVAzt93G pTUIKFXZU+apFgAdMvZLORrkqtOpiORcXtr0V/YlQcU9To1yiqvb5sp7CcgIgjUQ == X-ME-Sender:

X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudekvddggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtroertddt vdenucfhrhhomheprfgrthhrihgtkhcuhghilhhlihgrmhhsuceophgrthhrihgtkhessh htfigtgidrgiihiieqnecuggftrfgrthhtvghrnhepfeeikedvjeejheetgeeggeefgeff teeugfegtddvudeggfeugfefjedvuedvveevnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepphgrthhrihgtkhesshhtfigtgidrgiihii X-ME-Proxy:

Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 Sep 2021 07:48:41 -0400 (EDT) Date: Wed, 29 Sep 2021 06:48:40 -0500 From: Patrick Williams To: Kumar Thangavel Subject: Re: EEPROM Validation issue in Fru Device. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jivuflkApA9amPp/" Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jae Hyun Yoo , Vernon Mauery , "openbmc@lists.ozlabs.org" , Ed Tanous , Amithash Prasad , "Velumani T-ERS, HCLTech" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" --jivuflkApA9amPp/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 29, 2021 at 05:53:33AM +0000, Kumar Thangavel wrote: >=20 > 1. How the function isDevice16Bit Validated for 16 bit device ? My understanding is that Vijay wrote this originally when he wrote the Tiog= apass port. You should be able to confirm if it works there. >=20 > 2. Is my validation and analysis is correct ? Other people have complained (on Discord) that this current code doesn't wo= rk for all eeproms. If you have something that works better and doesn't break Tiogapass support, I would expect it to be accepted as a change in fru-devi= ce. --=20 Patrick Williams --jivuflkApA9amPp/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEBGD9ii4LE9cNbqJBqwNHzC0AwRkFAmFUUpYACgkQqwNHzC0A wRkFKBAAhAsBzdXxK/R3LnnePHyCKrU5tMmv4gMht+0rweG0BIEIkKauYZ2ONIAn f4vyTurm40mc5jR2GnvceyE0+eEVH+Cfw2D0WGzz+nQMHeIAaCgHKX8kyviRUNUG w01NKhiNbRwRGkNtQIXEKYs3xxW1zjlBR4nOvBCCtT8sYaXFKDkVmAsR7KnipnHo QwHE+r4j8zz/NL2PPiksKHzMMeud9AYYsfP83GYmSBxEas0ywmUx/xWGRtjcwP68 bDUZwZQkk5WraRfH2QOUwzdcRpLXFbRkPR1KDcC0LyBDzZ1eBIOZG4vQFStm32sY a6Q7ERH0yEXpR5w5CpbYaiSNV3ou1ghxaVWcvbKmuAwLqVv+Boh5u5/3zZ7HjCxu MRGWx6CH0e8i2xYS0/V/t3KlcgwJWcPjoNNASPTNJfBK2iulDfzmXSzG7Fg894Q4 hVgTxoc5foNyB/9sWzpwYLtCCxgZaiIrGY1dkyic9MrfkLGo1jB2VfmwQxd+on6s w6xPTiIGDASLtLlLOvFrS53xJFRuxbcR0Zlk2C/H+LagTJF5WFnN8WLAi8fXqn5p l0EHm4PalXnAtMJmuLQrOU0JaYHRWPU2VnPcOPmWk+hPqflDGg/2V0AdbKuNbhCd maA6EuvNRFnSlvZNK3HqDmPvetos3xlixtQAqoqM3hgcRkixEVs= =8ZH1 -----END PGP SIGNATURE----- --jivuflkApA9amPp/--