From: Wolfram Sang <wsa@kernel.org>
To: Quan Nguyen <quan@os.amperecomputing.com>
Cc: linux-arm-kernel@lists.infradead.org,
Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>,
openbmc@lists.ozlabs.org,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>,
Brendan Higgins <brendanhiggins@google.com>,
linux-kernel@vger.kernel.org,
Phong Vo <phong@os.amperecomputing.com>,
Open Source Submission <patches@amperecomputing.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 0/2] i2c: aspeed: Late ack Tx done irqs and fix unhandled Tx done with NAK
Date: Mon, 29 Nov 2021 20:20:20 +0100 [thread overview]
Message-ID: <YaUn9HO4STM+LmAD@kunai> (raw)
In-Reply-To: <20210616031046.2317-1-quan@os.amperecomputing.com>
[-- Attachment #1: Type: text/plain, Size: 969 bytes --]
On Wed, Jun 16, 2021 at 10:10:44AM +0700, Quan Nguyen wrote:
> This series consists of two patches to fix the below issues observed
> when testing with slave mode:
> + Unhandled Tx done with NAK
> + Early ack'ed of Tx done (ACK and NAK) causing "Unexpected Ack on
> read request".
>
aspeed maintainers, are you happy with this series now?
> v2:
> + Split these patches to separate series [Joel]
> + Added the Fixes lines [Joel]
> + Fixed multiline comment [Joel]
> + Refactor irq clearing code [Joel, Guenter]
> + Revised commit message [Joel, Quan]
>
> v1:
> + These patches are first introduced in
> https://lkml.org/lkml/2021/5/19/205
>
> Quan Nguyen (2):
> i2c: aspeed: Fix unhandled Tx done with NAK
> i2c: aspeed: Acknowledge Tx done with and without ACK irq late
>
> drivers/i2c/busses/i2c-aspeed.c | 22 ++++++++++++++--------
> 1 file changed, 14 insertions(+), 8 deletions(-)
>
> --
> 2.28.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-11-29 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 3:10 [PATCH v2 0/2] i2c: aspeed: Late ack Tx done irqs and fix unhandled Tx done with NAK Quan Nguyen
2021-06-16 3:10 ` [PATCH v2 1/2] i2c: aspeed: Fix " Quan Nguyen
2021-06-16 3:10 ` [PATCH v2 2/2] i2c: aspeed: Acknowledge Tx done with and without ACK irq late Quan Nguyen
2021-11-29 19:20 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaUn9HO4STM+LmAD@kunai \
--to=wsa@kernel.org \
--cc=andrew@aj.id.au \
--cc=brendanhiggins@google.com \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).