From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Quan Nguyen <quan@os.amperecomputing.com>
Cc: linux-aspeed@lists.ozlabs.org, linux-doc@vger.kernel.org,
Dragan Cvetic <dragan.cvetic@xilinx.com>,
Phong Vo <phong@os.amperecomputing.com>,
Lee Jones <lee.jones@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
openbmc@lists.ozlabs.org,
"Rafael J . Wysocki" <rafael@kernel.org>,
Derek Kiernan <derek.kiernan@xilinx.com>,
Guenter Roeck <linux@roeck-us.net>,
devicetree@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Arnd Bergmann <arnd@arndb.de>,
"Thang Q . Nguyen" <thang@os.amperecomputing.com>,
Rob Herring <robh+dt@kernel.org>,
Open Source Submission <patches@amperecomputing.com>,
linux-hwmon@vger.kernel.org, Andrew Jeffery <andrew@aj.id.au>,
Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH v6 6/9] misc: smpro-errmon: Add Ampere's SMpro error monitor driver
Date: Fri, 24 Dec 2021 09:32:44 +0100 [thread overview]
Message-ID: <YcWFrCjWSG65KQgb@kroah.com> (raw)
In-Reply-To: <20211224041352.29405-7-quan@os.amperecomputing.com>
On Fri, Dec 24, 2021 at 11:13:49AM +0700, Quan Nguyen wrote:
> This commit adds Ampere's SMpro error monitor driver for monitoring
> and reporting RAS-related errors as reported by SMpro co-processor
> found on Ampere's Altra processor family.
>
> Signed-off-by: Quan Nguyen <quan@os.amperecomputing.com>
> ---
> Change in v6:
> + First introduced in v6 [Quan]
>
> drivers/mfd/smpro-mfd.c | 1 +
> drivers/misc/Kconfig | 7 +
> drivers/misc/Makefile | 1 +
> drivers/misc/smpro-errmon.c | 571 ++++++++++++++++++++++++++++++++++++
> 4 files changed, 580 insertions(+)
> create mode 100644 drivers/misc/smpro-errmon.c
You need Documentation/ABI/ updates when you add sysfs files. Please do
that for your next version of this patch.
Also remember that sysfs is only "one value per file", this driver seems
to violate that in huge ways and is not ok.
thanks,
greg k-h
next prev parent reply other threads:[~2021-12-24 8:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-24 4:13 [PATCH v6 0/9] Add Ampere's Altra SMPro MFD and its child drivers Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 1/9] dt-bindings: mfd: Add bindings for Ampere Altra SMPro MFD driver Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 2/9] mfd: smpro-mfd: Adds Ampere's Altra SMpro " Quan Nguyen
2022-02-08 9:12 ` Lee Jones
2022-03-07 8:31 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 3/9] hwmon: smpro: Add Ampere's Altra smpro-hwmon driver Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 4/9] docs: hwmon: (smpro-hwmon) Add documentation Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 5/9] regmap: Introduces regmap lock helpers Quan Nguyen
2021-12-24 13:19 ` Mark Brown
2022-03-07 8:31 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 6/9] misc: smpro-errmon: Add Ampere's SMpro error monitor driver Quan Nguyen
2021-12-24 8:32 ` Greg Kroah-Hartman [this message]
2022-03-07 8:32 ` Quan Nguyen
2021-12-24 13:28 ` Mark Brown
2022-03-07 8:30 ` Quan Nguyen
2021-12-29 10:16 ` Lee Jones
2022-03-07 8:31 ` Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 7/9] docs: misc-devices: (smpro-errmon) Add documentation Quan Nguyen
2021-12-24 4:13 ` [PATCH v6 8/9] misc: smpro-misc: Add Ampere's Altra SMpro misc driver Quan Nguyen
2021-12-29 10:18 ` Lee Jones
2022-03-07 8:32 ` Quan Nguyen
2022-03-07 13:16 ` Arnd Bergmann
2021-12-24 4:13 ` [PATCH v6 9/9] docs: misc-devices: (smpro-misc) Add documentation Quan Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcWFrCjWSG65KQgb@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=corbet@lwn.net \
--cc=derek.kiernan@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=dragan.cvetic@xilinx.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).