Re: Checking for network online

From: Patrick Williams <patrick@stwcx.xyz>
To: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Lei Yu <yulei.sh@bytedance.com>,
	Johnathan Mantey <johnathanx.mantey@intel.com>
Subject: Re: Checking for network online
Date: Wed, 23 Feb 2022 07:48:27 -0600	[thread overview]
Message-ID: <YhY7Kxgg6ew0HdUR@heinlein> (raw)
In-Reply-To: <64727f8e-cca3-b04d-e4cf-709ceb60f37f@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 2223 bytes --]

On Wed, Feb 23, 2022 at 10:09:19AM +0800, Jiaqing Zhao wrote:
> I think a solution is to set RequiredForOnline=no (https://www.freedesktop.org/software/systemd/man/systemd.network.html#RequiredForOnline=) in all network interface config. This option skips the interface when running systemd-networkd-wait-online.service. Canonical netplan (used in ubuntu server) also uses this option to skip the online check for given interface (https://github.com/canonical/netplan/blob/main/src/networkd.c#L636-L639).
> 
> I'll submit a patch to phosphor-networkd later.

I really don't think this is appropriate for all systems.  Services have
dependencies on network-online.target for a reason.  If the side-effect of
having the BMC network cable unplugged is that the host doesn't boot, that might
be entirely reasonable behavior in some environments.

We use rsyslog as the mechanism to offload our BMC logging data to an
aggregation point.  When you have a very large scale deployment, it is actually
better for the system to not come online than for us to lose out on that data,
since we have spare capacity to take its place.

Note that the Canonical netplan only applies this option if the configuration
indicates that the interface is optional, which is entirely appropriate.  The
way you wrote it could have been interpreted that they set this on *every*
interface, which is what it seems like you're proposing to do to
phosphor-networkd.

If this is desired behavior for someone, can't you supply a wildcard .network
file that adds this option, rather than modifying phosphor-networkd to manually
add it to each network interface that it is managing?

I believe some designs use a USB network device to connect two internal pieces
of the system and those interfaces are not necessarily managed by
phosphor-networkd (interfaces that, for example connect BMC-to-BMC or
BMC-to-Host).  While it is obviously up to the system designer to work through
this bug, by applying this configuration as you proposed you are causing
unusual default behavior in that networkd is going to start waiting for these
internal connections to come online instead of the external interface.

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]