Re: [PATCH 14/18] dt-bindings: irqchip: nuvoton, wpcm450-aic: include generic schema

From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: "Nishanth Menon" <nm@ti.com>, "Bert Vermeulen" <bert@biot.com>,
	"Geert Uytterhoeven" <geert+renesas@glider.be>,
	"Neil Armstrong" <narmstrong@baylibre.com>,
	"Lokesh Vutla" <lokeshvutla@ti.com>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	"Cristian Ciocaltea" <cristian.ciocaltea@gmail.com>,
	"Paul Cercueil" <paul@crapouillou.net>,
	"Daniel Palmer" <daniel@thingy.jp>,
	"Sagar Kadam" <sagar.kadam@sifive.com>,
	linux-riscv@lists.infradead.org, "Suman Anna" <s-anna@ti.com>,
	"Mark-PK Tsai" <mark-pk.tsai@mediatek.com>,
	"Paul Burton" <paulburton@kernel.org>,
	"Marc Zyngier" <maz@kernel.org>,
	openbmc@lists.ozlabs.org, "John Crispin" <john@phrozen.org>,
	"Birger Koblitz" <mail@birger-koblitz.de>,
	linux-oxnas@groups.io, devicetree@vger.kernel.org,
	"Jason Cooper" <jason@lakedaemon.net>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org,
	"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Halasa" <khalasa@piap.pl>,
	"Santosh Shilimkar" <ssantosh@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	linux-arm-kernel@lists.infradead.org,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
	"Tero Kristo" <kristo@kernel.org>,
	"Linus Walleij" <linusw@kernel.org>,
	"Joakim Zhang" <qiangqing.zhang@nxp.com>,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	"Dinh Nguyen" <dinguyen@kernel.org>,
	"Michael Walle" <michael@walle.cc>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Imre Kaloz" <kaloz@openwrt.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"Lucas Stach" <l.stach@pengutronix.de>
Subject: Re: [PATCH 14/18] dt-bindings: irqchip: nuvoton, wpcm450-aic: include generic schema
Date: Thu, 17 Mar 2022 13:05:54 +0100	[thread overview]
Message-ID: <YjMkIkaMD4aXW4p3@latitude> (raw)
In-Reply-To: <20220317115705.450427-13-krzysztof.kozlowski@canonical.com>

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

On Thu, Mar 17, 2022 at 12:57:01PM +0100, Krzysztof Kozlowski wrote:
> Include generic interrupt-controller.yaml schema, which enforces node
> naming and other generic properties.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> ---

Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

>  .../bindings/interrupt-controller/nuvoton,wpcm450-aic.yaml | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/nuvoton,wpcm450-aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/nuvoton,wpcm450-aic.yaml
> index 9ce6804bdb99..285c20de0962 100644
> --- a/Documentation/devicetree/bindings/interrupt-controller/nuvoton,wpcm450-aic.yaml
> +++ b/Documentation/devicetree/bindings/interrupt-controller/nuvoton,wpcm450-aic.yaml
> @@ -9,6 +9,9 @@ title: Nuvoton WPCM450 Advanced Interrupt Controller bindings
>  maintainers:
>    - Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>  
> +allOf:
> +  - $ref: /schemas/interrupt-controller.yaml#
> +
>  properties:
>    '#interrupt-cells':
>      const: 2
> @@ -21,14 +24,14 @@ properties:
>    reg:
>      maxItems: 1
>  
> -additionalProperties: false
> -
>  required:
>    - '#interrupt-cells'
>    - compatible
>    - reg
>    - interrupt-controller
>  
> +unevaluatedProperties: false
> +
>  examples:
>    - |
>      aic: interrupt-controller@b8002000 {
> -- 
> 2.32.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]