From: Tao Ren <rentao.bupt@gmail.com>
To: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org,
Andrew Jeffery <andrew@aj.id.au>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v1] Update for Facebook yosemite V2 BMC.
Date: Mon, 5 Sep 2022 23:27:42 -0700 [thread overview]
Message-ID: <YxboXspF+0Y/+spD@taoren-fedora-PC23YAB4> (raw)
In-Reply-To: <20220906050702.GA10565@hcl-ThinkPad-T495>
Hi Karthikeyan,
I don't have much experience with ipmb-dev, but I'd suggest updating the
patch tile so it's consistent with other dts patches. For example:
"ARM: dts: aspeed: yosemitev2: Enable i2c13 controller"
Cheers,
- Tao
On Tue, Sep 06, 2022 at 10:37:02AM +0530, Karthikeyan Pasupathi wrote:
> Added IPMB-13 channel for Debug Card communication.
>
> ---
> --- v1 - Initial draft.
> ---
>
> Signed-off-by: Karthikeyan Pasupathi <pkarthikeyan1509@gmail.com>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> index 8864e9c312a8..84236df522dc 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> @@ -215,6 +215,17 @@
> };
> };
>
> +&i2c13 {
> + status = "okay";
> + // Debug Card
> + multi-master;
> + ipmb13@10 {
> + compatible = "ipmb-dev";
> + reg = <(0x10 | I2C_OWN_SLAVE_ADDRESS)>;
> + i2c-protocol;
> + };
> +};
> +
> &pwm_tacho {
> status = "okay";
> //FSC
> --
> 2.17.1
>
next prev parent reply other threads:[~2022-09-06 6:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 5:07 [PATCH v1] Update for Facebook yosemite V2 BMC Karthikeyan Pasupathi
2022-09-06 6:27 ` Tao Ren [this message]
2022-09-06 7:31 ` karthikeyan P
2022-09-06 11:12 Karthikeyan Pasupathi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxboXspF+0Y/+spD@taoren-fedora-PC23YAB4 \
--to=rentao.bupt@gmail.com \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pkarthikeyan1509@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).