From: Jammy Huang <jammy_huang@aspeedtech.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>, <eajames@linux.ibm.com>,
<mchehab@kernel.org>, <joel@jms.id.au>, <andrew@aj.id.au>,
<sakari.ailus@linux.intel.com>, <gregkh@linuxfoundation.org>,
<laurent.pinchart@ideasonboard.com>,
<linux-media@vger.kernel.org>, <openbmc@lists.ozlabs.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 00/10] add aspeed-jpeg support for aspeed-video
Date: Fri, 26 Nov 2021 16:17:20 +0800 [thread overview]
Message-ID: <b6ba49f3-a9ed-f5e6-959c-309db8cce7f6@aspeedtech.com> (raw)
In-Reply-To: <5ab806d1-e407-1fa4-83ec-93ebe8df7db4@xs4all.nl>
Hi Hans,
Please refer to Page 132, 'Video stream data format – ASPEED mode compression' of
https://github.com/AspeedTech-BMC/openbmc/releases/download/v07.02/SDK_User_Guide_v07.02.pdf
Is above information enough??
Or maybe we can postpone this series until the source code for this format ready.
I think I can accomplish it by the end of this year.
On 2021/11/25 下午 10:31, Hans Verkuil wrote:
> Hi Jammy,
>
> I suggest posting a v3 that moves the patches that deal with the
> Aspeed JPEG format to the end of the series. That way I can easily
> merge the patches up to that point, and the Aspeed JPEG support can
> be handled separately.
>
> I'm not sure if it can be merged without that format being documented,
> either in pixfmt-reserved.rst, by implementing support for it in
> libv4lconvert from v4l-utils, or by providing a URL to some other
> publicly available source code. We really don't like adding pixel
> formats that cannot be interpreted by someone without access to the
> datasheets.
>
> Regards,
>
> Hans
>
> On 18/11/2021 08:40, Jammy Huang wrote:
>> The aim of this series is to add aspeed-jpeg support for aspeed-video
>> driver.
>>
>> To achieve this major goal some refactors are included.
>>
>> In the last, debugfs information is also updated per this change.
>>
>> Changes in v5:
>> - Use model data to tell different soc
>>
>> Changes in v4:
>> - Add definition for the Aspeed JPEG format
>> - Reserve controls for ASPEED
>> - Use s_fmt to update format rather than new control
>> - Update aspeed hq quality range, 1 ~ 12
>>
>>
>> Jammy Huang (10):
>> media: aspeed: move err-handling together to the bottom
>> media: aspeed: use v4l2_info/v4l2_warn/v4l2_dbg for log
>> media: aspeed: add more debug log messages
>> media: aspeed: refactor to gather format/compress settings
>> media: v4l: Add definition for the Aspeed JPEG format
>> media: v4l2-ctrls: Reserve controls for ASPEED
>> media: aspeed: use model-data
>> media: aspeed: Support aspeed mode to reduce compressed data
>> media: aspeed: add comments and macro
>> media: aspeed: Extend debug message
>>
>> .../media/uapi/v4l/pixfmt-reserved.rst | 12 +
>> drivers/media/platform/aspeed-video.c | 534 ++++++++++++++----
>> drivers/media/v4l2-core/v4l2-ioctl.c | 1 +
>> include/uapi/linux/aspeed-video.h | 15 +
>> include/uapi/linux/v4l2-controls.h | 5 +
>> include/uapi/linux/videodev2.h | 1 +
>> 6 files changed, 467 insertions(+), 101 deletions(-)
>> create mode 100644 include/uapi/linux/aspeed-video.h
>>
--
Best Regards
Jammy
next prev parent reply other threads:[~2021-11-26 8:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 7:40 [PATCH v5 00/10] add aspeed-jpeg support for aspeed-video Jammy Huang
2021-11-18 7:40 ` [PATCH v5 01/10] media: aspeed: move err-handling together to the bottom Jammy Huang
2021-11-18 7:40 ` [PATCH v5 02/10] media: aspeed: use v4l2_info/v4l2_warn/v4l2_dbg for log Jammy Huang
2021-11-18 11:56 ` Sakari Ailus
2021-11-19 1:44 ` Jammy Huang
2021-11-18 7:40 ` [PATCH v5 03/10] media: aspeed: add more debug log messages Jammy Huang
2021-11-18 11:57 ` Sakari Ailus
2021-11-19 1:55 ` Jammy Huang
2021-11-18 7:40 ` [PATCH v5 04/10] media: aspeed: refactor to gather format/compress settings Jammy Huang
2021-11-18 7:40 ` [PATCH v5 05/10] media: v4l: Add definition for the Aspeed JPEG format Jammy Huang
2021-11-18 12:33 ` Sakari Ailus
2021-11-19 2:02 ` Jammy Huang
2021-11-19 8:39 ` Paul Menzel
2021-11-19 9:37 ` Jammy Huang
2021-11-23 10:23 ` Sakari Ailus
2021-11-26 8:08 ` Jammy Huang
2021-11-18 7:40 ` [PATCH v5 06/10] media: v4l2-ctrls: Reserve controls for ASPEED Jammy Huang
2021-11-18 7:40 ` [PATCH v5 07/10] media: aspeed: Use runtime configuration Jammy Huang
2021-11-18 7:40 ` [PATCH v5 08/10] media: aspeed: Support aspeed mode to reduce compressed data Jammy Huang
2021-11-25 14:39 ` Hans Verkuil
2021-11-18 7:40 ` [PATCH v5 09/10] media: aspeed: add comments and macro Jammy Huang
2021-11-25 14:31 ` [PATCH v5 00/10] add aspeed-jpeg support for aspeed-video Hans Verkuil
2021-11-26 8:17 ` Jammy Huang [this message]
2021-11-26 9:51 ` Hans Verkuil
2021-12-02 1:29 ` Jammy Huang
2021-12-07 3:03 ` Jammy Huang
2021-12-20 19:55 ` sakari.ailus
2021-12-21 2:13 ` Jammy Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6ba49f3-a9ed-f5e6-959c-309db8cce7f6@aspeedtech.com \
--to=jammy_huang@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=joel@jms.id.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).