From: "Bills, Jason M" <jason.m.bills@linux.intel.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
Zev Weiss <zweiss@equinix.com>
Subject: Re: [PATCH 1/2] pinctrl: aspeed: Enable pass-through on GPIOE1 and GPIOE3 free
Date: Fri, 25 Feb 2022 08:22:33 -0700 [thread overview]
Message-ID: <d00832b5-e5af-5818-2634-a05bbb22852c@linux.intel.com> (raw)
In-Reply-To: <CACPK8XdsoL9_aTJL2KV9KD-djtiLRsJnHqWzL6gTWOMKRkjKOw@mail.gmail.com>
On 2/24/2022 9:49 PM, Joel Stanley wrote:
> On Thu, 24 Feb 2022 at 21:03, Bills, Jason M
> <jason.m.bills@linux.intel.com> wrote:
>>
>>>
>>> Jason, you should send the patch to the upstream lists (use
>>> get_maintainers.pl) for review.
>> Sorry for the delay. I found the right lists with get_maintainers.pl.
>> Should I send these patches to the upstream lists as they are, or do
>> they need to be tweaked?
>
> You've got some review comments from Andrew and Zev that you should
> address. I suggest replying to them, and adding the pinctrl list on
> cc. Then when you post v2 you can send them to the upstream lists.
>
> If you'd prefer to just send a v2 to the upstream lists to restart the
> discussion you could do that too. Your call.
Thanks! Unless I missed something, I didn't see any specific feedback
that would require a v2, yet.
It sounded like Andrew was theorizing a better implementation and was
going think on it some more. So, would it be better to wait for a
cleaner implementation of this before we send it upstream?
Thanks,
-Jason
>
> Cheers,
>
> Joel
next prev parent reply other threads:[~2022-02-25 15:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-02 19:59 [PATCH 1/2] pinctrl: aspeed: Enable pass-through on GPIOE1 and GPIOE3 free Bills, Jason M
2022-02-02 22:49 ` Andrew Jeffery
2022-02-02 23:14 ` Zev Weiss
2022-02-07 6:45 ` Joel Stanley
2022-02-24 21:03 ` Bills, Jason M
2022-02-25 4:49 ` Joel Stanley
2022-02-25 15:22 ` Bills, Jason M [this message]
2022-02-28 0:04 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d00832b5-e5af-5818-2634-a05bbb22852c@linux.intel.com \
--to=jason.m.bills@linux.intel.com \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
--cc=zweiss@equinix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).