From: "George Hung (洪忠敬)" <George.Hung@quantatw.com>
To: Andrew Geissler <geissonator@gmail.com>,
Vernon Mauery <vernon.mauery@linux.intel.com>
Cc: Tung Nguyen OS <tungnguyen@os.amperecomputing.com>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: RE: ipmi command implementation mismatch with the design document
Date: Thu, 10 Dec 2020 08:34:54 +0000 [thread overview]
Message-ID: <deba1c442929478b81e6e4205ba6eb0f@quantatw.com> (raw)
In-Reply-To: <73E4FC5B-45F9-436F-B6A5-D01BEB44A8B7@gmail.com>
> On Nov 24, 2020, at 1:06 PM, Vernon Mauery <vernon.mauery@linux.intel.com> wrote:
>
> On 23-Nov-2020 06:39 AM, Tung Nguyen OS wrote:
>>
>> Although the indicate_no_softoff_needed() can prevent the host from soft off, but it seems like a mismatch b/w the design document and the IPMI implementation.
>>
>> So, my question: is it reasonable for IPMI command ?
>
> This code has been in place for quite some time now, so I am not sure if the original authors have the context at this point in time. But nobody else has raised this question. git blame says that Andrew Geissler added this feature, but we would have to see if he still knows why.
> commit a6e3a3080d532536e02e304c819c1e17214e038a
> Author: Andrew Geissler <andrewg@us.ibm.com>
> Date: Wed May 31 19:34:00 2017 -0500
>
> Create file to indicate host requested off/reboot
>
> Create a file to ensure the soft power off service is
> not run when the host is requesting a power off
> or reboot. There's no need to notify the host (i.e.
> soft power off) when they are initiating it.
>
> Change-Id: Ic9f8e7110d30f477ceae38bba9d684559d9503d3
> Signed-off-by: Andrew Geissler <andrewg@us.ibm.com>
>
> I’m wondering if this ties into the discussion in https://github.com/openbmc/phosphor-host-ipmid/issues/158?
> Are you having the same issue Tung? May be time to just put up a commit that does this correctly and discuss via gerrit.
Hi Andrew, I have the same question about ipmi chassis power off,
because according to https://github.com/openbmc/docs/blob/master/designs/state-management-and-external-interfaces.md
Should it be set state transition to "State::Chassis::Transition::Off", not "State::Host::Transition::Off" ?
Or do I miss something I don't know.
Best Regards
George Hung
>
> --Vernon
>
>> Reference:
>> https://github.com/openbmc/docs/blob/master/designs/state-management-
>> and-external-interfaces.md
>>
>> Best regards,
>> Tung
prev parent reply other threads:[~2020-12-10 8:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 6:39 ipmi command implementation mismatch with the design document Tung Nguyen OS
2020-11-24 19:06 ` Vernon Mauery
2020-11-30 17:36 ` Andrew Geissler
2020-12-10 8:34 ` George Hung (洪忠敬) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=deba1c442929478b81e6e4205ba6eb0f@quantatw.com \
--to=george.hung@quantatw.com \
--cc=geissonator@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=tungnguyen@os.amperecomputing.com \
--cc=vernon.mauery@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).