openbmc.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Gunnar Mills <gmills@linux.vnet.ibm.com>
To: Ed Tanous <ed@tanous.net>, "i.kononenko" <i.kononenko@yadro.com>,
	Derick Montague <Derick.Montague@ibm.com>
Cc: Ali Ahmed <ama213000@gmail.com>,
	OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: Turning off the D-Bus REST API by default
Date: Fri, 13 Aug 2021 10:05:36 -0600	[thread overview]
Message-ID: <e554b486-58e8-94aa-41c2-9fefb9aff339@linux.vnet.ibm.com> (raw)
In-Reply-To: <CACWQX81EWvBY=g+weGJHbxA2NWzujeHrHFBA9Cbv0=0OMGya1g@mail.gmail.com>

On 8/12/2021 2:41 PM, Ed Tanous wrote:
> On Thu, Aug 12, 2021 at 1:32 PM i.kononenko <i.kononenko@yadro.com> wrote:
>>
>> Ali,
>>
>> On 12.08.2021 17:10, Ali Ahmed wrote:
>>
>>> After this commit to use phosphor-webui or D-Bus REST, you will need
>>> to set -Drest=enabled in your bbappend. Note: webui-vue uses Redfish
>>> and will not be impacted. Let me know if you have any concerns.
>>
>> As far I knew, the webui-vue uses REST API to retrieve the TPM status.
>> Please, look to the link below [1]
> 
> @gunnar @derick  isn't this against one of the primary design goals of
> webui-vue?  Was it intentionally merged?  It seems like having
> webui-vue rely on dbus-rest just keeps digging the hole deeper on this
> initial thing, which is getting dbus-rest disabled by default.
> 

I think when this was merged 2 years ago, when webui-vue was still very 
very young, the thinking was we will switch to Redfish when TPMenable is 
implemented in Redfish and there was value to having a working page. 
This does go against a core design goal of webui-vue.  I certainly would 
-1 any commit trying to add D-Bus REST API to webui-vue today. I think 
this is just a TODO that hasn't been implemented.
https://github.com/openbmc/webui-vue/blame/6dba4be6125c10210bafa030ac17737d3a9b28b8/src/store/modules/Operations/BootSettingsStore.js#L74

GET TrustedModuleRequiredToBoot is available today. The PATCH is in 
review here: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/44044

We will push a commit to switch this to Redfish.

  reply	other threads:[~2021-08-13 16:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 14:10 Ali Ahmed
2021-08-12 14:55 ` Patrick Williams
2021-08-12 17:56   ` Garrett, Mike (HPE Server Firmware)
2021-08-12 20:47   ` Ed Tanous
2021-08-12 20:31 ` i.kononenko
2021-08-12 20:41   ` Ed Tanous
2021-08-13 16:05     ` Gunnar Mills [this message]
2021-08-13 17:20       ` Ed Tanous
2021-08-12 22:37   ` Ali Ahmed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e554b486-58e8-94aa-41c2-9fefb9aff339@linux.vnet.ibm.com \
    --to=gmills@linux.vnet.ibm.com \
    --cc=Derick.Montague@ibm.com \
    --cc=ama213000@gmail.com \
    --cc=ed@tanous.net \
    --cc=i.kononenko@yadro.com \
    --cc=openbmc@lists.ozlabs.org \
    --subject='Re: Turning off the D-Bus REST API by default' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).