From: "Andrew Jeffery" <firstname.lastname@example.org>
To: "Joel Stanley" <email@example.com>
Cc: devicetree <firstname.lastname@example.org>,
OpenBMC Maillist <email@example.com>,
Linux Kernel Mailing List <firstname.lastname@example.org>,
Rob Herring <email@example.com>,
Linux ARM <firstname.lastname@example.org>
Subject: Re: [PATCH] ARM: dts: tacoma: Add phase corrections for eMMC
Date: Thu, 01 Jul 2021 14:38:48 +0930 [thread overview]
Message-ID: <email@example.com> (raw)
On Thu, 1 Jul 2021, at 13:10, Joel Stanley wrote:
> On Fri, 25 Jun 2021 at 06:10, Andrew Jeffery <firstname.lastname@example.org> wrote:
> > The degree values were reversed out from the magic tap values of 7 (in)
> > and 15 + inversion (out) initially suggested by Aspeed.
> > With the patch tacoma survives several gigabytes of reads and writes
> > using dd while without it locks up randomly during the boot process.
> > Signed-off-by: Andrew Jeffery <email@example.com>
> Thanks for the fix. Is this required due to "mmc: sdhci-of-aspeed: Add
> AST2600 bus clock support" or "mmc: sdhci-of-aspeed: Expose clock
> phase controls"?
Sort of neither, it's really a bug with the devicetrees.
> On the topic of those patches, it would be good if we could operate
> the devices (with the slower speed?) when the device tree does not
> provide the phase values. Think about system bringup, or where you
> need the system booting in order to determine the phase calculations.
You can use the maximum-frequency binding to make things go slow enough
to paper over phase issues. This helped us limp along early on.
But really it depends on how bad the issues are at a given speed.
> What changes would be required to the host driver for it to work out of the box?
Maybe the above is enough of a crutch?
prev parent reply other threads:[~2021-07-01 5:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-25 6:10 [PATCH] ARM: dts: tacoma: Add phase corrections for eMMC Andrew Jeffery
2021-07-01 3:40 ` Joel Stanley
2021-07-01 5:08 ` Andrew Jeffery [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).