From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52382C11F64 for ; Thu, 1 Jul 2021 05:09:47 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6D066144E for ; Thu, 1 Jul 2021 05:09:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6D066144E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GFmVK1066z2yyl for ; Thu, 1 Jul 2021 15:09:45 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.a=rsa-sha256 header.s=fm3 header.b=DhkT3nLZ; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=NYPWWtQ0; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=aj.id.au (client-ip=66.111.4.26; helo=out2-smtp.messagingengine.com; envelope-from=andrew@aj.id.au; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.a=rsa-sha256 header.s=fm3 header.b=DhkT3nLZ; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm3 header.b=NYPWWtQ0; dkim-atps=neutral Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GFmTj5L3nz2xtl; Thu, 1 Jul 2021 15:09:13 +1000 (AEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id DB91C5C00CF; Thu, 1 Jul 2021 01:09:09 -0400 (EDT) Received: from imap43 ([10.202.2.93]) by compute2.internal (MEProxy); Thu, 01 Jul 2021 01:09:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=Af3Co6FyFp9gkhQ3NUa2r1lZjjLS0lS MsBIkx1twd4M=; b=DhkT3nLZ4lDulCckp3cTnT1kZ1l3pTYTsnXokfS+ZhfH7K1 GXxevbWyH/87hCnnsqlv697uHBgrEZgQIMX2p7JnGMTloynuGi8gO7RnrvwVg1s7 7IiZayuCl8xyocra5lvpVGZqNe9kaCNftASlBa20ol3niCeKIKAxoZsvvbWM5C7D lB48aOeu1tRh6Oo8FrMucsOH6FpeQIZI0aEd9K2oUn37VDE6nTgzmMUqgXmavxp0 KDm52WYJmZnyGvDxX8KQP1FmC3mSxmEhyDlxCtrM02XS8YwkLUZTOWdOmuRJoOYl qIbTHJlbPgYf+WBXqhepwGnzYvc3u5LVDGqqGyw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=Af3Co6 FyFp9gkhQ3NUa2r1lZjjLS0lSMsBIkx1twd4M=; b=NYPWWtQ0oHClSW7O5cLZ/7 OhN3LwE03b/SZT4N+9POnqtE+ApWFZRWXeNeIr8tOmn4OFtBlEJlBUdyL58UeJCD bzjSM5ga1EW+3MKlOes7E6ivFMGx6sue+uaWDrr70yaoZzsKXiOrRuZLoLATMNlk FXrQlopx+16Lv3xoFMRKYNXWCuvEzrA4Op7IUJ2QkvKxFkiNN/zhSIq6Lk43oTG9 vvdKLPQeN6f3pm3BS0D6qJPCSz8FOt2QjeSzxR8TE95xviJP/m1ExPWmKDPVbSQc /8X5ACYBNwGe1HT0E9ioTYJG+pjZsZO9CguejDFQcgvwnPdI0T0rmweq+zxM4/gQ == X-ME-Sender:

X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeeihedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesthdtredtreertdenucfhrhhomhepfdetnhgu rhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecuggftrf grthhtvghrnhepudfftddvveekfffgteffffeuveegjeelgefhffejtdehtdfhlefgkeef hfefkeeinecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy:

Received: by mailuser.nyi.internal (Postfix, from userid 501) id 77075AC0073; Thu, 1 Jul 2021 01:09:08 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-530-gd0c265785f-fm-20210616.002-gd0c26578 Mime-Version: 1.0 Message-Id: In-Reply-To: References: <20210625061017.1149942-1-andrew@aj.id.au> Date: Thu, 01 Jul 2021 14:38:48 +0930 From: "Andrew Jeffery" To: "Joel Stanley" Subject: Re: [PATCH] ARM: dts: tacoma: Add phase corrections for eMMC Content-Type: text/plain X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , linux-aspeed , OpenBMC Maillist , Linux Kernel Mailing List , Rob Herring , Linux ARM Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, 1 Jul 2021, at 13:10, Joel Stanley wrote: > On Fri, 25 Jun 2021 at 06:10, Andrew Jeffery wrote: > > > > The degree values were reversed out from the magic tap values of 7 (in) > > and 15 + inversion (out) initially suggested by Aspeed. > > > > With the patch tacoma survives several gigabytes of reads and writes > > using dd while without it locks up randomly during the boot process. > > > > Signed-off-by: Andrew Jeffery > > Thanks for the fix. Is this required due to "mmc: sdhci-of-aspeed: Add > AST2600 bus clock support" or "mmc: sdhci-of-aspeed: Expose clock > phase controls"? Sort of neither, it's really a bug with the devicetrees. > > On the topic of those patches, it would be good if we could operate > the devices (with the slower speed?) when the device tree does not > provide the phase values. Think about system bringup, or where you > need the system booting in order to determine the phase calculations. You can use the maximum-frequency binding to make things go slow enough to paper over phase issues. This helped us limp along early on. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/mmc/mmc-controller.yaml?h=v5.13#n90 But really it depends on how bad the issues are at a given speed. > > What changes would be required to the host driver for it to work out of the box? Maybe the above is enough of a crutch? Andrew