Re: Question of phosphor-sel-logger

From: rgrs <rgrs@protonmail.com>
To: Matt Spinler <mspinler@linux.ibm.com>
Cc: Duke Du <Duke.Du@quantatw.com>, Fran Hsu <Fran.Hsu@quantatw.com>,
	"vernon.mauery@linux.intel.com" <vernon.mauery@linux.intel.com>,
	"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	"jason.m.bills@linux.intel.com" <jason.m.bills@linux.intel.com>,
	George Hung <George.Hung@quantatw.com>
Subject: Re: Question of phosphor-sel-logger
Date: Wed, 24 Mar 2021 16:07:42 +0000	[thread overview]
Message-ID: <paWNyD0YyWB8JqlKoxpFjZVediObwa3_9OTOgRnRz3IuDGKI9LXWNuDdKD6J0etwd8dH8CFC-QdiryYtIPerypJ0UQ5qaSDoU0hGVqJB5BY=@protonmail.com> (raw)
In-Reply-To: <707efde2-b301-fc23-be4c-92d1d96d8432@linux.ibm.com>

Hi,

On similar lines, phosphor-sel-logger doesn't add callout to logging entries.

How are the SEL entries parsed by phosphor-ipmi-hostd without respective sensor, inventory path?

Thanks,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, 24 March 2021 18:50, Matt Spinler <mspinler@linux.ibm.com> wrote:

> On 3/24/2021 6:28 AM, Duke Du (杜祥嘉) wrote:
>
> > Hi all,
> >
> >       I used package phosphor-hwmon and phospor-sel-logger to monitor sensor and create log when sensor reading
> >     cross the threshold. I found after the commit 25b26e162bd109b51aa09b16f26f9aa3d9d940fa of phosphor-sel-logger
> >     would catch the signal "ThresholdAsserted" to create sensor threhold log in the journal, but the phosphor-hwmon
> >     would not send the signal "ThresholdAsserted" when sensor reading is abnormal so that phosphor-sel-logger
> >     would not create the sensor threhold log, am I right ?
> >
> >     If I'm right, can you give me some suggestion to fix this side effect, or what setting I have lost in the
> >     phosphor-hwmon or phosphor-sel-logger ?
> >
>
> Hi,
> That signal isn't defined in phosphor-dbus-interfaces, so phosphor-hwmon
> cannot use it.  When I tried to add it, it was rejected as-is with a
> recommendation to break it up into separate signals for each alarm
> property on each interface.  At that point I gave up and had the code I
> was working on at the time just look at propertiesChanged signals instead.
>
> If you would like to take that up it would entail:
>
> -   Update
>     https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/39899
>     as requested
>
> -   Update phosphor-hwmon to emit the new signals
> -   Update phosphor-sel-logger to also listen for these new signals in
>     addition to the  current one, or change the dbus-sensors code to only
>     emit the new signals.
>
>
> >     phosphor-sel-logger commit 25b26e162bd109b51aa09b16f26f9aa3d9d940fa link :
> >     https://github.com/openbmc/phosphor-sel-logger/commit/25b26e162bd109b51aa09b16f26f9aa3d9d940fa
> >
> >     Thanks very much !
> >     Duke
> >