openembedded-core.lists.openembedded.org archive mirror
 help / color / mirror / Atom feed
* [OE-core][PATCH] kernel: add missing path to search for debug files
@ 2022-01-19 11:57 Andrej Valek
  2022-01-19 16:48 ` Richard Purdie
  0 siblings, 1 reply; 5+ messages in thread
From: Andrej Valek @ 2022-01-19 11:57 UTC (permalink / raw)
  To: openembedded-core; +Cc: saul.wold, Andrej Valek

Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}-dbg has
been added to kernel, it has to cover all PACKAGE_DEBUG_SPLIT_STYLE
options. For ex. when the variable "debug-file-directory" package search
path has to be set explicitly, otherwise it will not find any files.

Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
---
 meta/classes/kernel.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 473e28be47..9ea201c936 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = ""
 FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build"
 FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux-${KERNEL_VERSION_NAME}"
 FILES:${KERNEL_PACKAGE_NAME}-modules = ""
+FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug /usr/src/debug"
 RDEPENDS:${KERNEL_PACKAGE_NAME} = "${KERNEL_PACKAGE_NAME}-base (= ${EXTENDPKGV})"
 # Allow machines to override this dependency if kernel image files are
 # not wanted in images as standard
-- 
2.31.1



^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [OE-core][PATCH] kernel: add missing path to search for debug files
  2022-01-19 11:57 [OE-core][PATCH] kernel: add missing path to search for debug files Andrej Valek
@ 2022-01-19 16:48 ` Richard Purdie
  2022-01-21  9:18   ` Michael Opdenacker
  0 siblings, 1 reply; 5+ messages in thread
From: Richard Purdie @ 2022-01-19 16:48 UTC (permalink / raw)
  To: Andrej Valek, openembedded-core; +Cc: saul.wold

On Wed, 2022-01-19 at 12:57 +0100, Andrej Valek wrote:
> Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}-dbg has
> been added to kernel, it has to cover all PACKAGE_DEBUG_SPLIT_STYLE
> options. For ex. when the variable "debug-file-directory" package search
> path has to be set explicitly, otherwise it will not find any files.
> 
> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
> ---
>  meta/classes/kernel.bbclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 473e28be47..9ea201c936 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = ""
>  FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build"
>  FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux-${KERNEL_VERSION_NAME}"
>  FILES:${KERNEL_PACKAGE_NAME}-modules = ""
> +FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug /usr/src/debug"

This seems to highlight that we have no tests for KERNEL_PACKAGE_NAME. At the
very least we need a bugzilla entry for creating some...

Cheers,

Richard



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [OE-core][PATCH] kernel: add missing path to search for debug files
  2022-01-19 16:48 ` Richard Purdie
@ 2022-01-21  9:18   ` Michael Opdenacker
  2022-01-24  8:19     ` Valek, Andrej
       [not found]     ` <16CD270F9BE96264.31480@lists.openembedded.org>
  0 siblings, 2 replies; 5+ messages in thread
From: Michael Opdenacker @ 2022-01-21  9:18 UTC (permalink / raw)
  To: Richard Purdie, Andrej Valek, openembedded-core; +Cc: saul.wold


On 1/19/22 5:48 PM, Richard Purdie wrote:
> On Wed, 2022-01-19 at 12:57 +0100, Andrej Valek wrote:
>> Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}-dbg has
>> been added to kernel, it has to cover all PACKAGE_DEBUG_SPLIT_STYLE
>> options. For ex. when the variable "debug-file-directory" package search
>> path has to be set explicitly, otherwise it will not find any files.
>>
>> Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
>> ---
>>  meta/classes/kernel.bbclass | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 473e28be47..9ea201c936 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = ""
>>  FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map* /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH} ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build"
>>  FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux-${KERNEL_VERSION_NAME}"
>>  FILES:${KERNEL_PACKAGE_NAME}-modules = ""
>> +FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug /usr/src/debug"
> This seems to highlight that we have no tests for KERNEL_PACKAGE_NAME. At the
> very least we need a bugzilla entry for creating some...


Done: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14700
Cheers
Michael

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [OE-core][PATCH] kernel: add missing path to search for debug files
  2022-01-21  9:18   ` Michael Opdenacker
@ 2022-01-24  8:19     ` Valek, Andrej
       [not found]     ` <16CD270F9BE96264.31480@lists.openembedded.org>
  1 sibling, 0 replies; 5+ messages in thread
From: Valek, Andrej @ 2022-01-24  8:19 UTC (permalink / raw)
  To: richard.purdie; +Cc: openembedded-core, michael.opdenacker, saul.wold

Hello Richard,

Fine, that we have it, but are you going to take a look on the patch :)
?

Regards,
Andrej

On Fri, 2022-01-21 at 10:18 +0100, Michael Opdenacker wrote:
> 
> On 1/19/22 5:48 PM, Richard Purdie wrote:
> > On Wed, 2022-01-19 at 12:57 +0100, Andrej Valek wrote:
> > > Since explicit debug package creation via ${KERNEL_PACKAGE_NAME}-
> > > dbg has
> > > been added to kernel, it has to cover all
> > > PACKAGE_DEBUG_SPLIT_STYLE
> > > options. For ex. when the variable "debug-file-directory" package
> > > search
> > > path has to be set explicitly, otherwise it will not find any
> > > files.
> > > 
> > > Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
> > > ---
> > >  meta/classes/kernel.bbclass | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/meta/classes/kernel.bbclass
> > > b/meta/classes/kernel.bbclass
> > > index 473e28be47..9ea201c936 100644
> > > --- a/meta/classes/kernel.bbclass
> > > +++ b/meta/classes/kernel.bbclass
> > > @@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = ""
> > >  FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map*
> > > /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH}
> > > ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build"
> > >  FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux-
> > > ${KERNEL_VERSION_NAME}"
> > >  FILES:${KERNEL_PACKAGE_NAME}-modules = ""
> > > +FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug
> > > /usr/src/debug"
> > This seems to highlight that we have no tests for
> > KERNEL_PACKAGE_NAME. At the
> > very least we need a bugzilla entry for creating some...
> 
> 
> Done: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14700
> Cheers
> Michael
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [OE-core][PATCH] kernel: add missing path to search for debug files
       [not found]     ` <16CD270F9BE96264.31480@lists.openembedded.org>
@ 2022-05-12  5:46       ` Valek, Andrej
  0 siblings, 0 replies; 5+ messages in thread
From: Valek, Andrej @ 2022-05-12  5:46 UTC (permalink / raw)
  To: richard.purdie; +Cc: openembedded-core, michael.opdenacker, saul.wold

ping

On Mon, 2022-01-24 at 08:19 +0000, Andrej Valek via
lists.openembedded.org wrote:
> Hello Richard,
> 
> Fine, that we have it, but are you going to take a look on the patch
> :)
> ?
> 
> Regards,
> Andrej
> 
> On Fri, 2022-01-21 at 10:18 +0100, Michael Opdenacker wrote:
> > 
> > On 1/19/22 5:48 PM, Richard Purdie wrote:
> > > On Wed, 2022-01-19 at 12:57 +0100, Andrej Valek wrote:
> > > > Since explicit debug package creation via
> > > > ${KERNEL_PACKAGE_NAME}-
> > > > dbg has
> > > > been added to kernel, it has to cover all
> > > > PACKAGE_DEBUG_SPLIT_STYLE
> > > > options. For ex. when the variable "debug-file-directory"
> > > > package
> > > > search
> > > > path has to be set explicitly, otherwise it will not find any
> > > > files.
> > > > 
> > > > Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
> > > > ---
> > > >  meta/classes/kernel.bbclass | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > > 
> > > > diff --git a/meta/classes/kernel.bbclass
> > > > b/meta/classes/kernel.bbclass
> > > > index 473e28be47..9ea201c936 100644
> > > > --- a/meta/classes/kernel.bbclass
> > > > +++ b/meta/classes/kernel.bbclass
> > > > @@ -647,6 +647,7 @@ FILES:${KERNEL_PACKAGE_NAME}-image = ""
> > > >  FILES:${KERNEL_PACKAGE_NAME}-dev = "/boot/System.map*
> > > > /boot/Module.symvers* /boot/config* ${KERNEL_SRC_PATH}
> > > > ${nonarch_base_libdir}/modules/${KERNEL_VERSION}/build"
> > > >  FILES:${KERNEL_PACKAGE_NAME}-vmlinux = "/boot/vmlinux-
> > > > ${KERNEL_VERSION_NAME}"
> > > >  FILES:${KERNEL_PACKAGE_NAME}-modules = ""
> > > > +FILES:${KERNEL_PACKAGE_NAME}-dbg = "/usr/lib/debug
> > > > /usr/src/debug"
> > > This seems to highlight that we have no tests for
> > > KERNEL_PACKAGE_NAME. At the
> > > very least we need a bugzilla entry for creating some...
> > 
> > 
> > Done: https://bugzilla.yoctoproject.org/show_bug.cgi?id=14700
> > Cheers
> > Michael
> > 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#160872):
> https://lists.openembedded.org/g/openembedded-core/message/160872
> Mute This Topic: https://lists.openembedded.org/mt/88532225/3619876
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub [
> andrej.valek@siemens.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-12  5:46 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-19 11:57 [OE-core][PATCH] kernel: add missing path to search for debug files Andrej Valek
2022-01-19 16:48 ` Richard Purdie
2022-01-21  9:18   ` Michael Opdenacker
2022-01-24  8:19     ` Valek, Andrej
     [not found]     ` <16CD270F9BE96264.31480@lists.openembedded.org>
2022-05-12  5:46       ` Valek, Andrej

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).