From: Dan McGregor <danismostlikely@gmail.com>
To: zboszor@pr.hu
Cc: "Patches and discussions about the oe-core layer"
<openembedded-core@lists.openembedded.org>,
"Zoltán Böszörményi" <zboszor@gmail.com>
Subject: Re: [OE-core] [PATCH] libpam: Fix build with DISTRO_FEATURES usrmerge
Date: Wed, 13 Oct 2021 13:38:45 -0600 [thread overview]
Message-ID: <CACS+7ZTXToShB1BjSA3WBB7CbcqWCeRotU3Ki3+WrzJDLLajqg@mail.gmail.com> (raw)
In-Reply-To: <20211012111726.493810-1-zboszor@pr.hu>
Thanks for this. I hit it pretty immediately.
On Tue, 12 Oct 2021 at 05:17, Zoltan Boszormenyi via
lists.openembedded.org <zboszor=pr.hu@lists.openembedded.org> wrote:
>
> From: Zoltán Böszörményi <zboszor@gmail.com>
>
> Signed-off-by: Zoltán Böszörményi <zboszor@gmail.com>
> ---
> meta/recipes-extended/pam/libpam_1.5.2.bb | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-extended/pam/libpam_1.5.2.bb b/meta/recipes-extended/pam/libpam_1.5.2.bb
> index a3c4a50cb3..ee3a84a3b6 100644
> --- a/meta/recipes-extended/pam/libpam_1.5.2.bb
> +++ b/meta/recipes-extended/pam/libpam_1.5.2.bb
> @@ -147,8 +147,10 @@ do_install() {
> if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
> echo "session optional pam_systemd.so" >> ${D}${sysconfdir}/pam.d/common-session
> fi
> - install -d ${D}/${libdir}/
> - mv ${D}/${base_libdir}/pkgconfig ${D}/${libdir}/
> + if ${@bb.utils.contains('DISTRO_FEATURES','usrmerge','false','true',d)}; then
In the patch I made that I kept local for now my condition was
if [ "${base_libdir}" != "${libdir}" ]
It could be that a user sets libdir and base_libdir to be equal
without enabling usrmerge, but both checks solve the immediate
problem.
> + install -d ${D}/${libdir}/
> + mv ${D}/${base_libdir}/pkgconfig ${D}/${libdir}/
> + fi
> }
>
> do_install_ptest() {
> --
> 2.31.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156873): https://lists.openembedded.org/g/openembedded-core/message/156873
> Mute This Topic: https://lists.openembedded.org/mt/86259670/3617261
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [danismostlikely@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
next prev parent reply other threads:[~2021-10-13 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 11:17 [PATCH] libpam: Fix build with DISTRO_FEATURES usrmerge Zoltan Boszormenyi
2021-10-13 19:38 ` Dan McGregor [this message]
2021-10-14 6:54 ` [OE-core] " Zoltan Boszormenyi
2021-10-14 11:39 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACS+7ZTXToShB1BjSA3WBB7CbcqWCeRotU3Ki3+WrzJDLLajqg@mail.gmail.com \
--to=danismostlikely@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=zboszor@gmail.com \
--cc=zboszor@pr.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).