Re: [OE-core] [PATCH v3 2/2] vulkan-validation-layers: add new recipe v1.3.243.0

[Khem Raj <raj.khem@gmail.com>]

its failing on all qemu arches for me, so I looked a bit more into it,
Some differences are  that
my distro uses usrmerge feature and clang compiler. Secondly the error
is because a spurious target
is added to generated makefiles which then fails.

| NOTE: cmake --build
/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/vulkan-validation-layers/1.3.243.0-r0/build
--target all --
| ninja: error:
'/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/vulkan-validation-layers/1.3.243.0-r0/recipe-sysroot/usr/usr/lib',
needed by 'layers/libVkLayer_khronos_validation.so', missing and no
known rule to make it

seems to arise from autodetection of cmake modules, so somehow when
SPIRV-Tools target is added
then it ends up adding the bad target
LINK_LIBRARIES = layers/libVkLayer_utils.a
/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/vulkan-validation-layers/1.3.243.0-r0/recipe-sysroot/usr/lib/libSPIRV-Tools.so
 /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux/vulkan-validation-layers/1.3.243.0-r0/recipe-sysroot/usr/usr/lib

I narrowed it further down to

diff --git a/layers/CMakeLists.txt b/layers/CMakeLists.txt
index 1a67fac2e..ffd031c62 100644
--- a/layers/CMakeLists.txt
+++ b/layers/CMakeLists.txt
@@ -96,7 +96,7 @@ find_package(SPIRV-Headers REQUIRED CONFIG QUIET)
 target_link_libraries(VVL-SPIRV-LIBS INTERFACE SPIRV-Headers::SPIRV-Headers)

 find_package(SPIRV-Tools-opt REQUIRED CONFIG QUIET)
-target_link_libraries(VVL-SPIRV-LIBS INTERFACE SPIRV-Tools-opt)
+#target_link_libraries(VVL-SPIRV-LIBS INTERFACE SPIRV-Tools-opt)

 find_package(SPIRV-Tools REQUIRED CONFIG QUIET)

@@ -104,7 +104,7 @@ find_package(SPIRV-Tools REQUIRED CONFIG QUIET)
 # The targets available from SPIRV-Tools change depending on how
SPIRV_TOOLS_BUILD_STATIC is set.
 # Try to handle all possible combinations so that we work with
externally built packages.
 if (TARGET SPIRV-Tools)
-    target_link_libraries(VVL-SPIRV-LIBS INTERFACE SPIRV-Tools)
+#    target_link_libraries(VVL-SPIRV-LIBS INTERFACE SPIRV-Tools)
 elseif(TARGET SPIRV-Tools-static)
     target_link_libraries(VVL-SPIRV-LIBS INTERFACE SPIRV-Tools-static)
 elseif(TARGET SPIRV-Tools-shared)

so it seems SPIRV-tools package might have this issue or something more to it.

you can reproduce this easily with yoe distro for any qemu target project.



On Sat, Jun 10, 2023 at 11:55 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> seen more failures on qemux86 and qemumips
>
> https://errors.yoctoproject.org/Errors/Details/708137/
>
> On Fri, Jun 9, 2023 at 1:57 PM Vincent Davis Jr <vince@underview.tech> wrote:
> >
> > Created patch series should be fine to build now
> >
> > 1. https://lists.yoctoproject.org/g/meta-freescale/message/24918
> > 2. https://lists.yoctoproject.org/g/meta-freescale/message/24919
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#182598): https://lists.openembedded.org/g/openembedded-core/message/182598
> > Mute This Topic: https://lists.openembedded.org/mt/99365321/1997914
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >