From: Martin Jansa <martin.jansa@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-devel <openembedded-devel@lists.openembedded.org>,
Marco Cavallini <m.cavallini@koansoftware.com>
Subject: Re: [meta-networking][PATCH 1/2] bluepy: Set PV and correct syntax for RDEPENDS
Date: Wed, 20 Oct 2021 19:25:28 +0200 [thread overview]
Message-ID: <CA+chaQcUrs4RUubDHhP66L2Y4SXx3-MBKD9h2X8858DCmjhMuA@mail.gmail.com> (raw)
In-Reply-To: <20211020172214.394631-1-raj.khem@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2030 bytes --]
Thanks! <3
On Wed, Oct 20, 2021 at 7:22 PM Khem Raj <raj.khem@gmail.com> wrote:
> Also organize the recipe to to match OE style
> Remove PYTHON_PN from DEPENDS, setuptools should be enough
> Correct setting LIC_FILES_CHKSUM
> Move setting git SHA to SRCREV
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Marco Cavallini <m.cavallini@koansoftware.com>
> Cc: Martin Jansa <martin.jansa@gmail.com>
> ---
> .../recipes-connectivity/bluepy/bluepy_git.bb | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/meta-networking/recipes-connectivity/bluepy/bluepy_git.bb
> b/meta-networking/recipes-connectivity/bluepy/bluepy_git.bb
> index 03b1562b60..c1bcbc25b1 100644
> --- a/meta-networking/recipes-connectivity/bluepy/bluepy_git.bb
> +++ b/meta-networking/recipes-connectivity/bluepy/bluepy_git.bb
> @@ -1,17 +1,19 @@
> DESCRIPTION = "Python interface to Bluetooth LE on Linux"
> HOMEPAGE = "https://github.com/IanHarvey/bluepy"
> SECTION = "devel/python"
> +LICENSE = "GPLv2 & PD"
> +LIC_FILES_CHKSUM =
> "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6
> \
> +
> file://${COREBASE}/meta/files/common-licenses/PD;md5=b3597d12946881e13cb3b548d1173851"
> +DEPENDS = "glib-2.0"
> +SRCREV = "7ad565231a97c304c0eff45f2649cd005e69db09"
> +PV = "1.3.0+git${SRCPV}"
>
> -DEPENDS = "${PYTHON_PN} glib-2.0"
> -RDEPENDS_${PN} = "bluez5"
> +SRC_URI = "git://github.com/IanHarvey/bluepy.git;protocol=https"
>
> -LICENSE = "GPLv2 & PD"
> -LIC_FILES_CHKSUM =
> "file://${COREBASE}/meta/files/common-licenses/GPL-2.0;md5=801f80980d171dd6425610833a22dbe6"
> -LIC_FILES_CHKSUM =
> "file://${COREBASE}/meta/files/common-licenses/PD;md5=b3597d12946881e13cb3b548d1173851"
> +S = "${WORKDIR}/git"
>
> inherit setuptools3 pkgconfig
>
> -SRC_URI = "git://
> github.com/IanHarvey/bluepy.git;protocol=https;rev=7ad565231a97c304c0eff45f2649cd005e69db09
> "
> -S = "${WORKDIR}/git"
> +RDEPENDS:${PN} = "bluez5"
>
> TARGET_CC_ARCH += "${LDFLAGS}"
> --
> 2.33.1
>
>
[-- Attachment #2: Type: text/html, Size: 3548 bytes --]
prev parent reply other threads:[~2021-10-20 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 17:22 [meta-networking][PATCH 1/2] bluepy: Set PV and correct syntax for RDEPENDS Khem Raj
2021-10-20 17:22 ` [meta-python][PATCH 2/2] python3-kivy: Use new override syntax in RDEPENDS Khem Raj
2021-10-20 17:25 ` Martin Jansa
2021-10-20 17:25 ` Martin Jansa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+chaQcUrs4RUubDHhP66L2Y4SXx3-MBKD9h2X8858DCmjhMuA@mail.gmail.com \
--to=martin.jansa@gmail.com \
--cc=m.cavallini@koansoftware.com \
--cc=openembedded-devel@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).