From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF31C7EE24 for ; Tue, 6 Jun 2023 15:10:40 +0000 (UTC) Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by mx.groups.io with SMTP id smtpd.web10.1204.1686064237497154855 for ; Tue, 06 Jun 2023 08:10:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@gmail.com header.s=20221208 header.b=AIAihBvX; spf=pass (domain: gmail.com, ip: 209.85.217.50, mailfrom: raj.khem@gmail.com) Received: by mail-vs1-f50.google.com with SMTP id ada2fe7eead31-43b2fb0afa6so1378010137.1 for ; Tue, 06 Jun 2023 08:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686064236; x=1688656236; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=W/wAOWCzaeqwOrQn7oW6SeNWvWVRSzbbGbyoGUOTxlg=; b=AIAihBvXzE7BHiF9IJMP+9RXLZ2iWC42QIyvilltBoKH23ao0l7GfollbI1lbOkFkw 7kKH/Uc1ynRSV/dpdP0BU8z/hrxkuhhyYu+//sYkP9iqvGRVfyIgqsLkJlT3Vh7Q2qJN X/fI7F2KNMwbReJRiwJUg67g+Z70Q2UlbsswF/EpWa4DGVOTlkwc8S44SWvQ+5pcOaVI nablac50dUs95GuBhbQG+1mYSoDc/9jdmmf+JUciXfGVus0qVX+vtTrUxPGJgU7WHUPy JS2dkc8HPNGjMVKr+CnX5zUhAEzo7NM3AOvtCbtNCyQ7e1Xtkz/TPojqIeXtSYIaFZZg 3kSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686064236; x=1688656236; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W/wAOWCzaeqwOrQn7oW6SeNWvWVRSzbbGbyoGUOTxlg=; b=S/fouxao/4D8ib5RG5nlGl+CjxDkNBkC4q2nYcZCRYBb173JIXDFabsAIbipeO0QgY q6v6D6TMrovlITD73OFhbCmmagKgPKFaMHQIijTomc8WGvWNav2HxZlfFYraJ6kJHyTf +P/N5GQRL9gTd49NbdpZarNpSEgpCiT8uHzrvRCboQdCTgeUYmPgkBos0dhF0fXkkc8O cK6OiDddk9eXBGv+YQqXN1DL2L7Yk6FPilRzlJvv8PbEnyng3AZD2DiNDoyWncTpIcRb panOpJNsHJAm7REtAPTTbwqzxd3mBhqKOPr9bbmabDLJk9k5pPh2+FaWnSQSkl6l+MK7 PUAg== X-Gm-Message-State: AC+VfDwAPuarsIhWBOJ+KNljMrh27LMsVfZMhjoo84NbCFZIQSih96FJ Nt2DW05SeHiF5cv2julJXbF74XwImnAJVUFjUmI= X-Google-Smtp-Source: ACHHUZ5CdQoqDxbrC0hlBJj9VyZIlZ9aSzGa0P7FrdZWOSAG7jUQHco1WanESeb2iFS0WyZ7ZpNQph2186srIMiizZ4= X-Received: by 2002:a67:f850:0:b0:43b:16cf:1dda with SMTP id b16-20020a67f850000000b0043b16cf1ddamr1235520vsp.27.1686064236344; Tue, 06 Jun 2023 08:10:36 -0700 (PDT) MIME-Version: 1.0 References: <20230531082437.10646-1-brgl@bgdev.pl> <20230531082437.10646-64-brgl@bgdev.pl> In-Reply-To: From: Khem Raj Date: Tue, 6 Jun 2023 08:10:25 -0700 Message-ID: Subject: Re: [meta-python][PATCH 063/149] python3-pytest-mock: add missing run-time dependencies To: Bartosz Golaszewski Cc: Bartosz Golaszewski , Bruce Ashfield , openembedded-devel@lists.openembedded.org Content-Type: multipart/alternative; boundary="000000000000e03b3f05fd776b09" List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Tue, 06 Jun 2023 15:10:40 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/103147 --000000000000e03b3f05fd776b09 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jun 6, 2023 at 2:05 AM Bartosz Golaszewski wrote: > On Mon, Jun 5, 2023 at 8:09=E2=80=AFPM Khem Raj wrot= e: > > > > on qemux86-64/glibc I am seeing > > > > AssertionError: > > Failed ptests: > > {'python3-pytest-mock': > > ['tests/test_pytest_mock.py::test_assert_called_args_with_introspection= ', > > > > > 'tests/test_pytest_mock.py::test_assert_called_kwargs_with_introspection'= , > > > > 'tests/test_pytest_mock.py::test_detailed_introspection_async', > > 'tests/test_pytest_mock.py::test_plain_stopall= ', > > > > 'tests/test_pytest_mock.py::test_used_with_class_scope', > > > > 'tests/test_pytest_mock.py::test_used_with_module_scope', > > > > 'tests/test_pytest_mock.py::test_used_with_package_scope', > > > > 'tests/test_pytest_mock.py::test_used_with_session_scope']} > > > > > > Cannot run ptests without @expectedFailure as ptests are expected to fa= il > > > > I'm not sure I follow. Without this patch the ptests can't even be > started as pytest is not available for import, so it's not really a > regression. That=E2=80=99s fine all we need it disable from auto run > > > Bart > > > On Wed, May 31, 2023 at 1:26=E2=80=AFAM Bartosz Golaszewski > wrote: > > > > > > From: Bartosz Golaszewski > > > > > > Add missing RDEPENDS for this package. > > > > > > Signed-off-by: Bartosz Golaszewski > > > --- > > > .../recipes-devtools/python/python3-pytest-mock_3.10.0.bb | 6 > ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/meta-python/recipes-devtools/python/ > python3-pytest-mock_3.10.0.bb b/meta-python/recipes-devtools/python/ > python3-pytest-mock_3.10.0.bb > > > index c4e672f33..bf5bc250a 100644 > > > --- a/meta-python/recipes-devtools/python/ > python3-pytest-mock_3.10.0.bb > > > +++ b/meta-python/recipes-devtools/python/ > python3-pytest-mock_3.10.0.bb > > > @@ -18,6 +18,12 @@ inherit setuptools3 ptest > > > > > > DEPENDS +=3D "${PYTHON_PN}-setuptools-scm-native" > > > > > > +RDEPENDS:${PN} +=3D " \ > > > + python3-asyncio \ > > > + python3-pytest \ > > > + python3-unittest \ > > > +" > > > + > > > S =3D "${WORKDIR}/git" > > > > > > do_install_ptest() { > > > -- > > > 2.39.2 > > > > --000000000000e03b3f05fd776b09 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Jun 6, 2023 at 2:05 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
On Mon, Jun 5, 2023 at 8:09=E2=80=AFPM Khem Raj <= raj.khem@gmail.com<= /a>> wrote:
>
> on qemux86-64/glibc I am seeing
>
> AssertionError:
> Failed ptests:
> {'python3-pytest-mock':
> ['tests/test_pytest_mock.py::test_assert_called_args_with_introspe= ction',
>
> 'tests/test_pytest_mock.py::test_assert_called_kwargs_with_introsp= ection',
>
> 'tests/test_pytest_mock.py::test_detailed_introspection_async'= ,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 'tests/test_pytest_mock.py::test_plain_stopall'= ;,
>
> 'tests/test_pytest_mock.py::test_used_with_class_scope',
>
> 'tests/test_pytest_mock.py::test_used_with_module_scope',
>
> 'tests/test_pytest_mock.py::test_used_with_package_scope',
>
> 'tests/test_pytest_mock.py::test_used_with_session_scope']} >
>
> Cannot run ptests without @expectedFailure as ptests are expected to f= ail
>

I'm not sure I follow. Without this patch the ptests can't even be<= br> started as pytest is not available for import, so it's not really a
regression.

That= =E2=80=99s fine all we need it disable from auto run=C2=A0


Bart

> On Wed, May 31, 2023 at 1:26=E2=80=AFAM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > >
> > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> >
> > Add missing RDEPENDS for this package.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> > ---
> >=C2=A0 .../recipes-devtools/python/python3-pytest-mock_= 3.10.0.bb=C2=A0 =C2=A0| 6 ++++++
> >=C2=A0 1 file changed, 6 insertions(+)
> >
> > diff --git a/meta-python/recipes-devtools/python/pytho= n3-pytest-mock_3.10.0.bb b/meta-python/recipes-devtools/python/python3-pytest-mock_3.10.0.bb
> > index c4e672f33..bf5bc250a 100644
> > --- a/meta-python/recipes-devtools/python/python3-pyte= st-mock_3.10.0.bb
> > +++ b/meta-python/recipes-devtools/python/python3-pyte= st-mock_3.10.0.bb
> > @@ -18,6 +18,12 @@ inherit setuptools3 ptest
> >
> >=C2=A0 DEPENDS +=3D "${PYTHON_PN}-setuptools-scm-native"=
> >
> > +RDEPENDS:${PN} +=3D " \
> > +=C2=A0 =C2=A0 python3-asyncio \
> > +=C2=A0 =C2=A0 python3-pytest \
> > +=C2=A0 =C2=A0 python3-unittest \
> > +"
> > +
> >=C2=A0 S =3D "${WORKDIR}/git"
> >
> >=C2=A0 do_install_ptest() {
> > --
> > 2.39.2
> >
--000000000000e03b3f05fd776b09--