Re: [oe] [PATCH 08/24] netplan: do not use -Werror

[Alexander Kanavin <alex.kanavin@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 5652 bytes --]

Right, I can send fixups for all these, but would it be faster and less
friction if you simply add them yourself?

Alex

On Tue, 12 Oct 2021 at 02:03, Khem Raj <raj.khem@gmail.com> wrote:

>
>
> On Mon, Oct 11, 2021 at 3:00 PM Alexander Kanavin <alex.kanavin@gmail.com>
> wrote:
>
>> Sorry - it was due to the same openssl 3.x deprecation warnings turning
>> into errors. Generally I think we should want -Werror anywhere, it's
>> something only upstream should use, not distro integrators.
>> M
>>
>
> That’s fine if the project provides a convenient way to do so via config
> arguments or some such but if we need to maintain patches to achieve this
> then it’s something we have to be mindful of Since this will require
> maintenance however for this patch please add this to commit msg as to why
> we are disabling it and then perhaps drop it when it’s fixed in future
>
> Alex
>>
>> On Mon, 11 Oct 2021 at 22:32, Khem Raj <raj.khem@gmail.com> wrote:
>>
>>>
>>>
>>> On 10/11/21 11:41 AM, Alexander Kanavin wrote:
>>> > Signed-off-by: Alexander Kanavin <alex@linutronix.de>
>>> > ---
>>> >   .../0001-Makefile-do-not-use-Werror.patch     | 23
>>> +++++++++++++++++++
>>> >   ...-t-fail-if-GLOB_BRACE-is-not-defined.patch |  7 ++++--
>>> >   .../netplan/netplan_0.103.bb                  |  4 +++-
>>> >   3 files changed, 31 insertions(+), 3 deletions(-)
>>> >   create mode 100644
>>> meta-networking/recipes-connectivity/netplan/netplan/0001-Makefile-do-not-use-Werror.patch
>>> >
>>> > diff --git
>>> a/meta-networking/recipes-connectivity/netplan/netplan/0001-Makefile-do-not-use-Werror.patch
>>> b/meta-networking/recipes-connectivity/netplan/netplan/0001-Makefile-do-not-use-Werror.patch
>>> > new file mode 100644
>>> > index 000000000..ddc44c3ca
>>> > --- /dev/null
>>> > +++
>>> b/meta-networking/recipes-connectivity/netplan/netplan/0001-Makefile-do-not-use-Werror.patch
>>> > @@ -0,0 +1,23 @@
>>> > +From a06c77557ed951249d5b344441ad6ec57410e63f Mon Sep 17 00:00:00 2001
>>> > +From: Alexander Kanavin <alex@linutronix.de>
>>> > +Date: Sun, 3 Oct 2021 21:52:16 +0200
>>> > +Subject: [PATCH] Makefile: do not use -Werror
>>> > +
>>> > +Upstream-Status: Inappropriate [oe-core specific]
>>> > +Signed-off-by: Alexander Kanavin <alex@linutronix.de>
>>> > +---
>>> > + Makefile | 1 -
>>> > + 1 file changed, 1 deletion(-)
>>> > +
>>> > +diff --git a/Makefile b/Makefile
>>> > +index 8645aee..50fc0da 100644
>>> > +--- a/Makefile
>>> > ++++ b/Makefile
>>> > +@@ -7,7 +7,6 @@ BUILDFLAGS = \
>>> > +     -D_XOPEN_SOURCE=500 \
>>> > +     -DSBINDIR=\"$(SBINDIR)\" \
>>> > +     -Wall \
>>> > +-    -Werror \
>>>
>>> Why is this change needed? Can you describe the scenario a bit, perhaps
>>> better if its in the patch header itself.
>>>
>>> > +     $(NULL)
>>> > +
>>> > + SYSTEMD_GENERATOR_DIR=$(shell pkg-config
>>> --variable=systemdsystemgeneratordir systemd)
>>> > diff --git
>>> a/meta-networking/recipes-connectivity/netplan/netplan/0001-don-t-fail-if-GLOB_BRACE-is-not-defined.patch
>>> b/meta-networking/recipes-connectivity/netplan/netplan/0001-don-t-fail-if-GLOB_BRACE-is-not-defined.patch
>>> > index 0fa6ba48a..c7d371dfa 100644
>>> > ---
>>> a/meta-networking/recipes-connectivity/netplan/netplan/0001-don-t-fail-if-GLOB_BRACE-is-not-defined.patch
>>> > +++
>>> b/meta-networking/recipes-connectivity/netplan/netplan/0001-don-t-fail-if-GLOB_BRACE-is-not-defined.patch
>>> > @@ -1,16 +1,19 @@
>>> > -From ceb4111af317ecc54d97bb21878dcccbfdb2983e Mon Sep 17 00:00:00 2001
>>> > +From e0df1f07d1707d5daf0358cc60b30f06121f7e60 Mon Sep 17 00:00:00 2001
>>> >   From: Zang Ruochen <zangrc.fnst@cn.fujitsu.com>
>>> >   Date: Fri, 25 Dec 2020 11:41:43 +0900
>>> >   Subject: [PATCH] don't fail if GLOB_BRACE is not defined
>>> >
>>> >   Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com>
>>> > +
>>> >   ---
>>> >    src/util.c | 6 ++++++
>>> >    1 file changed, 6 insertions(+)
>>> >
>>> > +diff --git a/src/util.c b/src/util.c
>>> > +index a4c0dba..fd4542d 100644
>>> >   --- a/src/util.c
>>> >   +++ b/src/util.c
>>> > -@@ -24,6 +24,12 @@
>>> > +@@ -25,6 +25,12 @@
>>> >    #include "util.h"
>>> >    #include "netplan.h"
>>> >
>>> > diff --git a/meta-networking/recipes-connectivity/netplan/
>>> netplan_0.103.bb b/meta-networking/recipes-connectivity/netplan/
>>> netplan_0.103.bb
>>> > index 682a6b611..3527bceeb 100644
>>> > --- a/meta-networking/recipes-connectivity/netplan/netplan_0.103.bb
>>> > +++ b/meta-networking/recipes-connectivity/netplan/netplan_0.103.bb
>>> > @@ -15,7 +15,9 @@ SRCREV = "51c872d856db80281ea810ebc02e05c09d5310fa"
>>> >   PV = "0.103"
>>> >
>>> >   SRC_URI = "git://github.com/CanonicalLtd/netplan.git;branch=main \
>>> > -           file://0001-parse-nm-fix-32bit-format-string.patch"
>>> > +           file://0001-parse-nm-fix-32bit-format-string.patch \
>>> > +           file://0001-Makefile-do-not-use-Werror.patch \
>>> > +           "
>>> >
>>> >   SRC_URI:append:libc-musl = "
>>> file://0001-don-t-fail-if-GLOB_BRACE-is-not-defined.patch"
>>> >
>>> >
>>> >
>>> >
>>> > -=-=-=-=-=-=-=-=-=-=-=-
>>> > Links: You receive all messages sent to this group.
>>> > View/Reply Online (#93221):
>>> https://lists.openembedded.org/g/openembedded-devel/message/93221
>>> > Mute This Topic: https://lists.openembedded.org/mt/86244755/1997914
>>> > Group Owner: openembedded-devel+owner@lists.openembedded.org
>>> > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub
>>> [raj.khem@gmail.com]
>>> > -=-=-=-=-=-=-=-=-=-=-=-
>>> >
>>>
>>

[-- Attachment #2: Type: text/html, Size: 8428 bytes --]